Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E53019049B; Tue, 21 Jul 2026 17:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654154; cv=none; b=nmeWBuzl++sp7UHtUwhV45wS53SMC8qre57HyaPfPIlEpQz8zXq6+98ogRrhAZKXxSCII+ybqoyjGfc6RToCPToHnHM8KIuxLAvpBxqtmQxvPwfPMR5i3fsq0/oJgiaCwn1rTQY6VZv0p2h88D8AEDjZRoPYbmF3d8Wqg1WmbrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654154; c=relaxed/simple; bh=Z2G5sZwiuYRabjn2+F2/W6/oUuJWBz1hV1AAMKQxIuc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=r46Ihtlf9ugitiz5jBOpezxhTAQeuLSjJkq0DTA05Ta0CbB6kQybpGbvrroGppx9UxVvItWBkFI3KZR0pkWnh3J1Cn4l4CyPj8DveIKr/bNOysEPg4O1UvhZZlsu49Qm7OzzpK2f5I4+xp2vsGyjYM7KFOyZqaTl75lMhQ/gTrU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VemFbFAZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VemFbFAZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7AFE1F000E9; Tue, 21 Jul 2026 17:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784654153; bh=snsEKx3t/ZAEgRQsE+l0zZ1kFfG1EHCIJPknM89mISM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VemFbFAZJAKOS5qgc386eALT/51pcBOh/jqH78kKHxO5TsuwuwCO/kYbKs9otsexF BOlJRPz40B1HTPLK7TilYevgututOgpLB+9BHzlJlkinym1nJWWy0kCPJa8or9gQ6+ 6Wn1W0L4eh5HgUUhI1QOUBgWrJQGDUa3n3mvOl3E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?C=C3=A1ssio=20Gabriel?= , Mark Brown Subject: [PATCH 7.1 1596/2077] ASoC: mediatek: mt8192: Check runtime resume during probe Date: Tue, 21 Jul 2026 17:21:09 +0200 Message-ID: <20260721152630.416006933@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cássio Gabriel commit e24d5dde56a50946020b134fa8448869093db76a upstream. The MT8192 AFE probe enables runtime PM temporarily while reinitializing the regmap cache from hardware, but it uses pm_runtime_get_sync() without checking the return value. If runtime resume fails, probe keeps going without the device necessarily being accessible, and pm_runtime_get_sync() may leave the PM usage count incremented. The regmap_reinit_cache() failure path also returns before dropping the temporary PM reference and before clearing pm_runtime_bypass_reg_ctl. Use pm_runtime_resume_and_get() so resume failures do not leak a usage count, and clear the temporary bypass flag after dropping the probe PM reference on all regmap_reinit_cache() outcomes. Fixes: 125ab5d588b0 ("ASoC: mediatek: mt8192: add platform driver") Cc: stable@vger.kernel.org Signed-off-by: Cássio Gabriel Link: https://patch.msgid.link/20260527-asoc-mt8192-probe-cleanup-v1-2-1bb834d05b72@gmail.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/mediatek/mt8192/mt8192-afe-pcm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) --- a/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c +++ b/sound/soc/mediatek/mt8192/mt8192-afe-pcm.c @@ -2218,15 +2218,19 @@ static int mt8192_afe_pcm_dev_probe(stru /* enable clock for regcache get default value from hw */ afe_priv->pm_runtime_bypass_reg_ctl = true; - pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); + if (ret) { + afe_priv->pm_runtime_bypass_reg_ctl = false; + return dev_err_probe(dev, ret, "failed to resume device\n"); + } ret = regmap_reinit_cache(afe->regmap, &mt8192_afe_regmap_config); - if (ret) - return dev_err_probe(dev, ret, "regmap_reinit_cache fail\n"); - pm_runtime_put_sync(dev); afe_priv->pm_runtime_bypass_reg_ctl = false; + if (ret) + return dev_err_probe(dev, ret, "regmap_reinit_cache fail\n"); + regcache_cache_only(afe->regmap, true); regcache_mark_dirty(afe->regmap);