Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95C86405845; Tue, 21 Jul 2026 17:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654972; cv=none; b=DB7FVNSZblzXCfVm3VSLl/wUsvDgFLfS0h/d5isI3UfDbhcjMTPYekDCLyNlh6R9Zcdmrisi//DHDrqLn2BQWuwz1Y2sqcdX3n7+XabN0Z7pW7XMs5Bh4Uo5Of5zrv1zK6OGxGOfqQRztd3U/KftUQdeTtqgZV1aCs2A1XHYv90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654972; c=relaxed/simple; bh=S1koEnteLDLSVeQxdA3O6es5AGmJdgpkJcKc278mgc8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UGNDEeFiGUlmwMYhwKMag5jehXAXCnhUyoBzH9iVHO497qQaLrHO1jL21+GQQnSGxB4M9NsuNzDfHHWuNK5y5R3g+spa2pt8O1zjFn/U91x31CN+J2kOLJCXZzOsz4HjpQVNBEONtC/i8r5Pp6QF8MZfrBeTD1MYhQ+0oV2alyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JpRTB3lO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JpRTB3lO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7BB81F000E9; Tue, 21 Jul 2026 17:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784654971; bh=9gsfJo6mxVSYDcEFjgPEKm4kUcGaG/fShhLT5N/GV9w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JpRTB3lObRE82f/8aMghTvhAsOKD6Xlt3tQG3sJ1C1s3xZkVS+V1p66j1QGml+A5a AvGVdiebefbApmDaM77RGWWNC3aDABkPAA+NuLcrdZM9j4QSWSy8mOLlTDG6fK9CT6 4LVXRNFmivitGH6SVUfJa5YqZQXhfD3PCk9/DadE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Linus Walleij , Andreas Kemnade , Bartosz Golaszewski Subject: [PATCH 7.1 1908/2077] gpios: palmas: add .get_direction() op Date: Tue, 21 Jul 2026 17:26:21 +0200 Message-ID: <20260721152637.724285444@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andreas Kemnade commit db4a79713ed8e252d5e4edf6eaaa80948b6855a2 upstream. Accessing debug/gpio is quite noisy without a get_direction() implementation. To calm that down add an implementation. Fixes: 3d50a2785271 ("gpio: palmas: Add support for Palmas GPIO") Cc: stable@vger.kernel.org Reviewed-by: Linus Walleij Signed-off-by: Andreas Kemnade Link: https://patch.msgid.link/20260704-palmas-getdirection-v2-1-2fd85fee3832@kemnade.info Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpio-palmas.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) --- a/drivers/gpio/gpio-palmas.c +++ b/drivers/gpio/gpio-palmas.c @@ -116,6 +116,24 @@ static int palmas_gpio_input(struct gpio return ret; } +static int palmas_gpio_get_direction(struct gpio_chip *gc, unsigned int offset) +{ + struct palmas_gpio *pg = gpiochip_get_data(gc); + struct palmas *palmas = pg->palmas; + unsigned int val; + unsigned int reg; + int ret; + int gpio16 = (offset/8); + + offset %= 8; + reg = (gpio16) ? PALMAS_GPIO_DATA_DIR2 : PALMAS_GPIO_DATA_DIR; + ret = palmas_read(palmas, PALMAS_GPIO_BASE, reg, &val); + if (ret) + return ret; + + return (val & BIT(offset)) ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; +} + static int palmas_gpio_to_irq(struct gpio_chip *gc, unsigned offset) { struct palmas_gpio *pg = gpiochip_get_data(gc); @@ -165,6 +183,7 @@ static int palmas_gpio_probe(struct plat palmas_gpio->gpio_chip.can_sleep = true; palmas_gpio->gpio_chip.direction_input = palmas_gpio_input; palmas_gpio->gpio_chip.direction_output = palmas_gpio_output; + palmas_gpio->gpio_chip.get_direction = palmas_gpio_get_direction; palmas_gpio->gpio_chip.to_irq = palmas_gpio_to_irq; palmas_gpio->gpio_chip.set = palmas_gpio_set; palmas_gpio->gpio_chip.get = palmas_gpio_get;