Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E8D1449B2B; Tue, 21 Jul 2026 17:31:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784655088; cv=none; b=ZaZh4aS1Z2MbZfZBRB0/ueVnapXcXAKPz7e/vdVHTu/tj3TXltgAG1EgZtH05v8+SfFrOuPgSUjUl3GuwanS26kKc8ekEp+XQCkPhkxX0IUbC7NsUWZngd85CwMoGEN5ZBdlvqEtuOxACA6SWDwvuOY5phgyiQEjfPPs47LO7hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784655088; c=relaxed/simple; bh=nXwDKqnVMVnBa+8m08L+bOn5KweM6ZGFNtLDbTDFKrE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IfrABLAuFeTzsBFfsSTL7i3iVSYbhsGyRV26rvhesHESb0U/BvfEAcv8FkE1eLrQLtSOiVC/J8Ie/RftFAozNOAfe6Tu6Z30bCQmA61eewspDWAbb6FSGhdSKXucsksGWXeQe7TJNsGaT1lswOLxZyRolVDFuYg0StBUS3T4jiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fkoyX5xV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fkoyX5xV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D08C21F000E9; Tue, 21 Jul 2026 17:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784655087; bh=wGMaP+8uMGZeeva9vyK+wT8mp8uzngbsnH1JcLrAp/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fkoyX5xVg8gYigoFZOFi9ICFcKDH6kFEM5yv/qPPlalUVFJQSaFxj26cAdd8zodKQ DOImoK+bwi6tNxO0/hWfZG3vdt3MBs+I9ms+krrY/H4J8r2TvIndcdntWGStsGsAPd r5uB7K74n3eEPR9TFzcru5ejJ0n9doFzLgAGMw4M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Haoxiang Li , Pavan Chebbi , Breno Leitao , Paolo Abeni Subject: [PATCH 7.1 1952/2077] fsl/fman: Free init resources on KeyGen failure in fman_init() Date: Tue, 21 Jul 2026 17:27:05 +0200 Message-ID: <20260721152638.751743084@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li commit d288efa2b94abc2e45a061fceb156b4f4e5b37be upstream. fman_muram_alloc() allocates initialization resources before initializing the KeyGen block. If keygen_init() fails, the function returns -EINVAL directly and leaves those resources allocated. Free the initialization resources before returning from the KeyGen failure path. Fixes: 7472f4f281d0 ("fsl/fman: enable FMan Keygen") Cc: stable@kernel.org Signed-off-by: Haoxiang Li Reviewed-by: Pavan Chebbi Reviewed-by: Breno Leitao Link: https://patch.msgid.link/20260625004834.3394389-1-haoxiang_li2024@163.com Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/fman/fman.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/freescale/fman/fman.c +++ b/drivers/net/ethernet/freescale/fman/fman.c @@ -1995,8 +1995,10 @@ static int fman_init(struct fman *fman) /* Init KeyGen */ fman->keygen = keygen_init(fman->kg_regs); - if (!fman->keygen) + if (!fman->keygen) { + free_init_resources(fman); return -EINVAL; + } err = enable(fman, cfg); if (err != 0)