Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D90811CAA6D; Tue, 21 Jul 2026 17:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784655130; cv=none; b=AecqJzATHsonph/O9wK/DSBqT7ulb4nXL+l0Jwpr6LIQ+omxwQKoKb17duZPXmcampDY/jQhnhf3Br5iHQI9BZFL8DRmlsNhbUTm3wmNMh1lYm3eLngbW9Yw9eXePBqtKFZ+SXrPyAYh7szZUDGUoVT9Kw6S1CWL16zKpRXSPHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784655130; c=relaxed/simple; bh=fm0mbcH21kaYiqBnw0CEYwgK3tnb84Iq6IbVZxzp2O8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YUBPBpXJe5UR/USogLdNirp/KqSD2WYEoYnyO8Ss4eaxnM+QezzwNQ7IRXGLOL6OmlkMZ9CV2x1MOlui6sEGWtFzRc/Npa9A+WlEBifuQncIuLhM0jSl7czc7o9/XnMG516w+EwNgsf1tkBTT2/Al4WgJ/snI19w6+vtzSIb1vI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ghHVEGUL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ghHVEGUL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C9BD1F000E9; Tue, 21 Jul 2026 17:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784655129; bh=kHkZg+J5L0WAjAI6tSsXAAO3MNMQBfOrjrdoYVsE1EA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ghHVEGULTJNiNSe4NKdiA1e0NzLCjekcQqLzPHxM2THHufDuSiLSwYMmrAcjM+3ih AN7FTiHW4FGXHzd38+hu8JaYKc7Tv+oEkU16EHJvxouAzcVVxp7317hfHreHLrojxs RzIIPo4a2pmujncDmCObyhUTJH30eGg9ydke2UIQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HyeongJun An , Guenter Roeck Subject: [PATCH 7.1 1966/2077] hwmon: (asus_atk0110) Check package count before accessing element Date: Tue, 21 Jul 2026 17:27:19 +0200 Message-ID: <20260721152639.077376946@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: HyeongJun An commit e2735b39f044bad7bf2017aef248935525bc0b97 upstream. atk_ec_present() walks the management group package returned by the GGRP ACPI method and, for each sub-package, reads its first element: id = &obj->package.elements[0]; if (id->type != ACPI_TYPE_INTEGER) without checking that the sub-package is non-empty. ACPICA allocates the element array with exactly package.count entries, so for a sub-package with a zero count this reads past the allocation. The sibling function atk_debugfs_ggrp_open() performs the same access but skips empty packages with a package.count check first. Add the same check to atk_ec_present() so a malformed firmware package cannot trigger an out-of-bounds read. Fixes: 9e6eba610c2e ("hwmon: (asus_atk0110) Enable the EC") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: HyeongJun An Link: https://lore.kernel.org/r/20260619122746.721981-1-sammiee5311@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/asus_atk0110.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/hwmon/asus_atk0110.c +++ b/drivers/hwmon/asus_atk0110.c @@ -1037,6 +1037,9 @@ static int atk_ec_present(struct atk_dat if (obj->type != ACPI_TYPE_PACKAGE) continue; + if (!obj->package.count) + continue; + id = &obj->package.elements[0]; if (id->type != ACPI_TYPE_INTEGER) continue;