Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3161AC53200 for ; Fri, 24 Jul 2026 16:10:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnITV-0007fp-PB; Fri, 24 Jul 2026 12:10:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnITA-0007XF-6C for qemu-devel@nongnu.org; Fri, 24 Jul 2026 12:09:53 -0400 Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wnIT8-0007li-Ng for qemu-devel@nongnu.org; Fri, 24 Jul 2026 12:09:51 -0400 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-45133d2974fso357948fac.1 for ; Fri, 24 Jul 2026 09:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784909389; x=1785514189; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OprY1AZR7pEP7mUfERpFrHmAnUlh+1+Ut0hJzuaj/tE=; b=UxevhewfUf4YggYwDsUbQ1hoifXdsvGn+LA70fHGp9U2MPz1dvaNwM8qcF0aBc4jJq QeRU2c4TkEQZNSf4o/nRc84j2zqQrjqZJQo0zUqG8FLzqkG4vEvh2u0ZSPgv9CUuoVz/ eSCx4lCs2/cD8HeBqGfcHXW6Ca8LRaFkNlQ4JwVNybitO0KUi1EzZZ0V8pxGgF5iogP0 OEOdZdFwEoTVlRw18JUdFAYw1IEubYHqK9Rh8PuMP3+pBIrM/HqT4X0jTKBNv+VlcNxR bokUIW6VuzZEfXq4BsZs1nSgzrlCjhS0WOc93FlyVekGuw4quZxmA+4vEslhdfJH179y dw/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784909389; x=1785514189; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OprY1AZR7pEP7mUfERpFrHmAnUlh+1+Ut0hJzuaj/tE=; b=YAjuAq5lloo0Z94UE0ZZkwIN7lggEq1cBdA/vZw8xFae4JIrR3TcPWPXTqnjscW+vB VDKLM7zcHzwkNSx4CrhsdNrWEqIF8nWl356yqyxtG9uNSd700NwkDRXLo1sGZUzprjTB cbLyiU4AJnHRq9QL1BjuIYqjm+g71Y4ONBestHcX+13kBBwVGbjw3IUDc92UD6r3k6jI ngeaeXl98/vV1Bisvcs5kUcQqhyZVrKg16isG1ZGBUmec/OU730hs2dnzzlukgTljmL7 Tah13lnZ1bRNGNbsRNLX4xF1hLNdpnx6MNI+nFFy8N+Lh7qzp+lGJj/AvA1hJiETwXn4 CmYQ== X-Gm-Message-State: AOJu0YxaKgh1wiCr3U7GCtwvuBPIDQtZmU4J66EnJoTo3xsY1bRMvsqr xgtpjT0V2wCKsYwBoXMqh3WB2Z5zO36Eq0I+j5WRrsDmSwAbmn5mlumR3EHhgPdE X-Gm-Gg: AR+sD119Y96EajxGSnbp/iDaLL4H6QMa9mEiOIqvHJ+uGIXy4ayPJ6udWse3TlNqJoT EESc2oRm9I7RSlABz87pvTB3kfeCCQM+L9i1Sdo3tfgIbvftUjoGceAEKi6IrAegnhUvMETWmA4 Mcy2nTWyZ4gFWMPoaS3EjF9HtXAYDDhE96JF1C2wt2BEYcnFHjZbsnsgZgPmVPsFmjJ4L9XVjpa ztTy1g3Q2ejoJxByIwkKM0delKWGMVNDwuAZysYy9ERTbJnvQpumT9L/YSiONYDfCviAY5zQAaD P6SZFqlgjBsfxJN5kYlOA+ppd2los23bBcl9u2weZNJ4cMXAOoIURqyR0GLj1ltCUPN+tRJ8kCo ryXr9jx9UZ6VteiXnAnjSKKGQfQGfS0oeJ6denx4BQz7NWJW9c8dZzPxwcVO+Ql5QMtY08gJQiS qEny1lXCb7Fj4Wphxo+ibeXWwTUUgAIHBydg== X-Received: by 2002:a05:6871:299:b0:448:604c:bc63 with SMTP id 586e51a60fabf-457a0cca1famr5405611fac.18.1784909389439; Fri, 24 Jul 2026 09:09:49 -0700 (PDT) Received: from HPE-2MQ6131DV6.home.local ([23.124.244.239]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-457ab7405a9sm4542753fac.18.2026.07.24.09.09.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 09:09:48 -0700 (PDT) From: Simon Xu To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Simon Xu Subject: [PATCH 2/2] hw/misc/mps2-scc.c: fix scc_partno field width Date: Fri, 24 Jul 2026 11:09:43 -0500 Message-ID: <20260724160943.52509-3-simonxhy0404@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260724160943.52509-1-simonxhy0404@gmail.com> References: <20260724160943.52509-1-simonxhy0404@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:4860:4864:20::35; envelope-from=simonxhy0404@gmail.com; helo=mail-oa1-x35.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Increase the extract32 length from 8 to 12. The Primary part number is defined as bits[15:4] by the "SSE-310 with M85 and U55 FPGA" documentation. For example for the mps3-an547, 0x547 is 12 bits but we only return 8 bits right now. Signed-off-by: Simon Xu --- hw/misc/mps2-scc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/mps2-scc.c b/hw/misc/mps2-scc.c index 1ecb2879e3..554b504c72 100644 --- a/hw/misc/mps2-scc.c +++ b/hw/misc/mps2-scc.c @@ -57,7 +57,7 @@ REG32(ID, 0xFFC) static int scc_partno(MPS2SCC *s) { /* Return the partno field of the SCC_ID (0x524, 0x511, etc) */ - return extract32(s->id, 4, 8); + return extract32(s->id, 4, 12); } /* Is CFG_REG2 present? */ -- 2.53.0