Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2CB52BE644 for ; Sun, 26 Jul 2026 13:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785072122; cv=none; b=na8MOHgeaOgg0tfKLx7k9uYt7mjvwz+qBJGM6/FJJe/PhPH1aDW44EWvElloS7+E/K7aIWQzKhzDq7kgQF7E2m2+/ENNdLMJSsTDD5RA6sH79kJjEvHL+Xptiz3Bx/8qWVHV+7tDD3eo44307SXaQMLc5esNotuLi7BVDndWzY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785072122; c=relaxed/simple; bh=JQOQ6yS4xsXFdeuonQs8PhBaWqcfj0FCzAiN2cBAyrk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q2vlHGnDC2c572FyZJiUfHzGsg7VvTwAcZ0h4Z4+mSZVxn/F7899fOkakg3r0W5ahJ/EOLwgXYStvusFkffqdaY/uG6sP6JBco+KwFHbblvYm0v0BHdOYXXheCKvGyQuQwgOw5CmrILfIiOU4/1I5sZZ01SdlhTZYfEB78tDxOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cx1UdHJE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cx1UdHJE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D469B1F00A3A; Sun, 26 Jul 2026 13:21:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785072118; bh=QpMj4LBu78KFGGAwLfBm6hP1u97bvlT0mRsqGiBnnI8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cx1UdHJE71WNVVeNOAVhEOM5CsqyStJKxr209HxbLaF4BYUBZq1DL1WkMHfBZlTEG 3ym7QyEfrKvNAGdBV7Wkw38z3ch5WgtO9Q8HqY5YXNOsIT/A7uOfFXpMgJzahf5tD/ xpFji9wSxKuEZ1aFCQu9hKAZx0MGjB+4WWkTQZtYlxDXLEUS+owEdEN+sOS87wZTJk BLOJVfNYGp8YNHpJJaIhAiP/bS3zGI2c1OaHZEKozADwGuMRGjrpjQ13xBWAXnt7SH QZ6AcqBqFzZv5rTrj1MoYlCnn9AVc7gg8S85S4CijO7WsQtsK+KGeuAvgJaQA8ZlUK ak65BgV3zgpew== From: Sasha Levin To: stable@vger.kernel.org Cc: Koichiro Den , Frank Li , Vinod Koul , Sasha Levin Subject: [PATCH 6.12.y 3/3] dmaengine: dw-edma-pcie: Reject devices without driver data Date: Sun, 26 Jul 2026 09:21:54 -0400 Message-ID: <20260726132154.327006-3-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260726132154.327006-1-sashal@kernel.org> References: <2026072011-gratified-dealmaker-699d@gregkh> <20260726132154.327006-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Koichiro Den [ Upstream commit 11d7cfe0c119691b2dafbb699bbca90258c678aa ] dw_edma_pcie_probe() treats the PCI device ID driver_data as the template for the controller layout and copies it unconditionally. A device bound dynamically via sysfs can match the driver without that data, which leads to a NULL pointer dereference. Reject such matches before enabling the device. Fixes: 41aaff2a2ac0 ("dmaengine: Add Synopsys eDMA IP PCIe glue-logic") Cc: stable@vger.kernel.org Signed-off-by: Koichiro Den Reviewed-by: Frank Li Link: https://patch.msgid.link/20260521142153.2957432-3-den@valinux.co.jp Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/dw-edma/dw-edma-pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index ae1bbca7da93fe..b3f2653862a8a5 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -165,6 +165,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, int err, nr_irqs; int i, mask; + if (!pdata) + return -ENODEV; + struct dw_edma_pcie_data *vsec_data __free(kfree) = kmalloc(sizeof(*vsec_data), GFP_KERNEL); if (!vsec_data) -- 2.53.0