Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BA122EF67A for ; Tue, 28 Jul 2026 02:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785206778; cv=none; b=p9fyacQPROymwFfI+ng2rMisUXU+9U8AEE2Hes42Ge30Jru0rpSBMBa1tmRgvX/9Tpk066E305wVn/USDAwgs4nO2iEZczRVALJF8b0QnROXksh3UGgaiCmCMZXcat7r5eVSRkhxEXVTejhh3d8AFY4d5r4f3FiPTnZodHEoBLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785206778; c=relaxed/simple; bh=hSzynjrZeTuVdayodtegulkf1njfTtCLPkKfnJgfx5w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FEhJ4i4JZG0BYdQl6+bIS3uDgpPXgx4npW+lbY54MOfw71vJte65yYXNPvQ/UlDKESHpFt+5gwvhZsvSEkb0TVy/ThJNBhzoQB3SMA0RaDlW8nF1dxFnHQ7QM5IZxmvpnCGk0GDZIMhKNEpRO3Jj46OWwjdnfC/XC8PX6FsMN4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cCOf0m38; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cCOf0m38" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBFA81F00A3D; Tue, 28 Jul 2026 02:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785206776; bh=JYx9s8ZRPoTVAhhDGkWcYmxA28HeuRmoIo337jow044=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cCOf0m38fo/eun7uDzS75sBxBb6w8nA8YK/PiBSD5mFK7DZb3mdg4kUIWk82ti67d V4m/z1s0ev4imcEBaa/Bl9TMw4T0Q3+VgNtryiS27uHAkalmcy0uI8uzJOlWmtyZW4 Th98aI+kwa+W1bgHtFUrPlVgAMJ7/SqH1eZ56VAqlnC2+SZ8RTQFH4Z2tFufwH28nI 5vy68POIW7l9tXiLV7gmkPeE4POnqcxHgOlvwpK3MNi4kJAccIh+F2N4/CSDvj5z1v UVf+4FNn4eaIdrED8ov2RJKcLu0eHPRRvrb/4vUkLNk5/sOSSrpQbu58exft6JSvbF 6UOdUnyXc83eQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Thomas Gleixner , syzbot+000c800a02097aaa10ed@syzkaller.appspotmail.com, Jann Horn , Sebastian Andrzej Siewior , Al Viro , Sasha Levin Subject: [PATCH 6.12.y] locking/rt: Fix the incorrect RCU protection in rt_spin_unlock() Date: Mon, 27 Jul 2026 22:46:07 -0400 Message-ID: <20260728024607.3052461-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026072058-enjoyable-enamel-6b91@gregkh> References: <2026072058-enjoyable-enamel-6b91@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thomas Gleixner [ Upstream commit 89038cc87d80c77e7aa6f42a64b2573b74af339f ] rt_spin_unlock() releases the RCU protection before unlocking the lock. That opens the door for the following UAF scenario: T1 T2 spin_lock(&p->lock); rcu_read_lock(); invalidate(p); p = rcu_dereference(ptr); rcu_assign_pointer(ptr, NULL); if (!p) return; spin_unlock(&p->lock); spin_lock(&p->lock) lock(&lock->lock); rcu_read_lock(); kfree_rcu(p); rcu_read_unlock(); .... spin_unlock(&p->lock) rcu_read_unlock(); // Ends grace period rcu_do_batch() kfree(p); UAF -> rt_mutex_cmpxchg_release(&lock->lock...) Regular spinlocks keep preemption disabled accross the unlock operation, which provides full RCU protection, but the RT substitution fails to resemble that. Same applies for the rwlock substitution. Move the rcu_read_unlock() invocation past the unlock operations to match the non-RT semantics. This makes it asymmetric vs. rt_xxx_lock(), but that's harmless as the caller needs to hold RCU read lock across the lock operation. The migrate_enable() call stays before the unlock operation because there is no per CPU operation in the unlock path which would require migration to be kept disabled. Fixes: 0f383b6dc96e ("locking/spinlock: Provide RT variant") Reported-by: syzbot+000c800a02097aaa10ed@syzkaller.appspotmail.com Decoded-by: Jann Horn Signed-off-by: Thomas Gleixner Reviewed-by: Sebastian Andrzej Siewior Acked-by: Al Viro Cc: stable@vger.kernel.org Link: https://patch.msgid.link/87jyrud75z.ffs@fw13 Signed-off-by: Sasha Levin --- kernel/locking/spinlock_rt.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/kernel/locking/spinlock_rt.c b/kernel/locking/spinlock_rt.c index 014143934e0012..c78c52ed0b1e1f 100644 --- a/kernel/locking/spinlock_rt.c +++ b/kernel/locking/spinlock_rt.c @@ -79,10 +79,27 @@ void __sched rt_spin_unlock(spinlock_t *lock) { spin_release(&lock->dep_map, _RET_IP_); migrate_enable(); - rcu_read_unlock(); if (unlikely(!rt_mutex_cmpxchg_release(&lock->lock, current, NULL))) rt_mutex_slowunlock(&lock->lock); + + /* + * This must be last to prevent the following UAF: + * + * T1 T2 + * spin_lock(&p->lock); rcu_read_lock(); + * invalidate(p); p = rcu_dereference(ptr); + * rcu_assign_pointer(ptr, NULL); if (!p) return; + * spin_unlock(&p->lock); spin_lock(&p->lock); + * kfree_rcu(p); rcu_read_unlock(); + * .... + * spin_unlock(&p->lock) + * rcu_read_unlock(); // Ends grace period + * rcu_do_batch() + * kfree(p); + * UAF -> rt_mutex_cmpxchg_release(&p->lock.lock...) + */ + rcu_read_unlock(); } EXPORT_SYMBOL(rt_spin_unlock); @@ -262,17 +279,21 @@ void __sched rt_read_unlock(rwlock_t *rwlock) { rwlock_release(&rwlock->dep_map, _RET_IP_); migrate_enable(); - rcu_read_unlock(); rwbase_read_unlock(&rwlock->rwbase, TASK_RTLOCK_WAIT); + + /* This must be last. See comment in rt_spin_unlock() */ + rcu_read_unlock(); } EXPORT_SYMBOL(rt_read_unlock); void __sched rt_write_unlock(rwlock_t *rwlock) { rwlock_release(&rwlock->dep_map, _RET_IP_); - rcu_read_unlock(); migrate_enable(); rwbase_write_unlock(&rwlock->rwbase); + + /* This must be last. See comment in rt_spin_unlock() */ + rcu_read_unlock(); } EXPORT_SYMBOL(rt_write_unlock); -- 2.53.0