Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97CC048CD5F for ; Wed, 29 Jul 2026 13:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785331902; cv=none; b=IY+DZsgDgdXdmayO1W5vz+KvzaaRb4FNkHFCCWWVDzyTscHNgwgj1KxGLOJL7+8xIjjgeZFRwgfMZt6Z6RsbTga1zT74A4ndXgpXg6y6r0KGSGJNoIMUIfXrhjYurqv7SDbfVR4lD7IXHDHNSJv0tVfeVveqmD96hDGqCCQNSyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785331902; c=relaxed/simple; bh=FkmKBLnCQfOdv7ThtE9Hwx55exMYZvKq/w5p14+5uNs=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=NVo3KF+EBWqmZJzMc2e700b5/tAlUsYyenjL4qibtaatb7jDghwxIy530uO5mBs6v0G8EOX13o7EJL3WRfhmfWaAo9Rm+mfgg1wjuDPB/bi5zAWJ00CZ+lV7zqSDUo5rLjvUvgH9az7WqTxRbCSDiIraBvAwR1dNqD4sgMTlDu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RoNYNqIK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RoNYNqIK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A36B41F000E9; Wed, 29 Jul 2026 13:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785331896; bh=vjnVIBbHxKP5ePkDO8mtdJNGM3YqlD5rx5Oi7At7jfQ=; h=Subject:To:Cc:From:Date; b=RoNYNqIKlj5LTvZPsS20SEkKdj0PAqvB0H0txsSLU0U1yhrC5Zw7TMbXOnxQ85TIx /MXMP3U5vTl13CILeljHFyYe5YTRNFXepw1dYA9E2GtEoCMHVV7skCagj3+Z67mPsI +XoNu4PRMlnuNvPpESqw3N2WxghIgIkntPLtPH1A= Subject: FAILED: patch "[PATCH] serial: sc16is7xx: implement gpio get_direction() callback" failed to apply to 5.10-stable tree To: hvilleneuve@dimonoff.com,bartosz.golaszewski@oss.qualcomm.com,gregkh@linuxfoundation.org,stable@kernel.org Cc: From: Date: Wed, 29 Jul 2026 15:31:14 +0200 Message-ID: <2026072914-sandbar-very-7f7d@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x af071d9e07e57cfff239e8d09d2f3b05ebc9c667 # git commit -s git send-email --to '' --in-reply-to '2026072914-sandbar-very-7f7d@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From af071d9e07e57cfff239e8d09d2f3b05ebc9c667 Mon Sep 17 00:00:00 2001 From: Hugo Villeneuve Date: Thu, 16 Jul 2026 17:08:09 -0400 Subject: [PATCH] serial: sc16is7xx: implement gpio get_direction() callback It's strongly recommended for GPIO drivers to always implement the .get_direction() callback - even when the direction is tracked in software. The GPIO core emits a warning when the callback is missing and a user reads the direction of a line, e.g. via /sys/kernel/debug/gpio. Fixes: dfeae619d781 ("serial: sc16is7xx") Cc: stable Signed-off-by: Hugo Villeneuve Acked-by: Bartosz Golaszewski Link: https://patch.msgid.link/20260716210813.2582826-1-hugo@hugovil.com Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index daebd92f32c7..6c97953d593b 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1273,6 +1273,17 @@ static int sc16is7xx_gpio_set(struct gpio_chip *chip, unsigned int offset, return 0; } +static int sc16is7xx_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) +{ + struct sc16is7xx_port *s = gpiochip_get_data(chip); + struct uart_port *port = &s->p[0].port; + unsigned int val; + + val = sc16is7xx_port_read(port, SC16IS7XX_IODIR_REG); + + return val & BIT(offset) ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; +} + static int sc16is7xx_gpio_direction_input(struct gpio_chip *chip, unsigned offset) { @@ -1350,6 +1361,7 @@ static int sc16is7xx_setup_gpio_chip(struct sc16is7xx_port *s) s->gpio.parent = dev; s->gpio.label = dev_name(dev); s->gpio.init_valid_mask = sc16is7xx_gpio_init_valid_mask; + s->gpio.get_direction = sc16is7xx_gpio_get_direction; s->gpio.direction_input = sc16is7xx_gpio_direction_input; s->gpio.get = sc16is7xx_gpio_get; s->gpio.direction_output = sc16is7xx_gpio_direction_output;