Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3230C48B396 for ; Wed, 29 Jul 2026 13:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785331425; cv=none; b=KKI7FiZeGpru1XYEKbp3alw9YEPFatlG3QeFTmS3CU27vFXmdSObtMTzmtjFAFrOkOCQ29NwTnbtAEUUN3pExVXuxLg9Et1eGzBkK0HjG2HYJ6f9g1AhlQmSc049N45hXJMV3N9/R/fGjdZTptIPw9YkMWdq4bODxg3p66d7K7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785331425; c=relaxed/simple; bh=x0YKiYUHcxg73GPCPbJ0Nk2WAN929PBBTMVcCInl460=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=cLM0d702zx8T7wgdyH5mKGKyc0piX4huEOIOSvkj4cIjNqE4LnuPrGi3HqvkgoEt7MA2UaXGSJyjTt6gzQSuLxgoTevsvojwYQFWeghI8okKFyiIeEqhdQGCnFzQcDpmHsk0kbE0UK7VRw9BZO58TqHiH5QoGItRzF3Du3M75j8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UNxlCMnl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UNxlCMnl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D0051F000E9; Wed, 29 Jul 2026 13:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785331424; bh=V4iYOPKwB8+RXbQgmRD6t/tSJzJoytehA/FOiHGQp4g=; h=Subject:To:Cc:From:Date; b=UNxlCMnlctaMnzuGx0/v0HXuBaQ7p/j0iB8l6u2cgulxfKgzqt94Z/8+qu9uIYhCC 5KoQruhFElAYiD4iZAVrcp6bBhL0ZmVlc5En5I1mu9oVtZH9MBIEGWqKYri6yo7/CD STvIGXMK4ggOj3OFl9uJcpMAV4t+ceuIEvjv6bwc= Subject: FAILED: patch "[PATCH] ALSA: seq: close a re-opened queue timer in the destructor" failed to apply to 5.15-stable tree To: norbert@doyensec.com,tiwai@suse.de Cc: From: Date: Wed, 29 Jul 2026 15:18:45 +0200 Message-ID: <2026072945-oppose-vending-195a@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.15-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y git checkout FETCH_HEAD git cherry-pick -x 2c4dc0ed50b05cd847a4b34b8cebf0775f19aeb9 # git commit -s git send-email --to '' --in-reply-to '2026072945-oppose-vending-195a@gregkh' --subject-prefix 'PATCH 5.15.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 2c4dc0ed50b05cd847a4b34b8cebf0775f19aeb9 Mon Sep 17 00:00:00 2001 From: Norbert Szetei Date: Tue, 14 Jul 2026 10:29:23 +0200 Subject: [PATCH] ALSA: seq: close a re-opened queue timer in the destructor queue_delete() closes the queue timer, then frees it. snd_seq_timer_close() clears q->timer->timeri. snd_use_lock_sync() then drains borrowers, and snd_seq_timer_delete() frees q->timer. A borrower can re-open the timer inside that window. A SET_QUEUE_CLIENT that took a queueptr() use_lock reference before the queue was unlinked runs snd_seq_timer_open() after the close. Open refuses re-open only while timeri is set, and the close just cleared it, so it re-opens timeri. snd_seq_timer_delete() does not close that instance. Its snd_seq_timer_stop() is a no-op, because running was cleared first. So it frees q->timer with the instance still live. The queue is freed next. The instance stays on the global timer with callback_data pointing at the freed queue. A non-owner START on the unlocked queue arms it. The next tick derefs the freed queue in snd_seq_timer_interrupt(). Reachable by an unprivileged user with access to /dev/snd/seq. No CAP and no queue ownership required. Close any lingering instance in the destructor. There, ->timeri can no longer change: the queue is unlinked and all use_lock borrowers have drained, so no snd_seq_queue_use() can re-open it. Close it before clearing q->timer. snd_timer_close() waits for any in-flight snd_seq_timer_interrupt() to finish, and that callback still reads q->timer (via snd_seq_check_queue()), so q->timer must stay valid until it drains. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Norbert Szetei Link: https://patch.msgid.link/422FDB81-2A68-47C7-A22D-2D3301E2E86D@doyensec.com Signed-off-by: Takashi Iwai diff --git a/sound/core/seq/seq_timer.c b/sound/core/seq/seq_timer.c index 4cd7211ccf48..419288eec4bb 100644 --- a/sound/core/seq/seq_timer.c +++ b/sound/core/seq/seq_timer.c @@ -61,12 +61,23 @@ struct snd_seq_timer *snd_seq_timer_new(void) void snd_seq_timer_delete(struct snd_seq_timer **tmr) { struct snd_seq_timer *t = *tmr; - *tmr = NULL; + struct snd_timer_instance *ti; if (t == NULL) { pr_debug("ALSA: seq: snd_seq_timer_delete() called with NULL timer\n"); return; } + + scoped_guard(spinlock_irq, &t->lock) { + ti = t->timeri; + t->timeri = NULL; + } + if (ti) { + snd_timer_close(ti); + snd_timer_instance_free(ti); + } + + *tmr = NULL; t->running = 0; /* reset time */