Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 751DBC54FD2 for ; Thu, 30 Jul 2026 03:07:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wpH5s-0001mP-3s; Wed, 29 Jul 2026 23:06:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wpH5n-0001jT-D2 for qemu-devel@nongnu.org; Wed, 29 Jul 2026 23:05:56 -0400 Received: from rev.ng ([94.130.142.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wpH5l-0002qd-Os for qemu-devel@nongnu.org; Wed, 29 Jul 2026 23:05:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=41NJDuCDVPFzF4xI3SnhPELSy7zvSxiIHZf5nS+T8A0=; b=Lzj7i3AOPgLhXtn j409lPd6n4tYIVRefjfAVUTmHLRCuptbNELaB7awuk/jo2ZmmOCxUJor7p4neIIlJ7Coiu2ehi1YD oQRLFSsjDp2BMku5a4RgN8qTeukoFKEQ/TN/NJbm+PRp55YlKmDiCAPaP0TqmMl/fVjFk8JcA6rDr Ag=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, brian.cain@oss.qualcomm.com, pierrick.bouvier@oss.qualcomm.com, philmd@mailo.com, Anton Johansson Subject: [PATCH v2 02/50] accel/tcg: Add getpc helper Date: Thu, 30 Jul 2026 05:09:36 +0200 Message-ID: <20260730031025.12926-3-anjo@rev.ng> In-Reply-To: <20260730031025.12926-1-anjo@rev.ng> References: <20260730031025.12926-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=94.130.142.21; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via qemu development Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Introduces a helper function to return the current pc (returnaddress of the helper), this allows helper-to-tcg to correctly translate nested helper functions that checks for faulting memory operations. This is useful as an optimization where a helper functions has a commonly taken fast path that doesn't fault e.g. void HELPER(outer)(...) { ... // non faulting operations if (some_uncommon_condition) { helper_inner(..., GETPC()) } } the outer helper along with the condition can then be emitted as TCG, and helper_inner() will be emitted as a gen_helper_inner(, ra), where ra is the result of gen_helper_getpc(). NOTE: This is not ideal since we're introducing extra helper calls, and the solution doesn't deal with the "inner" function not being a helper. A better solution and what we'll probably do in the next version of the patchset is to instead emit a helper definition for the "inner" function that uses GETPC(). Signed-off-by: Anton Johansson --- accel/tcg/tcg-runtime.c | 5 +++++ accel/tcg/tcg-runtime.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runtime.c index d42c00736b..87b9530a50 100644 --- a/accel/tcg/tcg-runtime.c +++ b/accel/tcg/tcg-runtime.c @@ -162,3 +162,8 @@ void HELPER(exit_atomic)(CPUArchState *env) { cpu_loop_exit_atomic(env_cpu(env), GETPC()); } + +uint64_t HELPER(getpc)(void) +{ + return GETPC(); +} diff --git a/accel/tcg/tcg-runtime.h b/accel/tcg/tcg-runtime.h index 197d658b40..e25712d1fc 100644 --- a/accel/tcg/tcg-runtime.h +++ b/accel/tcg/tcg-runtime.h @@ -30,6 +30,8 @@ DEF_HELPER_FLAGS_1(lookup_tb_ptr, TCG_CALL_NO_WG_SE, cptr, env) DEF_HELPER_FLAGS_1(exit_atomic, TCG_CALL_NO_WG, noreturn, env) +DEF_HELPER_FLAGS_0(getpc, TCG_CALL_NO_RWG_SE, i64) + #ifndef IN_HELPER_PROTO /* * Pass calls to memset directly to libc, without a thunk in qemu. -- 2.52.0