Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7C3137883C; Thu, 30 Jul 2026 14:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422767; cv=none; b=hPG/XEYUsGn+22tjtid1wJpGfGHFTowPzws6+/o2Ml1MMxr9NMiL9qedN2D1XqCXFCykOsrHELWj9W6LJhfjN425Ra2GFYrUzhphKV1fwKjbq0UwNXZlA/be0Kc6Irkl4ATY7B+/9Hln9AuhHg/dVtbNjlfKn5fu2Sj8C0f4kaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422767; c=relaxed/simple; bh=frgPghkbV264b9hg01edNAgTIrt5ihcfRJeo8Nnslhw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D4ylcd4vaxktx9KQl9i4g0Me8xifahnvw8kNvzWkz/qjvwkoatFPBRuo7mIIfHziYC4zidR15oFZ7tRDxPYwki3gb3O3Z5gboOlbhU3nT2GGRwUcY4vIXKYtSTiU8KkUe03VrCI8I0PFpPoaiiTZ9euKVSzIrPmdYXIi8S1xYB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SvI1WrLF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SvI1WrLF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B31C31F00A3A; Thu, 30 Jul 2026 14:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785422766; bh=KX3ElT5MRfQHQsaa+nQVW4nfHJ4TVOnT7tGQeAzHoGo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SvI1WrLFvql3McTE0ASiL+Mg2kgba59BPtqPV41pJggBerG6d9pPE26F65HG+fMKF gRRenjD3n5Oc7Q27a1o9X2u1eiXbl0fGoaQXJnpGtED228iib88tJBtDQs6inHbXpq bHesA9pFz8vPyBCYnB34/PFQIzko+Bi/9R4RunDc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Devin Wittmayer , Felix Fietkau Subject: [PATCH 7.1 547/744] wifi: mt76: mt7615: drop TXRX_NOTIFY on non-mmio buses Date: Thu, 30 Jul 2026 16:13:40 +0200 Message-ID: <20260730141455.902854243@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141444.267951807@linuxfoundation.org> References: <20260730141444.267951807@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Devin Wittmayer commit 39afc46c0243d10b7795e6e6cf4ae91f41732120 upstream. PKT_TYPE_TXRX_NOTIFY is an mmio-only event, but mt7615_rx_check() and mt7615_queue_rx_skb() dispatch it to mt7615_mac_tx_free() on every bus. mt7615_mac_tx_free() cleans the DMA tx queues with mt76_queue_tx_cleanup(), which calls queue_ops->tx_cleanup(). Only the mmio queue ops implement that callback; on the mt7663 USB and SDIO buses it is NULL, so a TXRX_NOTIFY there calls a NULL pointer in the RX worker. Same defect as the mt7921 and mt7925 patches in this series. Drop the event on non-mmio buses via mt76_is_mmio(), as in commit 5683e1488aa9 ("wifi: mt76: connac: do not check WED status for non-mmio devices"). Fixes: eb99cc95c3b6 ("mt76: mt7615: introduce mt7663u support") Cc: stable@vger.kernel.org Signed-off-by: Devin Wittmayer Link: https://patch.msgid.link/20260627191336.20223-4-lucid_duck@justthetip.ca Signed-off-by: Felix Fietkau Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c @@ -1601,6 +1601,8 @@ bool mt7615_rx_check(struct mt76_dev *md switch (type) { case PKT_TYPE_TXRX_NOTIFY: + if (!mt76_is_mmio(mdev)) + return false; mt7615_mac_tx_free(dev, data, len); return false; case PKT_TYPE_TXS: @@ -1634,6 +1636,10 @@ void mt7615_queue_rx_skb(struct mt76_dev dev_kfree_skb(skb); break; case PKT_TYPE_TXRX_NOTIFY: + if (!mt76_is_mmio(mdev)) { + dev_kfree_skb(skb); + break; + } mt7615_mac_tx_free(dev, skb->data, skb->len); dev_kfree_skb(skb); break;