Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 212B6C55162 for ; Thu, 30 Jul 2026 16:09:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1378126.1623734 (Exim 4.92) (envelope-from ) id 1wpTJf-00069V-Q3; Thu, 30 Jul 2026 16:09:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1378126.1623734; Thu, 30 Jul 2026 16:09:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpTJf-00069O-MH; Thu, 30 Jul 2026 16:09:03 +0000 Received: by outflank-mailman (input) for mailman id 1378126; Thu, 30 Jul 2026 16:09:02 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wpTJe-00069I-CC for xen-devel@lists.xenproject.org; Thu, 30 Jul 2026 16:09:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wpTJd-0040M6-Lb for xen-devel@lists.xenproject.org; Thu, 30 Jul 2026 18:09:01 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a6b7708-e002-0a2a0a5209dd-0a2a4508bcdc-28 for ; Thu, 30 Jul 2026 18:09:01 +0200 Received: from [170.10.133.124] (helo=us-smtp-delivery-124.mimecast.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a6b771c-f659-0a2a45080019-aa0a857c898d-3 for ; Thu, 30 Jul 2026 18:09:01 +0200 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-0ZkvAFqSNH61vdvzDvY8hQ-1; Thu, 30 Jul 2026 12:08:56 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5DD001956080; Thu, 30 Jul 2026 16:08:53 +0000 (UTC) Received: from localhost (unknown [10.2.16.178]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 180BC30002E9; Thu, 30 Jul 2026 16:08:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mimecast20190719 header.d=redhat.com header.i="@redhat.com" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785427740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dsVpAu3QcfKYN17RfZrDdBsSoJyLiS2uxIUvPEK9QqU=; b=RjVccr9XwuXWJm7W1EP4DzedI3kf3HVtavRhvFFg8Pe2dJ5BTv+DWgt3T+5hIbn+N///KR bTZGLpvFj9BQ63ziWUs4++oLVvYvpBKOTY+UdzptOlTDgf80PdFeXCTXV+ytKftbMUDukp cMKMp1MeXcdqprn0vOgti+bX4KeB7Vc= X-MC-Unique: 0ZkvAFqSNH61vdvzDvY8hQ-1 X-Mimecast-MFC-AGG-ID: 0ZkvAFqSNH61vdvzDvY8hQ_1785427734 Date: Thu, 30 Jul 2026 12:08:49 -0400 From: Stefan Hajnoczi To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel@nongnu.org, Markus Armbruster , Peter Xu , Fabiano Rosas , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , John Snow , Vladimir Sementsov-Ogievskiy , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Fam Zheng , "Denis V. Lunev" , Christian Schoenebeck , Greg Kurz , "Michael S. Tsirkin" , Stefano Stabellini , Anthony PERARD , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Li Zhijian Subject: Re: [PATCH v2 6/8] block: add missing coroutine_fn annotations Message-ID: <20260730160849.GE1442692@fedora> References: <20260725-co-v2-0-d3552ddb3931@redhat.com> <20260725-co-v2-6-d3552ddb3931@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g6ePFKhtStmVnIyL" Content-Disposition: inline In-Reply-To: <20260725-co-v2-6-d3552ddb3931@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-purgate-ID: tlsNG-c1860d/1785427741-CDD4887B-C218D267/0/0 X-purgate-type: clean X-purgate-size: 1810 --g6ePFKhtStmVnIyL Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 25, 2026 at 01:48:37PM +0400, Marc-Andr=E9 Lureau wrote: > diff --git a/block/parallels.c b/block/parallels.c > index 7a90fb5220b9..6f96cc4e3045 100644 > --- a/block/parallels.c > +++ b/block/parallels.c > @@ -142,8 +142,9 @@ static uint32_t host_cluster_index(BDRVParallelsState= *s, int64_t off) > return off / s->cluster_size; > } > =20 > -static int64_t block_status(BDRVParallelsState *s, int64_t sector_num, > - int nb_sectors, int *pnum) > +static int64_t > +block_status(BDRVParallelsState *s, int64_t sector_num, > + int nb_sectors, int *pnum) > { > int64_t start_off =3D -2, prev_end_off =3D -2; > =20 This hunk looks like an accidental whitespace change? This function is not a coroutine function. > @@ -2126,7 +2128,8 @@ fail: > return ret; > } > =20 > -static void qcow2_reopen_commit(BDRVReopenState *state) > +static void > +qcow2_reopen_commit(BDRVReopenState *state) Whitespace change? Looks good aside from these whitespace changes. --g6ePFKhtStmVnIyL Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmprdxEACgkQnKSrs4Gr c8js3wgAnl0wOlSZnyScyNQg+Isn1t4N5afPjcm8ELinnU9anKcEJ1Sp1TkPsU9Q NwkfxO7GkL7vXUyVnUWSUh/oNRVYEXrgxNbxGMwG1mTdM7DA/jta+ap1efLTmNbr gK2SHM9ofCIdb1RltGF6b11gq607rjdF9dFy7vK9d3nmV6FHIqauvSiKUY5ksteR DUsNbxgdLc6hcNNGRzhyLYBsNazRginbl9zsKTLO5lp7ovVUIqzf/QNsIOyRU3xE wqZd8THPyZRBnkwbi/vTQjg9XBS5rm4BM/aIbYADrhLfqsX9jwHK/K5IOsK+OvuY Xw9Th5pdJNz/Ib8OiJpSzxo4PPKiLg== =ZGHJ -----END PGP SIGNATURE----- --g6ePFKhtStmVnIyL--