Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CC2DC55162 for ; Sun, 2 Aug 2026 17:04:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wqZbh-0006Tc-GV; Sun, 02 Aug 2026 13:04:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wqZbf-0006TF-NE for qemu-devel@nongnu.org; Sun, 02 Aug 2026 13:04:11 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wqZbe-0003R3-CI for qemu-devel@nongnu.org; Sun, 02 Aug 2026 13:04:11 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-8486ac3f347so3421219b3a.1 for ; Sun, 02 Aug 2026 10:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785690249; x=1786295049; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eTuO9kwkWQSNmODPQFPuOrz0Ciy9WrXZe0TuYOqtle0=; b=r8K66EWJ7vCo/Z6UDg1zE3mMbdL4JuYYB2lCBM5Tr3wNAZiKRfG2URdPjNBsvJ76wC 1di8K1VHQFcZ9SdaCGZ1AdTfybLMB2vm26M5zotM+W89eX6sLaYEBtt/xdNlCh8uy/0W F6N3pCSfLnwFMN4U2ketPVAK3oKfCn30yhLejibJGEajQuD/DgDoiPQPetsFP1EFuqdQ HytCdkmwv7wdbO7ukMisUXiFMlQU6/7dUhlxAlnhhF0tOFr8bDeKumP9/Vd5MtkY9Gtw JrpdrpStNnHFAeXg/gjz2/HDykzYvDsc/QmJPn5JiVYchbHSMx7l/SJZiDZ5y7PuRv+d JObA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785690249; x=1786295049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=eTuO9kwkWQSNmODPQFPuOrz0Ciy9WrXZe0TuYOqtle0=; b=hXWOlbt7xHzX1mQWTDYjwpgpZy5YpJxKAT/ENSVU+JwwquJIh/lg4wh8/U6VKMfXZW LZgWz9bASogIAEX4fCgLxD3xGWxXH5wK5CL2yFqJ6+VzAxHsGfI9Kab5wnNppMzHlKV+ 7mVXt9jqI++PBNoZw6QuUhDHveSV+s1pRD+935puCVYAMSi0CQ3FDcaP9EMp+A/gu9lr YyXo+ichhabLWh1tWFXtzgHOAkSGjoOTRwzEqY3tG1bFwN2dOqL0KvGz2ALt7U97Ib4A 4MWoR/7HFPu6VBJSEE+2MQk1wY9ATS/2eGJXF6bnz5u8aDPE+joXBItkI0j5A3vJLZf4 4HPw== X-Forwarded-Encrypted: i=1; AHgh+RqVR6zrcauT5rlIxKbO6IzCOHBl7tKbPXauIs3td7bU51s1Ee8yFMuEiOpGK5s2ur78kcNcr6inv5aI@nongnu.org X-Gm-Message-State: AOJu0YxnLHX+i0VjOgTvaIxIa6LTP+9iVq4osUNvxgbzqizi3SBzU/l3 41kCF2Wk1ej0cKBwsbL02MYqPDQHeivp5MjicX7A5mga48pd/0rBwDZb X-Gm-Gg: AR+sD114ZXl6D2bFnaf5qs96hTnzqYLUkxea6t0CoQESuHgB5U6SyJE49K0pJyHoOAN bfwP46JmhAZll+Rv8me4rs8KBlupNXWjfVumHVO2AWXPE7MZx7rYjz8qc/iH5tGc4mXR9y3tQ5J oYZnoi+GDNDCR3d5TWGFKt1Xe/9k5DI+pz+zSsAOBv0cpHp9NmI7L7t3XN4oWHf4Y8l2ry8Zt+D mdIAB8C8UyjxEygIoYBQzicb6ut3T5icAXXAJG00ni0xthzjSOPZVhut6ehp9A5okcBLuksvKWl 88pMQjzxoBxBgmF8KayAaNQf5UieyH4oE9xdU2gCMCMGHpFpa8yFln/o+hsKQLZgWhgMiEi5yP8 /edyX5wuPJU4Q9tPPRsvlGJLnCn7K/SqVy1WM7fA8HdQZUFbtLAJrC5vx6cy1LalBr7kQCeWVmd ErTAfXXKVt2ZCjxtRJspTzEefLFHNW6MUgf3QdVtGuPy8lnJIgjscj8Xxwc6eaQw== X-Received: by 2002:a05:6a20:2451:b0:3c3:80bc:1540 with SMTP id adf61e73a8af0-3c91a711b5cmr8040174637.3.1785690248820; Sun, 02 Aug 2026 10:04:08 -0700 (PDT) Received: from phi.nguyendp ([116.86.160.247]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab132cc4sm22982126c88.2.2026.08.02.10.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 10:04:08 -0700 (PDT) From: Nguyen Dinh Phi To: pbonzini@redhat.com, qemu-devel@nongnu.org Cc: qemu-rust@nongnu.org, Nguyen Dinh Phi Subject: [PATCH 1/2] rust/bits: Align SubAssign behavior with Sub Date: Mon, 3 Aug 2026 01:03:44 +0800 Message-ID: <20260802170346.3493821-2-phind.uet@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260802170346.3493821-1-phind.uet@gmail.com> References: <20260802170346.3493821-1-phind.uet@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=phind.uet@gmail.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Update SubAssign to perform a bit-clear operation instead of arithmetic subtraction, matching the behavior of Sub. Signed-off-by: Nguyen Dinh Phi --- rust/bits/src/lib.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/rust/bits/src/lib.rs b/rust/bits/src/lib.rs index d1141f7c88..60b63f969d 100644 --- a/rust/bits/src/lib.rs +++ b/rust/bits/src/lib.rs @@ -320,7 +320,7 @@ fn sub(self, rhs: $struct_name) -> Self::Output { impl ::std::ops::SubAssign<$struct_name> for $struct_name { fn sub_assign(&mut self, rhs: $struct_name) { - self.0 = self.0 - rhs.0 + self.0 &= !rhs.0 } } @@ -443,4 +443,11 @@ pub fn test_xor() { InterruptMask::OE | InterruptMask::PE | InterruptMask::FE ); } + + #[test] + pub fn test_sub_assign() { + let mut op1 = InterruptMask::E; + op1 -= InterruptMask::RI; + assert_eq!(op1, InterruptMask::E - InterruptMask::RI); + } } -- 2.53.0