Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0B74C55175 for ; Mon, 3 Aug 2026 09:44:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wqpCr-0008HQ-IZ; Mon, 03 Aug 2026 05:43:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wqpCp-0008H2-LC; Mon, 03 Aug 2026 05:43:35 -0400 Received: from [115.124.30.98] (helo=out30-98.freemail.mail.aliyun.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wqpCi-0004O9-65; Mon, 03 Aug 2026 05:43:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1785750184; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=94+buU6q0k5Rnz6QgSCfXxpvrnct48T0/UiY4nN7HFU=; b=BRVkdDkkunAgaXsgvNJPeqvveKZqII+kNWCgxue67ngZH/zKYMzCGEaULCFFv2FyGCZqe6+9S7Gd0Xd9vv1U8039AyLvUVLmUTKNtk/DzCzCNxdU/8M0fxQXXKNi4xZfbhxPtbHZgF35V6Q8FhjABNbcFNxVqHaS6uMbdwfqYek= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R211e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033037033178; MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=4; SR=0; TI=SMTPD_---0X8IIj03_1785750183; Received: from localhost(mailfrom:guobin@linux.alibaba.com fp:SMTPD_---0X8IIj03_1785750183 cluster:ay36) by smtp.aliyun-inc.com; Mon, 03 Aug 2026 17:43:04 +0800 From: Bin Guo To: qemu-devel@nongnu.org Cc: Eric Auger , "Michael S . Tsirkin" , qemu-stable@nongnu.org Subject: [PATCH] hw/virtio/virtio-iommu: Reject inverted MAP range Date: Mon, 3 Aug 2026 17:43:02 +0800 Message-ID: <20260803094302.95228-1-guobin@linux.alibaba.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.124.30.98 (deferred) Received-SPF: pass client-ip=115.124.30.98; envelope-from=guobin@linux.alibaba.com; helo=out30-98.freemail.mail.aliyun.com X-Spam_score_int: -166 X-Spam_score: -16.7 X-Spam_bar: ---------------- X-Spam_report: (-16.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org virtio_iommu_map() did not check that virt_end >= virt_start. An inverted range corrupts the GTree comparator contract (interval_cmp returns non-zero for a key compared with itself), causing an infinite loop in virtio_iommu_unmap() while holding s->mutex. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4104 Cc: qemu-stable@nongnu.org Signed-off-by: Bin Guo --- hw/virtio/virtio-iommu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 533bd5073f..cc863e90d2 100644 --- a/hw/virtio/virtio-iommu.c +++ b/hw/virtio/virtio-iommu.c @@ -807,6 +807,10 @@ static int virtio_iommu_map(VirtIOIOMMU *s, return VIRTIO_IOMMU_S_INVAL; } + if (virt_end < virt_start) { + return VIRTIO_IOMMU_S_INVAL; + } + domain = g_tree_lookup(s->domains, GUINT_TO_POINTER(domain_id)); if (!domain) { return VIRTIO_IOMMU_S_NOENT; -- 2.50.1 (Apple Git-155)