Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D033A47AF6D for ; Tue, 4 Aug 2026 16:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785862042; cv=none; b=g3aZfS7JvdpENO1sJoDiqiTb/jyYWgMDaIBr52IGS3/f0u99lmV5buQB24JqCE8IMLXvkL7AdyDNPwLbKT66mmStHMzGbkk7ss7X8d3zLhbe0SRekXn5hOf+/7xbFdtSidIfE42yGUkToaf4zqCoaJ8JlvMrxvxfQBL5r0XAHG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785862042; c=relaxed/simple; bh=Tbb25sGeZrNe8qfMPaAkIA3bkftbTcqapPEA5L4Nj5M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UrF9gbfrCOFc0MlT8RHLspfCZCqQwhNPmk0eaorcsf8jKXcfneLP4skgqDpnXDoJkkea4KXc/yuMNQIv4lBbwQK0SVn4st7aDw+v81lk+ShL/RPIttjaHUp2tDLW8TYvAj1g4LABXbpnKTfmmfLuPinUoOADhkCNAecTguh2dvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z9mjaudi; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z9mjaudi" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4954dff6536so225145e9.0 for ; Tue, 04 Aug 2026 09:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785862028; x=1786466828; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eEXE5xEEQpc13Rsa6o31+ciZXy4TocWR50mP3ni+aMQ=; b=Z9mjaudilTRhoswaE+IateT5cMLZIgBxu91iFkfmDn1D398Qu7Yi8ISavFfHlNCMge 3jWk6JUlXuUPIqOlijSAGWcokC3LRwY0siU5jRrUhO+a9T3Qgw3+4B9QGKsbUgMzXJvm 7IOYGVyb7y0Be09eH87w6PhGlXk5ZNuIeNdH+9uttNM2540aiQ7OaKKHFWr6ASLwWX9f 7Z/nWMwV7EoxumfXKrYaTORgNKfp0LE/24rE1iUMbN0PoRcTxPb0IGO+R+wDI0grX3lI En+9+BX8qhIiwnQqhvwnQH2kCM48Z6GWepv252Mzd8lJbF4IBdUf9m250wl491rLPRS5 AuLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785862028; x=1786466828; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=eEXE5xEEQpc13Rsa6o31+ciZXy4TocWR50mP3ni+aMQ=; b=b68IgckcR6wiYPCqAzvUI/4vJ3SWs4U0bXhTEsZRQhQyMZwlgwbMNUjubZ9DNTmxSh yabQRP2E35W4xtvEb3pT5u53LCclh7Ju1ND2KNPDcxnc/P+m78m+G9n+r9FWNRhSUs1I bG+i441WnGSxFZBDw4H0HDaP68HDfQaEhOy1uBs4bz891KsHL+3OYUDBpz7YusAeYDTT Iyr8rZW7StjABIaRiJw1Rwsm5foKN5tAzFh27Iq9swDKJ8Dr2ipLwRrQG5rfnW7qLxP2 6nQuARZpcMrh5YW/CFL1eNaSKzqCfMlwNS90zoJ3wcd+NoJNolE8pb+BDcTssepgaLRM ek0Q== X-Forwarded-Encrypted: i=1; AHgh+Rrp20H5YzI8us6NaoxRJv/ObsSDgaYSPysmITgC4KZCHrwKMmuaQrcxNerqBoEtG+o6FuEOBRg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2KNooOnXx/Hbo5FGnP7qCu4tLH8nGII07wwszI+96OdaJOOsI NnmBpo2qqMqis3o/zuUBi4Var/HNGLLyoAym/A+OSQLgGjPnUVEWYQXw X-Gm-Gg: AR+sD13tSApBucpR2tOoBgdj5ltz9YgfRbaZmyYUPWNOIPqUk9rvWKpy3pzECW6H+eQ X17ee5s2cRUvGm+ToWXvhuJZaYw4CvXj+2rnsvf2fU/ew1QksG3KNpH5mAn8qnBScWrls1KoEel 0SHeuhiKqDPkWBdi3NpXK406gLrOd3n/sE5m2XdDB2NHXt9ry6dw4hEgimCBAbtfTbIKnZYNRGx 78NdsOmnTEkKIW22en62nSWgAwY83MedaVmbA6MILwDmboJEasxddj+GYzTRGn92GiWhQX3+LMU JRJLv6fYvOKDuE5GCUtQbESexNojCRYRsodkK35L6vCGj+VaXS5ofqTIrPzS5VeXx/zfU0a1O0X +yug1EspHv/bkVZ3+Fk6r8kOZOXKRPPI199O/u3wjGDU8vuVOS3dWRZzU48nt/9C7Fe5ypugDy0 va5lPLDKYm6Z51O6QBDzIGLU734VZa5LbWKakZgrp0VNJQ0dYpy4TIxCtNG+eLOD5+InmL0v27a N0tdBHFip56odov4NmkwB1ZJnVgKckMMA== X-Received: by 2002:a05:600c:4e8c:b0:492:3e69:a86f with SMTP id 5b1f17b1804b1-4980c66c82dmr298035625e9.1.1785862028307; Tue, 04 Aug 2026 09:47:08 -0700 (PDT) Received: from mtardy-friendly-lvh-runner.europe-west1-c.c.cilium-dev.internal ([2600:1900:4010:1a8::]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4994e04db3asm14229485e9.15.2026.08.04.09.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 09:47:07 -0700 (PDT) From: Mahe Tardy To: bpf@vger.kernel.org Cc: andrew+netdev@lunn.ch, andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, eddyz87@gmail.com, edumazet@google.com, john.fastabend@gmail.com, kuba@kernel.org, liamwisehart@meta.com, martin.lau@linux.dev, pabeni@redhat.com, song@kernel.org, netdev@vger.kernel.org, sdf.kernel@gmail.com, ameryhung@gmail.com, kuniyu@google.com, Mahe Tardy Subject: [PATCH bpf-next v3 5/5] selftests/bpf: Add ksock test for async callback guard Date: Tue, 4 Aug 2026 16:46:52 +0000 Message-Id: <20260804164652.296919-6-mahe.tardy@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260804164652.296919-1-mahe.tardy@gmail.com> References: <20260804164652.296919-1-mahe.tardy@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Because the kfuncs are going through LSM hooks, allowing their use via workqueue callbacks would expose the wrong credentials. This test ensures the kfunc are preventing any use from these contexts. Signed-off-by: Mahe Tardy --- .../selftests/bpf/prog_tests/ksock_wq.c | 34 ++++++++++ tools/testing/selftests/bpf/progs/ksock_wq.c | 62 +++++++++++++++++++ 2 files changed, 96 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/ksock_wq.c create mode 100644 tools/testing/selftests/bpf/progs/ksock_wq.c diff --git a/tools/testing/selftests/bpf/prog_tests/ksock_wq.c b/tools/testing/selftests/bpf/prog_tests/ksock_wq.c new file mode 100644 index 000000000000..5b9c6cc30392 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/ksock_wq.c @@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2026 Isovalent */ + +#include + +#include "test_progs.h" +#include "ksock_wq.skel.h" + +void test_ksock_wq(void) +{ + LIBBPF_OPTS(bpf_test_run_opts, opts); + struct ksock_wq *skel; + int err; + + skel = ksock_wq__open_and_load(); + if (!ASSERT_OK_PTR(skel, "ksock_wq open and load")) + return; + + err = bpf_prog_test_run_opts( + bpf_program__fd(skel->progs.ksock_wq_start), &opts); + if (!ASSERT_OK(err, "run ksock_wq_start")) + goto out; + if (!ASSERT_OK(opts.retval, "ksock_wq_start retval")) + goto out; + + while (!__atomic_load_n(&skel->bss->callback_done, __ATOMIC_ACQUIRE)) + usleep(1000); + + ASSERT_EQ(skel->bss->create_err, -EOPNOTSUPP, + "workqueue create rejected"); + +out: + ksock_wq__destroy(skel); +} diff --git a/tools/testing/selftests/bpf/progs/ksock_wq.c b/tools/testing/selftests/bpf/progs/ksock_wq.c new file mode 100644 index 000000000000..16a1873d132e --- /dev/null +++ b/tools/testing/selftests/bpf/progs/ksock_wq.c @@ -0,0 +1,62 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2026 Isovalent */ + +#include "vmlinux.h" +#include +#include "bpf_experimental.h" +#include "bpf_tracing_net.h" +#include "errno.h" +#include "ksock_common.h" + +struct ksock_wq_value { + struct bpf_wq work; +}; + +struct { + __uint(type, BPF_MAP_TYPE_ARRAY); + __uint(max_entries, 1); + __type(key, u32); + __type(value, struct ksock_wq_value); +} work_map SEC(".maps"); + +int create_err; +u32 callback_done; + +static int ksock_wq_callback(void *map, int *key, void *value) +{ + struct bpf_ksock_create_opts opts = { + .family = AF_INET, + .type = SOCK_DGRAM, + .protocol = IPPROTO_UDP, + }; + struct bpf_ksock *ks; + int err = 0; + + ks = bpf_ksock_create(&opts, sizeof(opts), &err); + if (ks) + bpf_ksock_release(ks); + create_err = err; + __sync_fetch_and_add(&callback_done, 1); + return 0; +} + +SEC("syscall") +int ksock_wq_start(void *ctx) +{ + struct ksock_wq_value *value; + u32 key = 0; + int err; + + value = bpf_map_lookup_elem(&work_map, &key); + if (!value) + return -ENOENT; + err = bpf_wq_init(&value->work, &work_map, 0); + if (err) + return err; + err = bpf_wq_set_callback(&value->work, ksock_wq_callback, 0); + if (err) + return err; + return bpf_wq_start(&value->work, 0); +} + +char __license[] SEC("license") = "GPL"; -- 2.34.1