Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C977240B11E for ; Wed, 5 Aug 2026 09:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785923146; cv=none; b=d8zT+aH5S0+x/XA/7SI//8MrLZHb4xFKeauhvF3cgbnNKLIi7am94T9kTFTydK/aOe9T/wNptbnegAaN+zjwsh/ZJEEbXjjVt6rUjILRO7maPGj9A+7GB0p2ob6f5aPbfODBflDIjOzOmevGKN3FffCciUwwln1w0hHQuolaSBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785923146; c=relaxed/simple; bh=9p/1oV1sCpJbdZfXxl0dqBaf5ZkywiMBhQ4vr0l+CrA=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=oNJtzmWByWHYhY94ADf+8HAe/lmFf0U5ubLJGT20RVANjH36ntxEdYB3OqB8R107xgzwQZHy2e2Dzc0natuX4DZhaKwHM8HKX6a5+mePHRfxBVhyC7MAW/O0lDQtMnZ+nqDCr7hT/p0l/ECE4JVEWHxWum6oNkgLMqjXTaRaOY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=N/bu72CR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="N/bu72CR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 253351F000E9; Wed, 5 Aug 2026 09:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785923145; bh=w0V4wySbY6UOp0a2rGTWUjqNpPsdXZwtvnZxiyOoCfI=; h=Subject:To:Cc:From:Date; b=N/bu72CRxoYC4iS22psCM2Dmoz2PwZbZUFCJD7ARHC6OEb43wp4a6LrQRSn35h+29 xawJtGQrAWKQG5+UE2OcYPq2O54VmT0QXHsdbFBb4LfiMU0fXJ4Rx6ZwVBMYIad7RH ot8ur0MTEulKFIOC6zK+Q4D4fkzVu/TAPrgUOys8= Subject: FAILED: patch "[PATCH] ASoC: tas2562: Validate values for volume writes" failed to apply to 6.18-stable tree To: broonie@kernel.org,cezary.rojewski@intel.com Cc: From: Date: Wed, 05 Aug 2026 11:44:58 +0200 Message-ID: <2026080558-cure-reselect-5290@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.18.y git checkout FETCH_HEAD git cherry-pick -x 8fb41964f7e4e4207c8999af2056894caa7a252a # git commit -s git send-email --to '' --in-reply-to '2026080558-cure-reselect-5290@gregkh' --subject-prefix 'PATCH 6.18.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 8fb41964f7e4e4207c8999af2056894caa7a252a Mon Sep 17 00:00:00 2001 From: Mark Brown Date: Wed, 15 Jul 2026 21:18:09 +0100 Subject: [PATCH] ASoC: tas2562: Validate values for volume writes tas2562_volume_control_put() does not do any validation of the control value written by userspace, it uses it to look up a value in a fixed size array which can easily be overflowed and then writes whatever value it gets back to the device. Add validation that we are loading a value we have in the array. Cc: stable@vger.kernel.org Reviewed-by: Cezary Rojewski Link: https://patch.msgid.link/20260715-asoc-tas2562-put-retval-v1-1-97bf467c924e@kernel.org Signed-off-by: Mark Brown diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index e1d62f30418a..40b7803c68be 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -471,10 +471,14 @@ static int tas2562_volume_control_put(struct snd_kcontrol *kcontrol, { struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); struct tas2562_data *tas2562 = snd_soc_component_get_drvdata(component); - int ret; + int ret, index; u32 reg_val; - reg_val = float_vol_db_lookup[ucontrol->value.integer.value[0]/2]; + index = ucontrol->value.integer.value[0] / 2; + if (index < 0 || index >= ARRAY_SIZE(float_vol_db_lookup)) + return -EINVAL; + + reg_val = float_vol_db_lookup[index]; ret = snd_soc_component_write(component, TAS2562_DVC_CFG4, (reg_val & 0xff)); if (ret)