Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF8DB1A238F for ; Fri, 7 Aug 2026 18:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786126284; cv=none; b=pYJPx/tD8EJpC0pRWLGwyF7xhN9/GaX5meQEJFuO7J1wuGsVEEOYVpdwEybKZQfEfzxQ1+kk/TrWbqsBvRVifPDoSN0wfqF/VpgXM7UdzxBGNQMoZ0ZAyeQAnmZPLL61pGCHBsB+9TY0QAtsIbwEiCGdSRi9rKDnJJzJpPeywEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786126284; c=relaxed/simple; bh=hZAwGQQAZUwdL4Vm9UBXMOU2y9RXT8Y5k+hXkzHVk8A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rShTVFpdOU9pKx6DNMpKd6DK4baKuzaXM3gnVwTxQ7iwZJ6A+JbR9TTWFDcFEPs2DTgTI2fQlIucQ1tMfrSevnhC6mg8RJmadk1TwE5bLUEZydOb/eU1uEiZmLdzJenU5k3zFSfK9RmK56fBQ8APrBad/1LP2XpiCboOrv+rnes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kAr/AOnT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kAr/AOnT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 734DD1F000E9; Fri, 7 Aug 2026 18:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786126282; bh=luao1PryEwNmo/aE4pt3ynHFrcV3ykbXGsNC17aPdAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kAr/AOnT41GM/hOcUhU+0/xEUNFn0OhdKPKaI2n8dWSuCQrNnE4GKGDjTGJgvA6xX boQx0I65wkIRyV0pHouSXopSlG7xF8Vvv/fn+NHxm5ttGSt3Faujp4j8ojV1oAcNcX RmAnAYs8MtrVkaYuglUxfvcHoQCmyTKG/J6qn5u20roqYgl1VAb7zX1NcnSfAzrlcT iXQj+t4Nr3+jNavfWu3Au6RgnXnNc0oaQz8CYUoDouZKor9vkoJ5fNKNqOnlogOSKd 552RpwLRZQP2Nhz2geiu40Fchy7V9FOxzKTPLNdd6reqZmPnh0xRKM0zoyLLkXPDJt TjTFOIYTZBrAw== From: Sasha Levin To: stable@vger.kernel.org Cc: Zhiling Zou , Yuan Tan , Yifan Wu , Juefei Pu , Xin Liu , Qi Tang , Ren Wei , Xin Long , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15.y] sctp: avoid auth_enable sysctl UAF during netns teardown Date: Fri, 7 Aug 2026 14:11:19 -0400 Message-ID: <20260807181119.2881603-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026072934-tiptop-dilation-1de0@gregkh> References: <2026072934-tiptop-dilation-1de0@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhiling Zou [ Upstream commit f8d5e7846025f4ab15a461235f8ebae9094a361a ] proc_sctp_do_auth() updates the SCTP control socket after changing net.sctp.auth_enable. The handler gets the per-net SCTP state from ctl->data, so an already opened sysctl file can still target a network namespace while that namespace is being torn down. SCTP previously registered its per-net sysctls from sctp_defaults_init(), while the control socket is created later from sctp_ctrlsock_init(). This exposed a window during initialization where auth_enable was writable before net->sctp.ctl_sock existed, and a teardown window where auth_enable stayed writable after inet_ctl_sock_destroy() had released the control socket. Move the per-net SCTP sysctl registration into sctp_ctrlsock_init() after sctp_ctl_sock_init() succeeds, and unregister the sysctl table before destroying the control socket in sctp_ctrlsock_exit(). If sysctl registration fails after the control socket was created, destroy the control socket in the same init path. Make sctp_sysctl_net_unregister() tolerate a missing header and clear the saved pointer so init-error and exit paths can safely share the unregister helper. Fixes: 15649fd5415e ("sctp: sysctl: auth_enable: avoid using current->nsproxy") Cc: stable@vger.kernel.org Reported-by: Yuan Tan Reported-by: Yifan Wu Reported-by: Juefei Pu Reported-by: Xin Liu Co-developed-by: Qi Tang Signed-off-by: Qi Tang Signed-off-by: Zhiling Zou Signed-off-by: Ren Wei Acked-by: Xin Long Link: https://patch.msgid.link/390cd5e91ed60eea27b0b64d0468301a9e73b808.1784033357.git.roxy520tt@gmail.com Signed-off-by: Jakub Kicinski [ dropped the missing `l3mdev_accept` context block and kept 6.1's non-const `struct ctl_table *table` declaration ] Signed-off-by: Sasha Levin --- net/sctp/protocol.c | 20 ++++++++++++-------- net/sctp/sysctl.c | 9 +++++++-- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 9987decdead21..b5102cd7b42a3 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -1386,10 +1386,6 @@ static int __net_init sctp_defaults_init(struct net *net) /* Initialize maximum autoclose timeout. */ net->sctp.max_autoclose = INT_MAX / HZ; - status = sctp_sysctl_net_register(net); - if (status) - goto err_sysctl_register; - /* Allocate and initialise sctp mibs. */ status = init_sctp_mibs(net); if (status) @@ -1423,8 +1419,6 @@ static int __net_init sctp_defaults_init(struct net *net) cleanup_sctp_mibs(net); #endif err_init_mibs: - sctp_sysctl_net_unregister(net); -err_sysctl_register: return status; } @@ -1439,7 +1433,6 @@ static void __net_exit sctp_defaults_exit(struct net *net) net->sctp.proc_net_sctp = NULL; #endif cleanup_sctp_mibs(net); - sctp_sysctl_net_unregister(net); } static struct pernet_operations sctp_defaults_ops = { @@ -1453,16 +1446,27 @@ static int __net_init sctp_ctrlsock_init(struct net *net) /* Initialize the control inode/socket for handling OOTB packets. */ status = sctp_ctl_sock_init(net); - if (status) + if (status) { pr_err("Failed to initialize the SCTP control sock\n"); + return status; + } + + status = sctp_sysctl_net_register(net); + if (status) { + inet_ctl_sock_destroy(net->sctp.ctl_sock); + net->sctp.ctl_sock = NULL; + } return status; } static void __net_exit sctp_ctrlsock_exit(struct net *net) { + sctp_sysctl_net_unregister(net); + /* Free the control endpoint. */ inet_ctl_sock_destroy(net->sctp.ctl_sock); + net->sctp.ctl_sock = NULL; } static struct pernet_operations sctp_ctrlsock_ops = { diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index f3d09998c24de..2e99de0aeea6d 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -617,11 +617,16 @@ int sctp_sysctl_net_register(struct net *net) void sctp_sysctl_net_unregister(struct net *net) { + struct ctl_table_header *header = net->sctp.sysctl_header; struct ctl_table *table; - table = net->sctp.sysctl_header->ctl_table_arg; - unregister_net_sysctl_table(net->sctp.sysctl_header); + if (!header) + return; + + table = header->ctl_table_arg; + unregister_net_sysctl_table(header); kfree(table); + net->sctp.sysctl_header = NULL; } static struct ctl_table_header *sctp_sysctl_header; -- 2.53.0