Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5E7041A565 for ; Wed, 12 Aug 2026 09:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786528258; cv=none; b=Z1KuGDXMHvby/V7sgWdQM5wIGDm5RNJUMeskOT4nzWekAImLMcMZbVffY342T+aXe33EBHEXNAfWa4Ap4eUCf+IGdFPDX+IzUthObmqRnWg9O9V1OMBUHPTfwZ/trutx7dBl8k6bFuZfjliEUCKv2uxc5JgXbMPJORUAhdEKl4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786528258; c=relaxed/simple; bh=9ENnEmwayPtcIEaZJbd41zai2HeuT1akIj+2iKWz8d4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bQpJKPlUxOSI1CUaDmhopaLLf8luBUn7DYPIYp2dAbSymma4zAo+hRgutg/3Xiu98X9pkL8i/cj9W0MYkFsftGbJzQH+UhmrYpJUJbN1F/o7rrbxvxJChZXufpcmt8IBTKy5FSoyaAWPbHEzV5/wc5aPO+oELONC6zKcj9TORpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R/az58Z6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R/az58Z6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C64A91F00A3E; Wed, 12 Aug 2026 09:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786528256; bh=gGGkpEFD32PxBKVKmgmJKIbUj0Hv4OZvB+mL4Lj5Q+c=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=R/az58Z6Fayi3f0JqixgB3N0Z9p4sNWZZRj42RmJcekiZriMUoDc7+FuG3H4SVspG ZuiH5BvHT8wkkOsl68rxAZ+AxhJIwokCG0piElr7g9VPAZI4ZiotUX5rObdOsXnYXz uLrORi9+27PwQ3/FvNo1FK0Aj8fWKLwDzyvb1My8gAZRBLfHQ54i9eSvjYPLAWCaDb rmqZUJoLur9wTqXAVGTG88zceImiftZiWifvmcfLK+qOVmjFy33ufCzLImWNydEZ0/ HrPs/FE9AIJypYb2BxTqqZA89XhC1h/xbvqKtJKnrAkeDoGTsrCbEtR2NChjwMfvm0 WhuSPOPnF63zw== From: Sasha Levin To: stable@vger.kernel.org Cc: Jonas Gorski , Ray Jui , Andi Shyti , Sasha Levin Subject: [PATCH 6.6.y 2/2] i2c: iproc: reset bus after timeout if START_BUSY is stuck Date: Wed, 12 Aug 2026 05:50:53 -0400 Message-ID: <20260812095053.1573236-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812095053.1573236-1-sashal@kernel.org> References: <2026080559-pope-hardcopy-9445@gregkh> <20260812095053.1573236-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jonas Gorski [ Upstream commit 98f2e9e6d6f91a6abb43f166b244b428ba85fa2b ] If a transaction times out, the START_BUSY signal can stay up, and subsequent transactaction attempts will fail as the bus is still considered busy. I can easily trigger this by attempting to read from an address with no device, e.g. when running i2cdetect. After the first read times out, all subsequent read attempts return busy. To get to a working state again, the controller needs to be reset to clear the START_BUSY signal. So check for START_BUSY still asserted on a timeout, and do reset in case it is, This is also done by the original non-upstream iproc-smbus driver implementation [1]. Works around situations like: bcm-iproc-2c 1803b000.i2c: transaction timed out bcm-iproc-2c 1803b000.i2c: bus is busy bcm-iproc-2c 1803b000.i2c: bus is busy bcm-iproc-2c 1803b000.i2c: bus is busy bcm-iproc-2c 1803b000.i2c: bus is busy bcm-iproc-2c 1803b000.i2c: bus is busy ... where the bus never recovers after a timeout. [1] https://github.com/opencomputeproject/onie/blob/master/patches/kernel/3.2.69/driver-iproc-smbus.patch Fixes: e6e5dd3566e0 ("i2c: iproc: Add Broadcom iProc I2C Driver") Signed-off-by: Jonas Gorski Cc: # v4.0+ Acked-by: Ray Jui Signed-off-by: Andi Shyti Link: https://lore.kernel.org/r/20260717085507.34209-1-jonas.gorski@bisdn.de Signed-off-by: Sasha Levin --- drivers/i2c/busses/i2c-bcm-iproc.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 133d02899c6bd..907f66cbf2326 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -811,6 +811,17 @@ static int bcm_iproc_i2c_xfer_wait(struct bcm_iproc_i2c_dev *iproc_i2c, } if (!time_left && !iproc_i2c->xfer_is_done) { + /* + * The controller may fail to clear START_BUSY after a timeout, + * reset the controller to recover in that case. + */ + if (!!(iproc_i2c_rd_reg(iproc_i2c, M_CMD_OFFSET) & + BIT(M_CMD_START_BUSY_SHIFT))) { + bcm_iproc_i2c_enable_disable(iproc_i2c, false); + bcm_iproc_i2c_init(iproc_i2c); + bcm_iproc_i2c_enable_disable(iproc_i2c, true); + } + /* flush both TX/RX FIFOs */ val = BIT(M_FIFO_RX_FLUSH_SHIFT) | BIT(M_FIFO_TX_FLUSH_SHIFT); iproc_i2c_wr_reg(iproc_i2c, M_FIFO_CTRL_OFFSET, val); -- 2.53.0