Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A40F486631 for ; Wed, 12 Aug 2026 21:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786569852; cv=none; b=Ezj2PCt0OUKwQVSsZQeFf/LXGas1rlsHkOE3hiaMW2aEIFl+xBFhfOtTLyDr8wBdJLkkJpp7Lyyb/JG5kPv9CAC1TCEbjZoeQxyBpIxQKwVTTf/fA91Ow25z4KXmuzXphoYN758QRiydZ1483T1ZRO1hOot/ADQRKH8ZtMDYauw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786569852; c=relaxed/simple; bh=QCI6saZnS8XE0yeN3Gd61Gz9oHZB0IlqCbAAUb+4psA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a/6pLFxDmVq+ubf61t6LJKnNdJN6oL9lPUaR5jKv1gwIzumfd4twzP64bOBUl2mtxDia7piNIl9avZOIj/3XK8F+t8Rd1hvflOfGFb885QoLe/jrTRN25Re/dzrUCa/fqiSKFOW7/d3qS7DbwqdhXTG7wAsYuz42tdHmpCaeRtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=br891Ysh; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="br891Ysh" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CK2nQi3381435; Wed, 12 Aug 2026 21:24:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=LdaElW2fjsYZ4sS7m d+wfVBMiAAFOnLH9/coga1UTUQ=; b=br891Ysh9yA0/OA36C0BQYHNqA2oncvqQ wsBTJcgl0qUIx9RkUoWeTnTAd6GfQqeMy3ytE0WTdgTPBm77V0LB+Trf8qUQGbow eO+YtU8vm9fiP9sNA/5+L8CJaePE0Y2TwQ31cT8byWbquROt5ITOWwfJc3/zAbOG uc3UsFP0bHbUWNDY0rr77jTlYr+5vkAeEq9pRxs8fD4qaWT1TRG9r0npJHiNwikq SxLnvFu99LLDF9K75LTQNG8p1Q0PaBm3kbgBteM4rQDDFLLdFA/bbo2N7wdm5BgI cXKi/tPgy+RIhfTB79Yk7czLApcmQRCsLWbaauQk4j2lKta8KGKAw== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fyb23w9yp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Aug 2026 21:24:08 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67CLBIAK019042; Wed, 12 Aug 2026 21:24:07 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fxf5w889y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Aug 2026 21:24:07 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67CLO6lW32637478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Aug 2026 21:24:06 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B92758043; Wed, 12 Aug 2026 21:24:06 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0746A58055; Wed, 12 Aug 2026 21:24:06 +0000 (GMT) Received: from IBM-D32RQW3.ibm.com (unknown [9.61.244.42]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 12 Aug 2026 21:24:05 +0000 (GMT) From: Farhan Ali To: stable@vger.kernel.org, gregkh@linuxfoundation.org, sashal@kernel.org Cc: alifm@linux.ibm.com, Matthew Rosato , Niklas Schnelle , Christian Borntraeger Subject: [PATCH v3 4/4] KVM: s390: pci: Fix aisb calculation Date: Wed, 12 Aug 2026 14:24:03 -0700 Message-ID: <20260812212403.3143-5-alifm@linux.ibm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812212403.3143-1-alifm@linux.ibm.com> References: <20260812212403.3143-1-alifm@linux.ibm.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=XqfK/1F9 c=1 sm=1 tr=0 ts=6a7ce478 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=Kdkv-2UG5BF8DrlVkd8A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDE2OSBTYWx0ZWRfX/8PLZgocSeP+ XTP9hSLPe1O/P9JZ8HsfB/3l0+JJXb1dfvBAgBWvsr1pBImb1eNWnibQy8KWhhMWHZvekHq8I+e 7hPDUCNoINP/O+fVbkv3eu7eh1nVxo69FPQqI2FDvCV40PUE8I3eDh4j2ADkHA/hU8CZIFsJjy/ O+pbsfLD2F/MiZit23gI/a/XDg1R7rzgmiq2n4E6XLhiyMXg6xgGoAJLvDUfzGWK/FkIgfi+G/6 owzSLFrm8581uRwDePhA5qqm9bQ27hL56L4mlMnSIf7UaMbCD9PB4IAz42032XxS3ZzAgRGOigX gGTV3/4X6JPT4hCyiNvsXW/g/r1vDfPiXM1wcbGYS/q4/+1A4vz3Amo2z+s3XbZqZ26vkB0VYO+ 7mt1kIpG0VMe9sxRwQZ7r5Xjf+CS0pTFLpz8cayRsCOX+692ehC7cmPg9QDX7RpiHS6ZjwI0GuE E9dbktzpxWo4SjyXDMQ== X-Proofpoint-ORIG-GUID: PpOu978xse6g3gHLLxTY4UlZRJP_Akg8 X-Proofpoint-GUID: PpOu978xse6g3gHLLxTY4UlZRJP_Akg8 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDE2OSBTYWx0ZWRfX7cTy/S/0/0Fg ChJo2LGlY+ItTRX5h4MD9PkAXSzDrPcswzHikENARU9YVv4JOKZXCJvVgHxSLVSgNgAVHLPK085 VaAMqm9zMT2seqTVPl9e0O9g7iC5K18= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_06,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120169 From: Matthew Rosato The current implementation of aisb calculation will erroneously index via an unsigned long * as well as multiply by 8B for every 64-bits in the offset; only one or the other is required. This throws off aisb calculations once the number of devices exceeds 64, and can result in out-of-bounds access as well as failure to indicate summary bits associated with those devices in guests. Fix this by converting to a physical address before applying the offset, as is already done in arch/s390/pci/pci_irq.c. Fixes: 3c5a1b6f0a18 ("KVM: s390: pci: provide routines for enabling/disabling interrupt forwarding") Signed-off-by: Matthew Rosato Reviewed-by: Niklas Schnelle Signed-off-by: Christian Borntraeger (cherry picked from commit 0cfe660559e857d7c00ab86c73e4510ce069086f) [alifm@linux.ibm.com: Resolved merge conflict] Signed-off-by: Farhan Ali --- arch/s390/kvm/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kvm/pci.c b/arch/s390/kvm/pci.c index 61489016e425..d9fcbf41025e 100644 --- a/arch/s390/kvm/pci.c +++ b/arch/s390/kvm/pci.c @@ -167,7 +167,7 @@ static int kvm_zpci_set_airq(struct zpci_dev *zdev) fib.fmt0.noi = airq_iv_end(zdev->aibv); fib.fmt0.aibv = virt_to_phys(zdev->aibv->vector); fib.fmt0.aibvo = 0; - fib.fmt0.aisb = virt_to_phys(aift->sbv->vector + (zdev->aisb / 64) * 8); + fib.fmt0.aisb = virt_to_phys(aift->sbv->vector) + (zdev->aisb / 64) * 8; fib.fmt0.aisbo = zdev->aisb & 63; fib.gd = zdev->gisa; -- 2.43.0