Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5F2134250E for ; Sun, 16 Aug 2026 13:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786888516; cv=none; b=aXhOrVMaFuEbSxF3uCyFhnA1vx51WideBPepdsK468VppCAexMZVBp+oto2YzY8ZzD1wqp2Q8bvVq9RPWsGkWyp5CQBDQH1ipo2ryNSC6rxq7RQA25jgUL/s/jTjChaktRSz/uR8vHITmkbw1yv1cZWQN0MyY/4U34T8Mqc5/iI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786888516; c=relaxed/simple; bh=6gXzcdUOI2C/JorOCTroU4TApGBlIDqM/twHJT8nr/4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=T/U2XvRBhn0gH16S+1fkcA2wqCLtaOxEuiwPfsmy5OJsYOtvnNxqMrHsHhAyAH5vTdq8f3c3+xOYWTZLhE3JuotWfQN0rJ9sChLW1ZtGShPZxRRwoXhhwFegI09o2VhnAw8fumsl3fce989hkyRUlmsakHz/EaprWUf6vd2sRgs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i48S9VjG; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i48S9VjG" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4954a32cf1eso12807615e9.3 for ; Sun, 16 Aug 2026 06:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786888512; x=1787493312; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=uClaKJD4Ir9tR/GTyjo/ABX39e0TSK4z5x2QoXKCFyM=; b=i48S9VjGJ2nN+FeVkUwvOu8DGkPszlyjOHgoJTzLBXcIrQNvnWHJ2Bq2fOKPpAFT+S fKimLN+IkWWm8uBdrOTTl7f/mt5zzjP1b7I2vl4bKYqPpIMWJ+4S/9CB9Zib3ty06ILc gntvFwNqxPa7tfCnBZmqzmhbRigpTzj4ymdKmqPnnJEYuJqU+jDgJTdOwBnxrtHso7qc W5eN6ITAbQ81L3BnKK43RkKgrJzAQ+nfEDnQ5RVnOdjZLmFq2xk6A/PUaYCAxJdvt2bm R4M4QRx2fbI9hFbUk7pfOBvpdvVrN17qhqWX/x317C1Jl82va3jIuybEReNC0KG28hKD av/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786888512; x=1787493312; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uClaKJD4Ir9tR/GTyjo/ABX39e0TSK4z5x2QoXKCFyM=; b=ggjijJXC0O1yPejq2OS6w7nV4knYabNzYfvw2QCHQZ2RELHWKLoihU+cCf/Lz9LKPp hZH3a2hr0Mj0PqnoQMATqzSqaq/78OGh2GUTWZWjLCV8uGPscmHLV0Q5NozBludgY8Vk 6m+rqYhfNDZroRI+33xHO8ZSZ7Gq2Uw6UOyphZ4X+XzYAq6YR/fYtwvP9s33l6iMb0tt XrwqnPy2zw0pT0MCRlMcYfldySdICd6KpClH5tK7HR7Q8ujajuxtH4Gqeelpqc/99aOU fVZsLdIbz8XlMMLhgH4GQlR5Zwz6T5qM0lGHrhpL6/aljDyFoymtlcSqAdVdtVxtlgas rC7A== X-Forwarded-Encrypted: i=1; AHgh+RpkRXX2Ek80+azZ3qgBVbMKYl8pZ0ivuHAFRVhpBzYmkxV+QXRAlOVOZP9o+Lr4nPsGWL1ukg4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw04WRoBjegW/8sE6ov0a2RynYDO+p7XoIuo8riU87tSqXPiqIj aOiOsEaZMiGF6Zw1efDvOSE5gjDYbhebz57RXRzJ1+zCdkeeLC+HEwM= X-Gm-Gg: AR+sD12Va5z1tVGd0GP1+jAKmZSUEIDfjOgCQlfX997w2MU7f76UNkHgo/VC3Y/Y7HB skyeQWU9wsO65CIe1qBrQo4Arb35sn6J9aooHzbZWGpYbnJ0OOJ0sNBNrdulR3uOaqqaReyWkHj 9ZlnfuZCvDzBnvv2UxHztgPTpn7jlWBjxIT0Tm5vZSVuTNL8dffDhXdyuaGL48EWaZyw73BEOxw O/SURL3U82rat/tLCKYJrbXCAhUo4Ah25PSkDxFNCH8dnTJemWoF1iGfMJE79w9yj1c7Cda5CMa ON6uk3Kezz8HyytyXevRwATNosAFmOE2Xo/DJ9aSwB+/cA5Z/uQ9K/fK8YmBOJSOj2Q5jx8YeUw EkIbk7da9DrEGxafyHeEqEF/l8zDLcL7nie69OzJZwZYvNphSYtcODx+Ymu6oBUgqmEy+mQmKcH hmXqi0P7FDpNfQx6XxIqOk5Y6AQ1Qa9A== X-Received: by 2002:a05:600c:3485:b0:499:726a:a017 with SMTP id 5b1f17b1804b1-49987938e19mr302694185e9.1.1786888511685; Sun, 16 Aug 2026 06:55:11 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2c0a75sm24312488f8f.25.2026.08.16.06.55.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 06:55:10 -0700 (PDT) From: Tristan Madani To: Tony Nguyen , Przemek Kitszel Cc: Grzegorz Nitka , Michal Swiatkowski , Andrew Lunn , "David S . Miller" , Jakub Kicinski , Eric Dumazet , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, stable@vger.kernel.org, Tristan Madani Subject: [PATCH net] ice: fix metadata_dst refcount handling on representor teardown Date: Sun, 16 Aug 2026 13:55:10 +0000 Message-ID: <20260816135510.1015041-1-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani ice_eswitch_release_repr() uses metadata_dst_free() to release the representor's metadata_dst. metadata_dst_free() directly frees the underlying memory without checking the dst_entry refcount. When ice_eswitch_port_start_xmit() processes a packet, it takes a reference via dst_hold() and attaches the metadata_dst to the skb. If the representor is torn down while packets are still queued on the lower device (e.g. in a qdisc), the metadata_dst is freed while references are still held. Use dst_release() instead, which correctly decrements the refcount and only frees the object when all references are dropped. The dst subsystem already handles metadata_dst cleanup in dst_destroy() when DST_METADATA is set. Other drivers sharing this pattern (nfp, airoha, bnxt) already use dst_release() for their metadata_dst lifecycle. Fixes: f5396b8a663f7 ("ice: switchdev slow path") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- drivers/net/ethernet/intel/ice/ice_eswitch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c index c30e27bbfe6e2..96174fca3984a 100644 --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c @@ -95,7 +95,7 @@ ice_eswitch_release_repr(struct ice_pf *pf, struct ice_repr *repr) return; ice_vsi_update_security(vsi, ice_vsi_ctx_set_antispoof); - metadata_dst_free(repr->dst); + dst_release(&repr->dst->dst); repr->dst = NULL; ice_fltr_add_mac_and_broadcast(vsi, repr->parent_mac, ICE_FWD_TO_VSI); -- 2.47.3