Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C30C3F7A9B for ; Mon, 17 Aug 2026 10:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963708; cv=none; b=K/XvUrE28RGUNf7iwsIF9NxXBv7ODcl4jLxmmpRklXVlt2knSLcybAC9SDCPoz0oX7eFwzSfUos41XiGAR8MDkGnNlazNr6fPL5+1aP5BT+VxWjv+VfNUwixDm+hrf+MsCWlB8S6IF382c3hnXwE93m3BOhTjsHO3nl5ulpza0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963708; c=relaxed/simple; bh=QNQGAQMvi98odGpNTyWdFaTAXKFmq6Y70G0q+N0VGr8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ME5BuGsdqqWiZ8U50fjYgR6Q27L176o8tPFoxYowoj7gIUE6/s6dqw/MnNyJlbgeABRrXuPtjtBkG2C6E7vU0FhtVIMxDM7j/lC/5aL9CBfRTqbxPQbk/Nc+LBd7+qqk18tK17oESN4apoOUzYNx1JJahtUOyRiqlDfhFFv2rF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bh8ZJT2A; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bh8ZJT2A" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5aebe49b227so610842e87.2 for ; Mon, 17 Aug 2026 03:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786963703; x=1787568503; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tufsylix9QRWdBSzfeQ8rMK41gi/ULWE3IKWJZ+mOhE=; b=bh8ZJT2AxW5xqd16OIIippJiBTQ+yzQBdLZ+ViYCzkLM6NZLofFRuV9Y+6ROjXLtMI arnhBG11bBiMUwMTdADiQZ+lHrpfLVzGGizN3jHmVgwdhHVEwAKoN0jtfNy2v+jJMsVe pwba4wXNAWvRz8/HmBH4ZoMN8QbTS31oO+EWA6l3nFOe1LbJ4X3TtIY38aZ+aE2GeBaX 6RSNawW8fvSiYIJ7488FxYh62Eno8gPUJ2ufU0SSvEqZcRmQvi1d87aJfd/jyg/DJwek ldW6tOKIxc7B4kf7T4z+vxi1yhug9VRJp318QR4jk0/qB4xp10nNKIW1eoCP8oJpmzC8 RhHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786963703; x=1787568503; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tufsylix9QRWdBSzfeQ8rMK41gi/ULWE3IKWJZ+mOhE=; b=XTkqbBrqd13wiWI925smctkEutTQ5R9CkLclipxrZz8y1pnxAie1LMcl8vV3WHz4/o li01KS7bnoseoLfxVTDwN/rBcc5phJJouNLUhr9rX5KgzWgkYtaqaioS8YV7ktF+fZnp jfzYaXUBXJtp/8hwVKR2+vD3kfLFFfUE1LfvHKq8I3tQFm114rZt2vzc5NFgsU+eNJ03 0CMVasN9B7CS9xSHaiMT3Laq9qY7RpISZti2z+W+ssTT6fh6tjJ5EZ8LSXXXqinsboo3 f92QqHVr2Z/kraJWEfu3dkSaX3mIHTSUgunZAJLhF5R0ckc/WOdPkE5nCw9wB5wCbeml ZVOg== X-Forwarded-Encrypted: i=1; AHgh+RqTQo8chRD/08E4POJ9pCy2o4eAhyal5IyuVxg13h7aH1YNjLyp/ZjbVDBf78vvMfh/bKTSiFH0Vx7XUw==@vger.kernel.org X-Gm-Message-State: AOJu0Yyw12dDiL2Yr7VoweMRSJrqCYulce/9Ad8YJi9a3EM5u2AmbtBm PPaEmS5B3TC7gjdXahDFER/sDuIiO0aqKiZmFIzGUvV7OjaiKysFA2OJ X-Gm-Gg: AR+sD12Nrz5smjDuFMUXRqChhzJlvGXGytqqmaibs0sl3bRwwNwo7oXwEhij5qIMuAC t7wCBdyZbeYcc8Vjl8ldHjBh4XusNRAknW4+efECOUslRdJPgABwVnKpfFA2C7RX+tL0l2Zrpj3 hKJ+EReEFe5lhW5kqjYZn2zgZSPrNDIiwzd73XlUkP8G2KyXpGJl8/Jx7kLKHC1j9KpCsGoSSLE Opj3LcTW801258EAyM2MoPUYx7PMggevy++x/y5mjxNUSpx75SlFoFEvtp+aYPcb1CGCCqDAFVi 3/PhuLHuosdqt9VslQO+sRKgsKIsMurJ0JXCORP4dElJ2eYZAQM9GBDNv771lXHJ70p3qnjlvmm QDtFntfMMtk6VSyTdbLvd6gUN3G9Fbe8DGhoHbKkBAFQL++KsEXifYjw21+92dmOklFEZuRIfby MhwQ/NXTLvAH/stu5vqWxQ6ABe0NT1doOH30ga8yM1svwhpfERiPy1ucqqmnGyjjAGe26w4QQOc v0= X-Received: by 2002:a2e:b88a:0:b0:38d:fae9:9aa2 with SMTP id 38308e7fff4ca-3a1323d6060mr18125041fa.1.1786963702959; Mon, 17 Aug 2026 03:48:22 -0700 (PDT) Received: from localhost.localdomain ([78.40.184.2]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a16b0a1ee9sm3129031fa.8.2026.08.17.03.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 03:48:22 -0700 (PDT) From: Dmitriy Okunev To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , Sasha Levin , lvc-project@linuxtesting.org, Chris Mason , David Sterba , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6.1] btrfs: fix root leak if its reloc root is unexpected in merge_reloc_roots() Date: Mon, 17 Aug 2026 13:48:12 +0300 Message-ID: <20260817104812.9200-1-dokunevdmitriy@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Filipe Manana commit ce6050bafb4e33377dc17fcc357736bfc351180c upstream. If we have an unexpected reloc_root for our root, we jump to the out label but never drop the reference we obtained for root, resulting in a leak. Add a missing btrfs_put_root() call. Fixes: 24213fa46c70 ("btrfs: do proper error handling in merge_reloc_roots") Reviewed-by: Qu Wenruo Reviewed-by: Johannes Thumshirn Signed-off-by: Filipe Manana Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Dmitriy Okunev --- fs/btrfs/relocation.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 43e8c331168e..d2a1323e8b10 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -1956,6 +1956,7 @@ void merge_reloc_roots(struct reloc_control *rc) * corruption, e.g. bad reloc tree key offset. */ ret = -EINVAL; + btrfs_put_root(root); goto out; } ret = merge_reloc_root(rc, root); -- 2.53.0