Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313932C1594; Mon, 17 Aug 2026 14:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975571; cv=none; b=VjdLj5DE42MjtlEHXZOK1ZE8NKZh3qAfJSb/ORhP/aLneSeBiFk8jMTryKh3B4nyQzteeVWCprRf4DB+qfXMogxrVWdTj1F46kE4Sx/05kvVWkOJdXJ8LNbU27cHMma3d/YxgvkguWxsBi2t01L5zxFUZP9UM1KApwrjZillN5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975571; c=relaxed/simple; bh=euRGdsFDjfb+G/oh5VLfnzjdx/OXRA+kdF690jx4Jp4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=loNIFpasFLbiT4Jrd8N51VLDawYgoa1XXu8S85XmiSnyPzMqB15YqThEEF6YSraWohLJK8x3fBRXZ31IWltFPWUcj70bnCt1kSf3NZ0bf39JqZZqfaSOyIJtFdiq6As3U/k7BoF8qYfvZMrYAC1VSyyRIvrLKWSH1ekDUbPW44Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=veqx5UTa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="veqx5UTa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89B501F000E9; Mon, 17 Aug 2026 14:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975570; bh=GRXxC38qX0h06TAphjdyr2GhVdl1g3SkHXSu9Hfj8uw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=veqx5UTaFVSC/3egB+bGZBIsjogr2ZWE+sRS8XOsmMhyjx136rogmHqSa936HhRIn RXUf1Ja0aI6c4l2J7hi3mx3ofjVsmOQHaHtVnihhEjudqRjVTjdBJYd0aOWgMFsaP/ gGTcTlVsLSqLZrOSIUpJmoXkRNQ+tafJNneaeuPU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tristan Madani , Jeff Johnson , Sasha Levin Subject: [PATCH 5.10 066/389] wifi: ath6kl: fix OOB read from firmware num_msg in TX complete handler Date: Mon, 17 Aug 2026 15:28:25 +0200 Message-ID: <20260817132541.670147399@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tristan Madani [ Upstream commit 3a21c89215cc18f1a97c5e5bfd1da6d4f3d44495 ] The firmware-controlled num_msg field (u8, 0-255) drives the loop in ath6kl_wmi_tx_complete_event_rx() without validation against the buffer length. This allows out-of-bounds reads of up to 1020 bytes past the WMI event buffer when the firmware sends an inflated num_msg. Add a check that the buffer is large enough to hold the fixed struct and the num_msg variable-length entries. Fixes: bdcd81707973 ("Add ath6kl cleaned up driver") Signed-off-by: Tristan Madani Link: https://patch.msgid.link/20260625232907.3620746-1-tristmd@gmail.com Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath6kl/wmi.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 5bacddee834491..b64e0034d69f01 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -484,6 +484,18 @@ static int ath6kl_wmi_tx_complete_event_rx(u8 *datap, int len) evt = (struct wmi_tx_complete_event *) datap; + if (len < sizeof(*evt)) { + ath6kl_dbg(ATH6KL_DBG_WMI, "tx complete: invalid len %d\n", + len); + return -EINVAL; + } + + if (len < sizeof(*evt) + evt->num_msg * sizeof(struct tx_complete_msg_v1)) { + ath6kl_dbg(ATH6KL_DBG_WMI, "tx complete: invalid len %d for %u msgs\n", + len, evt->num_msg); + return -EINVAL; + } + ath6kl_dbg(ATH6KL_DBG_WMI, "comp: %d %d %d\n", evt->num_msg, evt->msg_len, evt->msg_type); -- 2.53.0