Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 462DB439F9B; Mon, 17 Aug 2026 13:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974244; cv=none; b=Wf2J6pGmgVFpGUCNguF3B9lvYh0MFju+iKFMnD1swtPOfQKShy3tDkYUZHVT0mY6BQHmQuKfhLE9KuVaR39DthNf5GiK81xvjmAIWnDEvloZNtx5axsBHNO5iB5J4wWq1GU59eZ2nUajqp+T0GcC9a9GWNOLv6FvxsTrXqttyes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974244; c=relaxed/simple; bh=J/g0QiI/YGEaA+0TAWUDA9DwaLKwXVaNe0AiThlHiLA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MrwmgJTo24zbrX+KnDhHUGzU4KG9tDQev5XDaON4ac7Sp8OOTfk1vNjvAJQC/JfvXTiEtUNSN56ObIa1LQi3QC5s5h5FjYfMDgkNuzNtL12nMwBqILskWNEdjKl6VBQq+KvREFiLReSyP8qwzBfaBfnSrsnARkJxaWz1Cciq5u4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zrw+I5/5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zrw+I5/5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E2DC1F000E9; Mon, 17 Aug 2026 13:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786974241; bh=KRo1f6Fga/qbQp00z57DlC/ZI7MQ1acvjmjRQqulurU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=zrw+I5/5WJ/OBnIuKxCWFaQUfphc76S7MrDDhz7vz4zKBIPJHvSCXS7Scb4+vW8Iu hY2lhwuHBksNDrTYiv8ZHyE66MEAxxDL9yX0z1ZKTjb10XzzgJPJKh2m8I4JbgbanY xTK3mWCwWa6twes7sBKawplNnlZqzYTn/FR4BvMw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joshua Rogers , stable Subject: [PATCH 7.1 139/271] vt: stabilize tty reference in kbd_keycode with tty_port_tty_get Date: Mon, 17 Aug 2026 15:31:04 +0200 Message-ID: <20260817132542.568488115@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132536.752504388@linuxfoundation.org> References: <20260817132536.752504388@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joshua Rogers commit e25d47a526939ad44b75f778b8a7500562b84fc1 upstream. kbd_keycode() reads vc->port.tty without acquiring a tty reference, racing against con_shutdown() which clears port.tty under a different lock. Use tty_port_tty_get()/tty_kref_put() to hold a proper reference for the duration the tty pointer is needed. Assisted-by: AISLE:Snapshot Signed-off-by: Joshua Rogers Cc: stable Link: https://patch.msgid.link/20260731-tty-vt-stuff-v1-1-be99b9da8e30@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/tty/vt/keyboard.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/tty/vt/keyboard.c +++ b/drivers/tty/vt/keyboard.c @@ -1437,7 +1437,7 @@ static void kbd_keycode(unsigned int key struct keyboard_notifier_param param = { .vc = vc, .value = keycode, .down = down }; int rc; - tty = vc->port.tty; + tty = tty_port_tty_get(&vc->port); if (tty && (!tty->driver_data)) { /* No driver data? Strange. Okay we fix it then. */ @@ -1497,9 +1497,12 @@ static void kbd_keycode(unsigned int key * characters get aren't echoed locally. This makes key repeat * usable with slow applications and under heavy loads. */ + tty_kref_put(tty); return; } + tty_kref_put(tty); + param.shift = shift_final = (shift_state | kbd->slockstate) ^ kbd->lockstate; param.ledstate = kbd->ledflagstate; key_map = key_maps[shift_final];