Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B95E3E49E0; Mon, 17 Aug 2026 14:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975763; cv=none; b=ufKv977kjzDpMJFXSPD1sdAXHGLmVaXJ0qU0SArncS9QUt7f25oBffesbt+Fno4eDf6Gl1qUoZzFBvC0Pcaa3EwVfU33xKgmkLlQG8OdVzrvQCVKBoK1G0agH+ULClZ9e23ECm2QmZziAqbsXM04sw2oxQyrQny+Sq3kFEsFt3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975763; c=relaxed/simple; bh=g6Eouuz4+lbyPk9mnaEBBQchTCHUlkAxKPvjjZgPNpM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PsRH3Ej2hg+sTUS8ialK1LfCwSHejVwTITuUSaLDEelES6bf07I2C5rKnOHR8kyW1eddd66Ffl7MeKJGY8iS+quQOGlI0cBjw8J6XiLKScgPOBwTQcNnHO9WisgfRbEj8BsTfsZEufg+T8eze4EXPaJziMSPEW3xTeT22U2M/as= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=i73kgb4g; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="i73kgb4g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 008631F000E9; Mon, 17 Aug 2026 14:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975762; bh=bb1/bsEQj6B6ebQx9YNXi6R7C84EQsA0AQ3x+jH5t7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=i73kgb4gsJYHYaiJEXbq0ZtwozJ1QHkVU2S1goKskqvLV6WeLdwjkrzZgyUJo3FPt Iu1dkZntGhJRljthHv2Y83W2uT9a9RQIgna0XLMuQaYKTKjZlnzlyJuUnyu5CFWHIr CMenbuyq9BLGu7RH9fsGf0PEx6Gnw9COCTuEcDr4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Hans Verkuil Subject: [PATCH 5.10 139/389] media: vidtv: fix reference leak on failed device registration Date: Mon, 17 Aug 2026 15:29:38 +0200 Message-ID: <20260817132544.578074892@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li commit 9aa21e1549db8882ff77b691e7714153df21dff0 upstream. When platform_device_register() fails in vidtv_bridge_init(), the embedded struct device in vidtv_bridge_dev has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: vidtv_bridge_init() -> platform_device_register(&vidtv_bridge_dev) -> device_initialize(&vidtv_bridge_dev.dev) -> setup_pdev_dma_masks(&vidtv_bridge_dev) -> platform_device_add(&vidtv_bridge_dev) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/media/test-drivers/vidtv/vidtv_bridge.c +++ b/drivers/media/test-drivers/vidtv/vidtv_bridge.c @@ -562,8 +562,10 @@ static int __init vidtv_bridge_init(void int ret; ret = platform_device_register(&vidtv_bridge_dev); - if (ret) + if (ret) { + platform_device_put(&vidtv_bridge_dev); return ret; + } ret = platform_driver_register(&vidtv_bridge_driver); if (ret)