Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7EAC3EC82D; Mon, 17 Aug 2026 14:10:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975845; cv=none; b=DwRIo9U5zhaNvaVGYQlem0gsagz7tJYqOvkMB9VeILtag+wkXKyAp9hchYMgKi2Mnxsr0WAPYuZVSdeDjJtcZOmd1RUwpEvGqBF4wuwL/F4KHY0lcGzqCFg40KoaseRB67FyTVf9KgZUYihG78dlRuYEq0H+lP1UWWJXAW5Zob0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975845; c=relaxed/simple; bh=6v2z5jX1el4HNHFISbp6liTSAGtQphBECjVHMg9hLJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kUVAdS5OmQHJt6e6HkPeuMXDLkMtRPtUIvhHrdKzBmhWyOY358MMgUaartlAiwbOjJ1ZSURZ9M0mpQD7Rk6XA5m2CTwlgKT2MLyJMcYTSY4FTbsYxp/v5fVdx1GTBO+mHt1SkodOvyAI29kTO2ylTmUUIGcjUAmrySwg3tQw2cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=T1ixF9SP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="T1ixF9SP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC6071F000E9; Mon, 17 Aug 2026 14:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975844; bh=ABo2KqH4jePIaoL/DORLG7i6y5qrc/lPoLA92dAQzqg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=T1ixF9SP11uvyQ1eqsxeGquWXzn0r/LhAeyC4/8oWOYn8jAXLG4uesyMdukQgDIvm kHDuHoYKPHBCj2Vzh1TNky6io60uCRQihVrV0CGGPfVk8LRKriErQLbyPKpY7GEqHj tC668oSIGFfF3B8XpOLhOwWLJRhBYh/UCZKNf3Eg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Guangshuo Li , Johan Hovold Subject: [PATCH 5.10 151/389] intel_th: fix MSC output device reference leak Date: Mon, 17 Aug 2026 15:29:50 +0200 Message-ID: <20260817132545.082790343@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li commit 761b785a0cfbce43761227bc42a7f984f31f8921 upstream. intel_th_output_open() looks up the output device with bus_find_device_by_devt(), which returns the device with a reference that must be dropped after use. commit 95fc36a234da ("intel_th: fix device leak on output open()") attempted to drop the reference from intel_th_output_release(). However, a successful open replaces file->f_op with the output driver file operations before returning, so close runs the output driver release callback instead. For MSC outputs, close runs intel_th_msc_release(), which only removes the per-file iterator and does not drop the device reference taken by intel_th_output_open(). Consequently, every successful MSC output open leaks one device reference. Drop the device reference from intel_th_msc_release(), which is the release path actually used for MSC output files. Remove the now-unused intel_th_output_release() callback from intel_th_output_fops. Fixes: 95fc36a234da ("intel_th: fix device leak on output open()") Cc: stable Signed-off-by: Guangshuo Li Reviewed-by: Johan Hovold Link: https://patch.msgid.link/20260715070851.2077965-1-lgs201920130244@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/hwtracing/intel_th/core.c | 10 ---------- drivers/hwtracing/intel_th/msu.c | 2 ++ 2 files changed, 2 insertions(+), 10 deletions(-) --- a/drivers/hwtracing/intel_th/core.c +++ b/drivers/hwtracing/intel_th/core.c @@ -843,18 +843,8 @@ out_put_device: return err; } -static int intel_th_output_release(struct inode *inode, struct file *file) -{ - struct intel_th_device *thdev = file->private_data; - - put_device(&thdev->dev); - - return 0; -} - static const struct file_operations intel_th_output_fops = { .open = intel_th_output_open, - .release = intel_th_output_release, .llseek = noop_llseek, }; --- a/drivers/hwtracing/intel_th/msu.c +++ b/drivers/hwtracing/intel_th/msu.c @@ -1463,8 +1463,10 @@ static int intel_th_msc_release(struct i { struct msc_iter *iter = file->private_data; struct msc *msc = iter->msc; + struct intel_th_device *thdev = msc->thdev; msc_iter_remove(iter, msc); + put_device(&thdev->dev); return 0; }