Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45D433EC82D; Mon, 17 Aug 2026 14:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975831; cv=none; b=PBr1L4xQBYAChNkfJii0eFlnarpHHKcLTixi3dS0TSp/Lx4s/hx8YSKrlgTlj+00aQv2cRptZgOnSAE/2HmMWbPnq7LxQyJSmr8ZgC/Pp+uxAwU7OVasewWq3hZvfLX2dM03FAfWzVZ66+7Mst3RdfFhpESalW6NbwHlZJevSnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975831; c=relaxed/simple; bh=hPH949ZSfrTet5+dB+yUQCw7oG4XNrU0O1Giahm6hoc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hLXnGY7LetOnV0rHMV+CUrarr0Jkj+4CqLzrcFfnXnEiXKdX/dNGoU7VurhkEB3bVhlbCZHEQ9ebr9lF9bgjHJEHc8NvgRyfSW/TSWcf73+R7BV8djXYKbXPXIMBw309MYgde2Rvt2ScAs/NDU+0T0jzZnN4CHWsY+zdE7HrXbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AqvN2nXf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AqvN2nXf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 813981F00A3A; Mon, 17 Aug 2026 14:10:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975830; bh=osMcElta7teSUCX7Qt1t/gyPqWAmOJl1K9fG2x0QAPU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AqvN2nXfW7MZWqLE7lF/pJInkTh5ZxTVaThRgO6qnGIkeHNgu9k2VLPjh2ULlgUu8 Y9zG5NgOsMdrBH7VYrPvsXOhyMoL/zTVNYADC6E6bHDkt3ncP/xWICm3Ix20bMhKrV w3ASuWdnXiT9i7/P3rlmkv3gTyobsjgKaU1yB7a4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shuangpeng Bai , Alex Markuze , Ilya Dryomov Subject: [PATCH 5.10 164/389] libceph: refresh auth->authorizer_buf{,_len} after authorizer update Date: Mon, 17 Aug 2026 15:30:03 +0200 Message-ID: <20260817132545.577303857@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shuangpeng Bai commit 937d61f86d377a3aa578adae7a3dfcecdddf9d89 upstream. ceph_x_create_authorizer() caches au->buf->vec.iov_base and au->buf->vec.iov_len in struct ceph_auth_handshake. These cached values are then used by the messenger connect code when sending the authorizer. ceph_x_update_authorizer() can rebuild the authorizer when a newer service ticket is available. If the rebuilt authorizer no longer fits in the existing buffer, ceph_x_build_authorizer() drops its reference to au->buf and allocates a new one. If this is the final reference, ceph_buffer_put() frees the old ceph_buffer and its vec.iov_base, but auth->authorizer_buf still points at that freed memory. A subsequent msgr1 reconnect can therefore queue the stale pointer and trigger a KASAN slab-use-after-free in _copy_from_iter() while tcp_sendmsg() copies the authorizer. Refresh auth->authorizer_buf and auth->authorizer_buf_len after a successful authorizer rebuild so the messenger sends the current buffer. Cc: stable@vger.kernel.org Fixes: 0bed9b5c523d ("libceph: add update_authorizer auth method") Closes: https://lore.kernel.org/all/E378850E-106C-427B-A241-970EB2D054D7@gmail.com/ Signed-off-by: Shuangpeng Bai Reviewed-by: Alex Markuze Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- net/ceph/auth_x.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- a/net/ceph/auth_x.c +++ b/net/ceph/auth_x.c @@ -671,9 +671,16 @@ static int ceph_x_update_authorizer( au = (struct ceph_x_authorizer *)auth->authorizer; if (au->secret_id < th->secret_id) { + int ret; + dout("ceph_x_update_authorizer service %u secret %llu < %llu\n", au->service, au->secret_id, th->secret_id); - return ceph_x_build_authorizer(ac, th, au); + ret = ceph_x_build_authorizer(ac, th, au); + if (ret) + return ret; + + auth->authorizer_buf = au->buf->vec.iov_base; + auth->authorizer_buf_len = au->buf->vec.iov_len; } return 0; }