Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 941C2443A9D; Mon, 17 Aug 2026 14:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976009; cv=none; b=WpCM0KsEyNjf+H6CDK/tVqtgwAatfKFM2Y+wlJ7VNmb2T40Iv6JapkbEUOP1edBDeJ4eI6p5EZs7OlKkiueLHakYVdC+nceb36R1F1xbvHOxTXd/TXUBdRZpPG31BaTWIeMs3k7rmpk5JngdPMzRygA1k3TxpxnPqpKXJ7gOvbA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976009; c=relaxed/simple; bh=iZK2mllhIJApeF3Z+4Sz4s1mm8bpFJSGI+D5ZLH2J3k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gFna6evM+GZW7V3k9ry177ow9I52ckorSlV7+crHj74fu8FkMR5h9HrAP443UagAFoLGcyKM5ruGi4D6/a8b53903qFUPsacgzFKI5wPY7gsNoy0qiDj98cezEdC9Z116sYt/SuA6LpSfc5r8o/584qqIVv84vP2lO5mOdsjb+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SyTgRbqw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SyTgRbqw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E99941F000E9; Mon, 17 Aug 2026 14:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786976008; bh=sbzhDrmRtxATQvtp521XKjFapRPCqh3odXJTcgOGNPE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SyTgRbqwNU8xmyOhpghCCaTwDancwNybyBgYhfyvJP7gm5ErgijweCGxrh7IwSdPW g8uqmQjla86jfz9LDYbChB3YpECUjF3qwPvpFpzcbrBJ46Lp0bKH4Su/ODMBUrd1u4 +0n4TZsHxDQuMSSi7hlzdPBLQLl4V8se/Z1SKHTs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot@kernel.org, Luiz Angelo Daros de Luca , Guenter Roeck , Sasha Levin Subject: [PATCH 5.10 224/389] hwmon: (adt7470) Fix PWM auto temp state array and bounds check Date: Mon, 17 Aug 2026 15:31:03 +0200 Message-ID: <20260817132547.952535182@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Luiz Angelo Daros de Luca [ Upstream commit 92413f439d1ec5e55b73ede8d66a7b971cbd1ced ] In pwm_auto_temp_store(), the parsed user input was missing bounds checks, allowing values > 0xF to overflow into the adjacent channel's bits. Furthermore, the value was being incorrectly written to the pwm_automatic state array instead of pwm_auto_temp. Fix this by rejecting values > 0xF with -EINVAL, and assigning the value to the correct array only after a successful I2C write. Reported-by: sashiko-bot@kernel.org Closes: https://lore.kernel.org/all/20260727034932.0B7C41F000E9@smtp.kernel.org/#t Fixes: 6f9703d0be16 ("hwmon: add support for adt7470") Signed-off-by: Luiz Angelo Daros de Luca Link: https://lore.kernel.org/r/20260727-adt7470_fixes-v2-8-598e38a46ba6@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/adt7470.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/adt7470.c b/drivers/hwmon/adt7470.c index 274d38a9ba589..c8f6b9af0f139 100644 --- a/drivers/hwmon/adt7470.c +++ b/drivers/hwmon/adt7470.c @@ -1093,8 +1093,10 @@ static ssize_t pwm_auto_temp_store(struct device *dev, if (temp < 0) return temp; + if (temp > 0xF) + return -EINVAL; + mutex_lock(&data->lock); - data->pwm_automatic[attr->index] = temp; if (!(attr->index % 2)) { mask = 0xF0; @@ -1105,6 +1107,9 @@ static ssize_t pwm_auto_temp_store(struct device *dev, } err = regmap_update_bits(data->regmap, pwm_auto_reg, mask, val); + if (!err) + data->pwm_auto_temp[attr->index] = temp; + mutex_unlock(&data->lock); return err < 0 ? err : count; -- 2.53.0