Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A15F282F29; Mon, 17 Aug 2026 15:05:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786979154; cv=none; b=R0AYvTo5b12G4hStEnbh7S66t9/zpCFlPB0e1Rcw11nM87K8pLXwDv93YzUeXsMsK4G8/uf4zyRu0lzvUcLNX+8uiKvpYLRZBLynq3J4MwOW7dE8Ke+kPQchxf+X+8NHrahOYYh5VJrWbr8vgt+8TRg8tOIH6mRno0tQ2eFnX2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786979154; c=relaxed/simple; bh=EuYU7Iiei5jnRZjWm1TM8W/hdq8aSUt1wWD6M+8zgdY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P9T52JHBb6JzaQDs9DJAh6llnqIzab/A1MCsJH6cJbABX+aq9pSNo8HebzgyhA4wUmhN9s7B0FzdxAZZk1HB1Yid4WZ/Li+HnMD05wro/i+h8azSb+cAKsQGrFyZV27LCdygNnPEdgmznKgHhrL30I9eJ/Ylua72ZyxZwuv+ITA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GqreNWCb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GqreNWCb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62FEB1F000E9; Mon, 17 Aug 2026 15:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786979152; bh=btyfEroyHhSqDOXxmGRFbde5tYWP9OIVswVWOf6Es5c=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GqreNWCbDJ9E7a24JqfT6oRThrH46frjmM7oX+Rl1l21dqbIthBjktsvyX+UWm4AJ cxnoAagdJ3MbW1VG/EojYEG7v7wa8zXiiFvvS94CARLugC5LzuUGBZ05oW3h0DWLXq 8FKjYE4rqHkZxzlvSeh6q2i26T7S0PlGlOiLFjqM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Ioana Ciornei , Paolo Abeni , Sasha Levin Subject: [PATCH 6.1 127/609] dpaa2-eth: put MAC endpoint device on disconnect Date: Mon, 17 Aug 2026 15:27:03 +0200 Message-ID: <20260817132548.102853023@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132543.039278408@linuxfoundation.org> References: <20260817132543.039278408@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li [ Upstream commit b4b201cc93ff70150853aba03e14d314d1980ca0 ] fsl_mc_get_endpoint() returns the MAC endpoint device with a reference taken through device_find_child(). The Ethernet connect path stores that device in mac->mc_dev and keeps it for the lifetime of the connected MAC object. However, the disconnect path only disconnects and closes the MAC before freeing the dpaa2_mac object. It does not drop the endpoint device reference stored in mac->mc_dev, so every successful connect leaks that device reference when the MAC is later disconnected. Drop the endpoint device reference after closing the MAC and before freeing the dpaa2_mac object. Fixes: 719479230893 ("dpaa2-eth: add MAC/PHY support through phylink") Signed-off-by: Guangshuo Li Reviewed-by: Ioana Ciornei Reviewed-by: Ioana Ciornei Link: https://patch.msgid.link/20260708111738.750391-1-lgs201920130244@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index 6727e17fb5145e..bae533897f63f9 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -4502,6 +4502,7 @@ static void dpaa2_eth_disconnect_mac(struct dpaa2_eth_priv *priv) dpaa2_mac_disconnect(mac); dpaa2_mac_close(mac); + put_device(&mac->mc_dev->dev); kfree(mac); } -- 2.53.0