Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD3A92DC783; Mon, 17 Aug 2026 14:31:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977081; cv=none; b=FSKCMivyPi2Jg5eZhHFyoQ7G09dDOinV6/7Uxc2vzOm44ZmLDF7kQxa82JJ/h+vH4AnF25/PPVwNe9AuVPmiufpD8UVS2YGYnvZfFUVp098ysryxFShormDzheiD73Sscqkq1rP8RWe6CERC4ovJ8LoarUiqC7l1RcveHL7Q4cw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977081; c=relaxed/simple; bh=tkZfHHqlXguES54XLg8vwaCBe7tUuUlkgknKglsMDAI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vres7FFPSoNwi1BuvFPJSppMsRupsef75VtRLLqzHduYCouS60cQ5nZ18u36ZxB4ZRamRQ3b9XcD9+pGf1jA4gmFPLeu3FhT7dgxh4HnGHBKpKTaYelJ7YLLiTXt/A8Ga8sswHRzUR0Kv1rAyvxfxoOrkOHID55LhacbG1JXB7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RurjgiJz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RurjgiJz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F0DC1F000E9; Mon, 17 Aug 2026 14:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786977079; bh=aGPJl2zubeo5aqZhQjEeF96S/nwSloWxo9uuKaYpDZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RurjgiJzMWCDFNKX70VFt/pk8p/9LMQPH/7dNtYqUIo3zGfWtee4ynfRBsiF9VPLh sIefmRIofqeqEqwpWZ+mFAMCTRnz/Dqfa9VypHs0iixcnSSgPYdN3pAYQ2moSfjVJM LkkLxeELx1z6eqn5ha0WAfT6dX0yxIxElFF3cgjc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shuangpeng Bai , Alex Markuze , Ilya Dryomov Subject: [PATCH 5.15 205/456] libceph: refresh auth->authorizer_buf{,_len} after authorizer update Date: Mon, 17 Aug 2026 15:29:55 +0200 Message-ID: <20260817132548.154651598@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132539.792407575@linuxfoundation.org> References: <20260817132539.792407575@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shuangpeng Bai commit 937d61f86d377a3aa578adae7a3dfcecdddf9d89 upstream. ceph_x_create_authorizer() caches au->buf->vec.iov_base and au->buf->vec.iov_len in struct ceph_auth_handshake. These cached values are then used by the messenger connect code when sending the authorizer. ceph_x_update_authorizer() can rebuild the authorizer when a newer service ticket is available. If the rebuilt authorizer no longer fits in the existing buffer, ceph_x_build_authorizer() drops its reference to au->buf and allocates a new one. If this is the final reference, ceph_buffer_put() frees the old ceph_buffer and its vec.iov_base, but auth->authorizer_buf still points at that freed memory. A subsequent msgr1 reconnect can therefore queue the stale pointer and trigger a KASAN slab-use-after-free in _copy_from_iter() while tcp_sendmsg() copies the authorizer. Refresh auth->authorizer_buf and auth->authorizer_buf_len after a successful authorizer rebuild so the messenger sends the current buffer. Cc: stable@vger.kernel.org Fixes: 0bed9b5c523d ("libceph: add update_authorizer auth method") Closes: https://lore.kernel.org/all/E378850E-106C-427B-A241-970EB2D054D7@gmail.com/ Signed-off-by: Shuangpeng Bai Reviewed-by: Alex Markuze Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- net/ceph/auth_x.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- a/net/ceph/auth_x.c +++ b/net/ceph/auth_x.c @@ -781,9 +781,16 @@ static int ceph_x_update_authorizer( au = (struct ceph_x_authorizer *)auth->authorizer; if (au->secret_id < th->secret_id) { + int ret; + dout("ceph_x_update_authorizer service %u secret %llu < %llu\n", au->service, au->secret_id, th->secret_id); - return ceph_x_build_authorizer(ac, th, au); + ret = ceph_x_build_authorizer(ac, th, au); + if (ret) + return ret; + + auth->authorizer_buf = au->buf->vec.iov_base; + auth->authorizer_buf_len = au->buf->vec.iov_len; } return 0; }