Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39BB423BCEE; Mon, 17 Aug 2026 14:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976326; cv=none; b=iAU4NF75zZnCE7z+ZRHoNb9vThNhLSVEz/Qphjq3EH2xcB5bo0eq6dYA8UESqnoM86MIMXmJ7sZbd992NaragbDrnCcjL0FH5sHBKeAuru9nGJuG3/vmV7/mKGZa/V3GOTjJxp9YVXIGhqeKgjmyX6XA4LIdRnP8M8KWygIrGqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976326; c=relaxed/simple; bh=uqlIPRb/+tdeyIAGVHu5kHMSsZKs/Atijef49rdAjAQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dePVYVqD6bDMhdDwiiycuiRt5+NFYLeWk6Uo+VlmjbPUsiYbL9th8EQWcQXuUB+BcfGM87JgOwSlj2NBz4pmVJyarrjLQ1aGTI3XziX9lr0Nuvm/Da5EOaNYFvAENyeGPk4LA8mOJgHjTKFFFxhE3cjX2uBPyMVksIz4cVVLo2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rCP0Ii4/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rCP0Ii4/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92C3E1F00A3A; Mon, 17 Aug 2026 14:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786976325; bh=gSLKIcthpFp1YcWHumXGhqROI6GEYF1Mg2clnOLP8mU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rCP0Ii4//Fg6MXCpcA2ZQthJ0zgtwqSTnsL8Uj0A7VQCo2vd52iY5dh2cg9WRMnIt eB+r25Q/2M8JozVL+l+9TBLNENDFFXT8T/9y6TEFm8Pvj1kNo/7pq5IEabs5QpfbiL nwY2EgiE868NV/3DFHhxUygZwO67rtbYT1aLjYU4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hongyan Xu , Niklas Cassel , Damien Le Moal , Sasha Levin Subject: [PATCH 5.10 335/389] ata: pata_sl82c105: fix bridge revision use-after-free Date: Mon, 17 Aug 2026 15:32:54 +0200 Message-ID: <20260817132551.932201968@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hongyan Xu [ Upstream commit 7700a31039cdc6715cb6cce7e7a664ee4e945f67 ] pci_get_slot() returns a referenced PCI device. Commit 44c10138fd4b ("PCI: Change all drivers to use pci_device->revision") replaced a configuration-space read with direct access to the cached revision field, but left that access after pci_dev_put(). The bridge may therefore be freed before its revision is read. Read the revision before dropping the reference. Fixes: 44c10138fd4b ("PCI: Change all drivers to use pci_device->revision") Signed-off-by: Hongyan Xu Reviewed-by: Niklas Cassel Signed-off-by: Damien Le Moal Signed-off-by: Sasha Levin --- drivers/ata/pata_sl82c105.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_sl82c105.c b/drivers/ata/pata_sl82c105.c index ac7ddd87f188d..78275b2479df2 100644 --- a/drivers/ata/pata_sl82c105.c +++ b/drivers/ata/pata_sl82c105.c @@ -265,6 +265,7 @@ static struct ata_port_operations sl82c105_port_ops = { static int sl82c105_bridge_revision(struct pci_dev *pdev) { struct pci_dev *bridge; + u8 revision; /* * The bridge should be part of the same device, but function 0. @@ -286,8 +287,9 @@ static int sl82c105_bridge_revision(struct pci_dev *pdev) /* * We need to find function 0's revision, not function 1 */ + revision = bridge->revision; pci_dev_put(bridge); - return bridge->revision; + return revision; } static void sl82c105_fixup(struct pci_dev *pdev) -- 2.53.0