Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6A3F4483A1; Mon, 17 Aug 2026 15:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786981788; cv=none; b=BKARmLDFGPFttJReeh9/IzrSEvCCYwHkQ54QNj2xrh3AVu3rIZ8F55d0l1P7DDri2upUKKAyBxR9gYL6mT2MkJjLaWrHJl2yXvO4ygkoHwnLjNWDg6av5pGwyqpX9f5GbecdUzm4mMHDls8qtKDco3NTpUEMMwaqWWvnnR89ESA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786981788; c=relaxed/simple; bh=qfGFrf+m965QAylQ28O+0DQaW/0DMM/vFICdb1ebuDM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MPygG0doqTjNHJagpvdqjnoKuPI7iIPWhDJ3XxczboeFkC4GrUKRrVAFbrIcVfQuaR0MlUR/Iaf2snLUwB4JUc9fD3tNbRPypAItX+bcM89/+XHmlDkdCy/dpgwUBBSA4ak5FsVQ4ZaF9lhP6K67Xg9wTEhPgTTtWgLHzss9VmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OGDni2sY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OGDni2sY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48B461F000E9; Mon, 17 Aug 2026 15:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786981783; bh=rUJNzPZZcZrC6RAsNhDo79F7r0V6hGeiGDwpX05FuUE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OGDni2sYMJ5sYRJ6ZpjjvwT6M4TD7vcpyTX/wLogiMcoRhhnJenMg9Nu1l+TdIxWV z/TBlRIwhuq3D5wnpP+bFBvBLdIX+/rHXCWOKqV4FCXTljLfL9CprxUvnsAYfo+B0y AMv5gGUoVIN/gQHVwn/Dv9rnM4VgLNeXG4rLm5hM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@vger.kernel.org, Tze Yee Ng , Dinh Nguyen , Sasha Levin Subject: [PATCH 6.1 481/609] firmware: stratix10-svc: fix memory leaks and list corruption bugs Date: Mon, 17 Aug 2026 15:32:57 +0200 Message-ID: <20260817132600.034616524@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132543.039278408@linuxfoundation.org> References: <20260817132543.039278408@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tze Yee Ng [ Upstream commit 9119ceb76e987c2ec2b549ea100e3268ce3a1c7c ] Fix a memory leak when gen_pool_alloc() fails by freeing pmem on the error path. Switch pmem allocation from devm_kzalloc() to kzalloc() with explicit kfree() in the free path to match its list-managed lifetime. Remove the erroneous list_del(&svc_data_mem) which corrupted the list head on failed lookups. Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") Cc: stable@vger.kernel.org#5.0+ Signed-off-by: Tze Yee Ng Signed-off-by: Dinh Nguyen (cherry picked from commit 9119ceb76e987c2ec2b549ea100e3268ce3a1c7c) Signed-off-by: Sasha Levin --- drivers/firmware/stratix10-svc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c index b25d793805ce0..c4a709f2bbc7a 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -1065,14 +1065,16 @@ void *stratix10_svc_allocate_memory(struct stratix10_svc_chan *chan, struct gen_pool *genpool = chan->ctrl->genpool; size_t s = roundup(size, 1 << genpool->min_alloc_order); - pmem = devm_kzalloc(chan->ctrl->dev, sizeof(*pmem), GFP_KERNEL); + pmem = kzalloc(sizeof(*pmem), GFP_KERNEL); if (!pmem) return ERR_PTR(-ENOMEM); guard(mutex)(&svc_mem_lock); va = gen_pool_alloc(genpool, s); - if (!va) + if (!va) { + kfree(pmem); return ERR_PTR(-ENOMEM); + } memset((void *)va, 0, s); pa = gen_pool_virt_to_phys(genpool, va); @@ -1098,6 +1100,7 @@ EXPORT_SYMBOL_GPL(stratix10_svc_allocate_memory); void stratix10_svc_free_memory(struct stratix10_svc_chan *chan, void *kaddr) { struct stratix10_svc_data_mem *pmem; + guard(mutex)(&svc_mem_lock); list_for_each_entry(pmem, &svc_data_mem, node) @@ -1106,10 +1109,9 @@ void stratix10_svc_free_memory(struct stratix10_svc_chan *chan, void *kaddr) (unsigned long)kaddr, pmem->size); pmem->vaddr = NULL; list_del(&pmem->node); + kfree(pmem); return; } - - list_del(&svc_data_mem); } EXPORT_SYMBOL_GPL(stratix10_svc_free_memory); -- 2.53.0