Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B60743B498; Mon, 17 Aug 2026 15:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786980229; cv=none; b=Mh9nfjF5UnrLzZz8CWLTBsPxlqLRtxTrxR6Jw7nc3Rh8jblq5jGfwuAJxHavoiyTpHE6JkzE+WWgQAY8WpQ3aTRI8DAG5Mc9C0/itBdQzlbVVaT0cfoqNzpgcSPErboqwy1mHEiRzh048qZYprFUmoJ7vUnLFhno9IcgWkMFF5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786980229; c=relaxed/simple; bh=eiGt4+/jKp2HQAz+gA2NBeVWIUTKKA1uAQ9z0liAmS4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NedOuIVh6nHLjrVNIa0WQuUT7vxtKhk5aiJ5RCWg9mut2n2mvm4LurDsTIHaX0HeOjk+EmZYMHJS1jFoGo4OZueBi7i2/R3NokVSlMaa3ldzTAKYOjf04kDzzHBSbatIWa/UDJ5QRl0zbgXAHjOQp+BwAr33SqD3ljr0wB2aVnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IX9Z4JPH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IX9Z4JPH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E21C51F00A3A; Mon, 17 Aug 2026 15:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786980228; bh=fOJX9xDvlsAPmnhR+gX/9oQfmPxb+mhjFAoslLLSPC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IX9Z4JPH5/H5dCUjW2r3Fgnmw7yQo4JTYWdtJxAZUUHhvfT+kkieEGXoxp7evYRrk j8Rh/wehp670jG49yeCawQIq458twgpWQahXLmrpOiEjlGLrk2LaLzDY1lWXhOh5bG 6uy2tmsIvu3xHd8diRHVKtp5wAfRCH3VxD5RPbik= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Babanpreet Singh , Joshua Crofts , William Breathitt Gray , Sasha Levin Subject: [PATCH 6.1 501/609] counter: microchip-tcb-capture: Fix DT channel validation Date: Mon, 17 Aug 2026 15:33:17 +0200 Message-ID: <20260817132600.649483111@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132543.039278408@linuxfoundation.org> References: <20260817132543.039278408@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Babanpreet Singh [ Upstream commit f1a3a9946aab611dd2200c01ff122f64b033dad2 ] mchp_tc_probe() reads the devicetree "reg" cell - a u32, per the API contract of of_property_read_u32_index() - into a signed int, so the bounds check "channel > 2" fails to reject cell values at or above 0x80000000: reinterpreted as a negative int, they compare below 2 and pass validation. A malformed devicetree can therefore drive a negative channel into the ATMEL_TC_REG() offset arithmetic, making the driver access syscon regmap offsets outside the TC block's register window, and into the "t%d_clk" clock-name formatting, where it truncates clk_name (sized for "t0_clk".."t2_clk"). Declare channel as u32, matching the API contract; the unsigned comparison then rejects everything except channels 0..2. Adjust the format specifier to %u accordingly, which also resolves the W=1 warning that exposed the gap: microchip-tcb-capture.c:520:56: warning: '%d' directive output may be truncated writing between 1 and 11 bytes into a region of size 6 [-Wformat-truncation=] note: directive argument in the range [-2147483648, 2] No behavior change for well-formed devicetrees: channels 0..2 take identical paths before and after. Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") Assisted-by: Claude:claude-fable-5 [gcc W=1] Signed-off-by: Babanpreet Singh Reviewed-by: Joshua Crofts Link: https://lore.kernel.org/r/20260714042910.7-1-bbnpreetsingh@gmail.com Signed-off-by: William Breathitt Gray Signed-off-by: Sasha Levin --- drivers/counter/microchip-tcb-capture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c index 2f631729a870b..f2cd7b599e44e 100644 --- a/drivers/counter/microchip-tcb-capture.c +++ b/drivers/counter/microchip-tcb-capture.c @@ -310,7 +310,7 @@ static int mchp_tc_probe(struct platform_device *pdev) char clk_name[7]; struct regmap *regmap; struct clk *clk[3]; - int channel; + u32 channel; int ret, i; counter = devm_counter_alloc(&pdev->dev, sizeof(*priv)); @@ -344,7 +344,7 @@ static int mchp_tc_probe(struct platform_device *pdev) priv->channel[i] = channel; - snprintf(clk_name, sizeof(clk_name), "t%d_clk", channel); + snprintf(clk_name, sizeof(clk_name), "t%u_clk", channel); clk[i] = of_clk_get_by_name(np->parent, clk_name); if (IS_ERR(clk[i])) { -- 2.53.0