Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A64C2DB7B7 for ; Thu, 20 Aug 2026 13:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787234000; cv=none; b=YSW/oi7bzNbQ/Y72I1pC8W+lup9yIv7iPS5vMh8oDesk9Nwnb1ab/Pc/BecbTWqen4ejbFqc7DAU2apFW9iwuLFT4UuHcNNhx+ECZ7YG/ZXncwf4Gt8lRNlc4WdQE1jlVtp2sBbOU6v38+V93qyC/SrkimkOWu/UCw9TXVuV3F0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787234000; c=relaxed/simple; bh=b3zAU1q7PUK6Wmrp/g7K1KzpiAlymaSaXbWk7th1ZrM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tchE7LH98WKxjSAFvAYxNFO/XTJiT2gnIhOr+mUTZcSHXDACXRbXCTYUrFTQrFqIY/OOoDBIxLJzLx7C21e781krEgGNXOK4TcnsJEwRB8EkKwgXCDdfAbuQyAS/ZwguFSGWOhV9dNnxp4PYTMkulkUjMFQqEqoPWiPH9PXoEsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UI9e0z4W; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UI9e0z4W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18DB31F00A3F; Thu, 20 Aug 2026 13:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787233998; bh=S9BNNpsyQguFKMbKI5BFUcJN6Wg8f3MhHOaGE1a7T4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UI9e0z4WB3xwWcBsuT27ex+jK7jZFP6K2hNa613zqZSeyeHh7hEJuXDWYpUoYeej/ AJgioLbGgVWKIICn76dUrVjgjHTMy0gz9hEdaXYwuCq9mTkoexTEMd4VN1uviU/GKm OAAJMjCATwEQonLfbWp2AgC0Nrh4uH9XibZq/Lw37VtTgW0Vo4vFWNol+KCzb51Utl DZsimIxHed/c8jFbtGr50xu0JRfPH8rmJBxy3IOvnhNUhKOEON1QlcYgsbMzBLUKwz ZYyb1RbM2D698W8q84hdkT8XQff8EGSAfVOfeLGWb8FcdmWaEZlfpx3EMx01ombpqx IJe95XBudoJvQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Daming Li , Vega , Xiao Liu , Ren Wei , Dust Li , Sidraya Jayagond , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10.y 2/2] net: smc: fix splice entry lifetime imbalance in smc_rx_splice Date: Thu, 20 Aug 2026 09:53:14 -0400 Message-ID: <20260820135314.1705359-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260820135314.1705359-1-sashal@kernel.org> References: <2026081711-stamina-rebuttal-bfcf@gregkh> <20260820135314.1705359-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Daming Li [ Upstream commit 5d9686af2976741bbd79b150d1c9e60b81e7f12e ] smc_rx_splice() passes pages to splice_to_pipe() before taking the references that cover the lifetime of each splice entry. In the VM-backed RMB path, splice_to_pipe() may drop unqueued entries through smc_rx_spd_release(), while queued entries are released later via the pipe buffer callback. The old post-splice accounting also derives the number of queued VM pages from an offset mutated while building the descriptor, and a multi-page splice pairs one sock_hold() with multiple sock_put() calls. Take the page and socket references for every candidate entry before splice_to_pipe(), and drop the matching private state, page reference, and socket reference from smc_rx_spd_release() for entries that never get queued. This fixes a refcount imbalance that can underflow page refcounts and trigger a use-after-free. Fixes: 9014db202cb7 ("smc: add support for splice()") Cc: stable@vger.kernel.org Reported-by: Vega Co-developed-by: Xiao Liu Signed-off-by: Xiao Liu Signed-off-by: Daming Li Signed-off-by: Ren Wei Reviewed-by: Dust Li Reviewed-by: Sidraya Jayagond Link: https://patch.msgid.link/20260730145552.360287-2-enjou1224z@gmail.com Signed-off-by: Jakub Kicinski [ collapsed the multi-page get_page()/sock_hold() loop to a single get_page()/sock_hold() pair and dropped the trailing kfree() calls, as 5.15 lacks the multi-page pages[]/partial[]/priv[] arrays ] Signed-off-by: Sasha Levin --- net/smc/smc_rx.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/net/smc/smc_rx.c b/net/smc/smc_rx.c index 0845905520f8c..343bdab3b5077 100644 --- a/net/smc/smc_rx.c +++ b/net/smc/smc_rx.c @@ -144,7 +144,12 @@ static const struct pipe_buf_operations smc_pipe_ops = { static void smc_rx_spd_release(struct splice_pipe_desc *spd, unsigned int i) { + struct smc_spd_priv *priv = (struct smc_spd_priv *)spd->partial[i].private; + struct sock *sk = &priv->smc->sk; + + kfree(priv); put_page(spd->pages[i]); + sock_put(sk); } static int smc_rx_splice(struct pipe_inode_info *pipe, char *src, size_t len, @@ -164,6 +169,8 @@ static int smc_rx_splice(struct pipe_inode_info *pipe, char *src, size_t len, partial.len = len; partial.private = (unsigned long)priv; + get_page(smc->conn.rmb_desc->pages); + sock_hold(&smc->sk); spd.nr_pages_max = 1; spd.nr_pages = 1; spd.pages = &smc->conn.rmb_desc->pages; @@ -172,11 +179,8 @@ static int smc_rx_splice(struct pipe_inode_info *pipe, char *src, size_t len, spd.spd_release = smc_rx_spd_release; bytes = splice_to_pipe(pipe, &spd); - if (bytes > 0) { - sock_hold(&smc->sk); - get_page(smc->conn.rmb_desc->pages); + if (bytes > 0) atomic_add(bytes, &smc->conn.splice_pending); - } return bytes; } -- 2.53.0