Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE1E4195C0; Thu, 20 Aug 2026 16:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244024; cv=none; b=nR3TYps1WY5J4ZOxNyABYxl5wQD6MhYeKOYQ3j+Nbu+nTxiUGJTFEN9rIcccOQSqAIuD+HVpK5kc0No+d8m4M6WrMoni9Lc2DyDB+a4+bDSrvWAWO1tpbgSj8CELXXA/Avz6HQYRQO+aOiTTje/YSkyi/nfgeJ/TVagE6hL/WwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244024; c=relaxed/simple; bh=0Z+1HOCk0J2AXRf6T58CKw1nXLripbs0VaDLh5NyHC4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AlKiJ/HV/2s/r9RWvcZQyohr3P9uv8+tms6OjYzJhAvo/9y8lF3eOnC5IQmmFXgEMqrBh1X+xJ2AN64fXP43ZSfdLF2irqsDcQL3MYcmlnUFX7M8/ARmJvfa9RsQqlP7dGT+09/CVio3fmo/FrbfYaxQt+02lqQnvdbu+hVeEoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YvW9tSBd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YvW9tSBd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B68581F000E9; Thu, 20 Aug 2026 16:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787244023; bh=r05UfiICQEHq2TQjKhFgwThmkC8aT+jhHmNsY6nHXz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YvW9tSBduVXBz8nx4HhR7QVzfya/iTmlGfryoYNeFFUH1m1EfI1heBVeWXtvMEKWx V598TyWm2AjWXzTGHuNe/nzTFbs56Lh5q01f+TSU3bWnxoDdcimM4YzgUIFK6XIZ+U IM8DxAE3sSsSzc2/OaiLWNMZfqfS2twKf51Ux8k8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot@kernel.org, Dmitry Torokhov Subject: [PATCH 5.10 026/235] Input: sur40 - fix V4L error path cleanup Date: Thu, 20 Aug 2026 16:54:22 +0200 Message-ID: <20260820145217.231717499@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145216.426568665@linuxfoundation.org> References: <20260820145216.426568665@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Torokhov commit 062dc4693e2c10d77de06f61e6f3faf37c0a8383 upstream. In sur40_probe(), if video_register_device() fails, the error path jumps to err_unreg_video. This incorrectly attempts to unregister a video device that was never successfully registered, and fails to free the V4L2 control handler (v4l2_ctrl_handler_free) that was initialized immediately prior. Fix this by introducing an err_free_ctrl label to properly free the V4L2 control handler and bypass video_unregister_device() when video device registration fails. Reported-by: sashiko-bot@kernel.org Cc: stable@vger.kernel.org Assisted-by: Antigravity:gemini-3.5-flash Link: https://patch.msgid.link/20260616051235.1549517-2-dmitry.torokhov@gmail.com Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/touchscreen/sur40.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/touchscreen/sur40.c @@ -787,7 +787,7 @@ static int sur40_probe(struct usb_interf if (error) { dev_err(&interface->dev, "Unable to register video subdevice."); - goto err_unreg_video; + goto err_free_ctrl; } /* register the polled input device */ @@ -806,6 +806,8 @@ static int sur40_probe(struct usb_interf err_unreg_video: video_unregister_device(&sur40->vdev); +err_free_ctrl: + v4l2_ctrl_handler_free(&sur40->hdl); err_unreg_v4l2: v4l2_device_unregister(&sur40->v4l2); err_free_buffer: