Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 896C8272E53; Thu, 20 Aug 2026 16:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244041; cv=none; b=fc5ac7jTK78gb+pkEUPHDwL6wKThNGgWId1D/SRjLxA+qmOKQ6KE79BoSJ8ZDIrHb7GBjj9uUiCzeWbrCNOiO1+s53cobQDeGYPm/b/8bCZmWw05GEJ2cWhxzyiDF1q2l9bHjSrXyb94xaVYZxjr4NT3iru1jT7ng3CYjSZL7N0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244041; c=relaxed/simple; bh=PFp6i3ZGesVCu3VpeOM7Llwi+90njseKWtMTJWUT318=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qD1xZXRJxIe7fhGxqa4GRJzZDfCvFQ52J57azmNd1JDpDEDN1uMQEShHtbc2uVqFujgdmuoLVew/T3lxXzpKw3Bb58xlwAAlXryfadwUcE+0V8gh9/wMdR0PK0WTjTN63fbzYje9+X1FMX+HH8XtXdriiXxWkVKC1lwBIsCRZyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dBidjFCm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dBidjFCm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4E161F000E9; Thu, 20 Aug 2026 16:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787244040; bh=obPos4W7iMlAUwSNNqkVuWgEBLT59oYYyejDaexVNd0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dBidjFCmBpr+H9+f7okHR5KBI6KHEiSMfwEdoSizxBGXPK+KnwPXMqa4VKUF8falW /N5Ou/z4Y8uM5K4J6DVz0Z4UkHk4LDTNwTGBZ471Jf5I4o7XQu7RthaOWCPd9YPVsl jIECYFQNEGCC6bbaDm7bCmDaAJQioa+dbHrk7Fho= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haibo Chen , Frank Li , Ulf Hansson Subject: [PATCH 5.10 031/235] mmc: sdhci: make tuning_err a signed int Date: Thu, 20 Aug 2026 16:54:27 +0200 Message-ID: <20260820145217.380272223@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145216.426568665@linuxfoundation.org> References: <20260820145216.426568665@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haibo Chen commit ae31bcc92bb42502bb7c9029e6dc7a824cf6cd14 upstream. Coverity report INTEGER_OVERFLOW for host->tuning_err. The tuning_err field in struct sdhci_host is used to store an error code for re-tuning, but it was declared as unsigned int. Several call sites store negative error codes into it and later compare against negative values: - sdhci.c, sdhci-of-dwcmshc.c and sdhci-pci-gli.c assign it the return value of __sdhci_execute_tuning()/__sdhci_execute_tuning_9750(), both of which return a signed int (possibly a negative errno); - sdhci-of-esdhc.c assigns host->tuning_err = -EAGAIN and later does "ret = host->tuning_err; if (ret == -EAGAIN ...)"; - sdhci-of-dwcmshc.c prints it with the %d (signed) conversion. Storing a negative errno in an unsigned int and reading it back as a signed int only happens to work because of two's-complement, same-width integer conversions. It is misleading and triggers sign-conversion warnings. All users treat the value either as a signed error code or as a boolean (zero / non-zero), so changing the type to a signed int is safe and makes the intent explicit. Fixes: 7d8bb1f46e13 ("mmc: sdhci: add tuning error codes") Assisted-by: Cline:claude-sonnet [read_file, search_files, git] Signed-off-by: Haibo Chen Reviewed-by: Frank Li Cc: stable@vger.kernel.org Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/sdhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -594,7 +594,7 @@ struct sdhci_host { unsigned int tuning_count; /* Timer count for re-tuning */ unsigned int tuning_mode; /* Re-tuning mode supported by host */ - unsigned int tuning_err; /* Error code for re-tuning */ + int tuning_err; /* Error code for re-tuning */ #define SDHCI_TUNING_MODE_1 0 #define SDHCI_TUNING_MODE_2 1 #define SDHCI_TUNING_MODE_3 2