Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45B5147ECF6; Thu, 20 Aug 2026 16:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244638; cv=none; b=dwp8OtcMKi7eBwl7VZs2txIDRssO1TszDFNQeksKy8xv3RkXp3RKjeyHYN5SEGBXDQ+Q+lhMBS/d6bU8Xqy32b9Y7RQ2UkW+L34sf0btFa5b1MjimI5lnZVeCUupVy3eoPSRox9VP2SwgWYomS6qG//DqnVZwHM+YIC6Ww53vLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244638; c=relaxed/simple; bh=NH2OKnNBl2hH0Ex438KWZbEM6VO27ds4nsFL0nj63gk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=se1baBfLbVo+6s03fhbEkt1U7uCjqHmPIXyOpLUygwaoWyrtYcT6cwUq09UA1Xl+ZkmEhhKdFfvt/TQFph5YbpCksNarPZodpwQVjY9NvFOich0+YbG+sap2tDALswK5aS16JsIAmHETdlf47OT9oCvGmTOzm0qteAUcuzmYv+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lmMI39FE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lmMI39FE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4E781F00ACA; Thu, 20 Aug 2026 16:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787244637; bh=p/W9KmF0GOQvVVzRuyv73ykcreULb5dWQfUTOfqVdFU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lmMI39FE+q+acI+0b3ndnVrYsqKfh7U7mp1QykCrFkrI1pl4ZRyxMoSu8hMWYlTJk Fs7YG1TcowCdHXrns2sNLdPiBv/R6kW68i5taQGzhmYzaoqhy2gAid9BuD3RKKbdBL ZC46GFyAKjY/M9TYiLHTEbMBhG8tnB1t/pmYCpOc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+30b93b6845b19cc38581@syzkaller.appspotmail.com, Eric Dumazet , Willem de Bruijn , Jiayuan Chen , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 224/235] af_packet: Dont send zero-byte data in tpacket_snd(). Date: Thu, 20 Aug 2026 16:57:40 +0200 Message-ID: <20260820145223.407813015@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145216.426568665@linuxfoundation.org> References: <20260820145216.426568665@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 6bcd76c134c55c697148acb5c0194e9666abdf84 ] syzbot reported a WARNING in __dev_queue_xmit() triggered via tpacket_snd(): skb_assert_len WARNING: at include/linux/skbuff.h:2753 skb_assert_len WARNING: at __dev_queue_xmit+0x21bc/0x4970 net/core/dev.c:4781 Call Trace: dev_queue_xmit include/linux/netdevice.h:3448 [inline] packet_xmit+0x243/0x310 net/packet/af_packet.c:276 tpacket_snd net/packet/af_packet.c:2907 [inline] packet_sendmsg+0x28d6/0x4eb0 net/packet/af_packet.c:3134 When sending 0-byte packets via TPACKET ring buffer on devices with no hard header (e.g. dev->hard_header_len == 0), tpacket_fill_skb() populates an skb with skb->len == 0 and returns 0. tpacket_snd() then forwards this empty skb to packet_xmit(), causing __dev_queue_xmit() to hit skb_assert_len(skb). Similar checks exist in packet_snd() via commit dc633700f00f ("net/af_packet: check len when min_header_len equals to 0") and in packet_sendmsg_spkt() via commit 6a341729fb31 ("af_packet: Don't send zero-byte data in packet_sendmsg_spkt()."). Return -EINVAL in tpacket_fill_skb() when skb->len is zero to reject zero-length packets in tpacket_snd(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: syzbot+30b93b6845b19cc38581@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/6a79e807.01d0871a.3a0d52.00ac.GAE@google.com/T/#u Signed-off-by: Eric Dumazet Reviewed-by: Willem de Bruijn Reviewed-by: Jiayuan Chen Link: https://patch.msgid.link/20260810150447.1220864-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/packet/af_packet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 8d70d3550b7f5..b040b20b5e920 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -2649,6 +2649,9 @@ static int tpacket_fill_skb(struct packet_sock *po, struct sk_buff *skb, len = ((to_write > len_max) ? len_max : to_write); } + if (unlikely(!skb->len)) + return -EINVAL; + packet_parse_headers(skb, sock); return tp_len; -- 2.53.0