Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88E6746D0BD; Thu, 20 Aug 2026 16:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243387; cv=none; b=fRxc6JoTb5JgBinifaR+SgKB9kbKPWAJRJVG/9FV5uVkwNbPVERi/XUeiOYNWUELejcIAYlmFld9q/qjI/T5CfH8nCYw+7J/zmTQ8zmiPeVog5qGblbtfVORZhkSnd3Gv9qoYQceti6bzzZbrw7AbEhnwQIx5k1/cZl5hdv1rPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243387; c=relaxed/simple; bh=nWejgZp3H5Fp55HVoiFDYAzyGJFPHH6SRX9X21lqn2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lIvJd9a0bwXw+iNlvvqSAIOjY6eI105se5v+ocoYAUWWg9gqoYMdWMh9OkWTR+AkSumhClrhDDDH479WrtGRe0nNyaEXMAt813OLF5exeR4h27G5w6sT0iBbMXAQGolAxc+U4GGb5KOYg4arbkChneFMQuWC8r2lXtetIOdx484= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1HszDQ40; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1HszDQ40" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFAC61F000E9; Thu, 20 Aug 2026 16:29:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787243386; bh=cZ0cXmC+nGqyoOt8iBrcKSPbA8VVwSx2QS3W250WYiw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1HszDQ40fvJJlMhBvLuta1KWZ2/JjXaoUAvn35kAX9+hqJRBTr2VQK5r28LytdtNW g/kF7f66gObce+2X+jDLt+1GTQzXqYUFRuM5SqXsFT+EyliIeYf6gYbK9JnuFXs0Wc 6RohejZrxtVQXSq3/Cfyo86l+6LXjTdMAdviXp7k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Matthew Rosato , Eric Farman , Christian Borntraeger Subject: [PATCH 5.15 038/272] s390/vfio_ccw: Fix out of bounds check on CCW array Date: Thu, 20 Aug 2026 16:53:42 +0200 Message-ID: <20260820145232.369215870@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145231.229664293@linuxfoundation.org> References: <20260820145231.229664293@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Farman commit a005b7f1a491ffda61bff0fd0f6548f8986fb977 upstream. The routine ccwchain_calc_length() counts the number of channel command words (CCWs) that are chained together in a single channel program, and rejects anything larger than CCWCHAIN_LEN_MAX (256) CCWs. The loop itself is "do..while (count < 257)", and while the logic in is_cpa_within_range() correctly adjusts between the 0-index array of CCWs and the count of CCWs starting at 1, this means it would look at a possible 257th CCW before ending the loop and (correctly) returning an error. Fix this by restructuring the loop to break as soon as 256 CCWs (thus indexes 0-255) are examined, without looking at memory outside the range. Fixes: 0a19e61e6d4c ("vfio: ccw: introduce channel program interfaces") Cc: stable@vger.kernel.org Reviewed-by: Matthew Rosato Signed-off-by: Eric Farman Signed-off-by: Christian Borntraeger Signed-off-by: Greg Kroah-Hartman --- drivers/s390/cio/vfio_ccw_cp.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) --- a/drivers/s390/cio/vfio_ccw_cp.c +++ b/drivers/s390/cio/vfio_ccw_cp.c @@ -371,11 +371,9 @@ static void ccwchain_cda_free(struct ccw static int ccwchain_calc_length(u64 iova, struct channel_program *cp) { struct ccw1 *ccw = cp->guest_cp; - int cnt = 0; - - do { - cnt++; + int cnt; + for (cnt = 1; cnt <= CCWCHAIN_LEN_MAX; cnt++, ccw++) { /* * As we don't want to fail direct addressing even if the * orb specified one of the unsupported formats, we defer @@ -393,15 +391,10 @@ static int ccwchain_calc_length(u64 iova * after the TIC, depending on the results of its operation. */ if (!ccw_is_chain(ccw) && !is_tic_within_range(ccw, iova, cnt)) - break; - - ccw++; - } while (cnt < CCWCHAIN_LEN_MAX + 1); - - if (cnt == CCWCHAIN_LEN_MAX + 1) - cnt = -EINVAL; + return cnt; + } - return cnt; + return -EINVAL; } static int tic_target_chain_exists(struct ccw1 *tic, struct channel_program *cp)