Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A065147B403; Thu, 20 Aug 2026 16:36:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243817; cv=none; b=aqPEggJNyNdhcSEWwi/U0hWNG64AHbsQ3AV+dposTdeYjkJFVia+nbkex/EdXA2MG23kSc0Fp36vMIXZHcbcnbiEswszW4seCFBRrHWFFJTB+1V/RqbEz69GZbVx1PqO9uWjh4OxloTPlXXQMspGgXEJukbl0y4hMDpsRpsczsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243817; c=relaxed/simple; bh=joMkOe8TrGeTpKs57oftrMiQVmhzamZWOC2BkWLLkg0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kCsv36LRFoSZ1gpvOeaei9ZR7RchKLQpA53EyoOL2Db4X0ZNsfV1iZvZtA11NC16/sMb8fkJqTFwn5DFDqQBcESnxX5YxAbdyqUOg8ceeuAXJ1oqyeXVcyT64Nl2AZRzlacpZ0dkXrPAkFMoxnmyh1QOO+nk6fKxDXdKU+KFMLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XxDaczGO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XxDaczGO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B6DF1F000E9; Thu, 20 Aug 2026 16:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787243815; bh=CJuU5D0oTx7KxTA4KP+6fB0KMCujc8FtEYj+LCx+ImE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XxDaczGOwDNKuvHT86g+tAqbzYVIGPgh1qdIkxgz/wdAk1wD7C4Yz8htRotht+XKH jWmaxiaMBnf0gou9t2UTUNspLmzg0TET8apnthCPkUc39gkksPQzwyPYfC9KpoCU2S VVfFNirBhFE7rv30hXHHLiNqJ83aWxN9tJIIBOgQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maoyi Xie , Johannes Berg , Sasha Levin Subject: [PATCH 5.15 225/272] wifi: libertas_tf: fix use-after-free in lbtf_free_adapter() Date: Thu, 20 Aug 2026 16:56:49 +0200 Message-ID: <20260820145238.348949684@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145231.229664293@linuxfoundation.org> References: <20260820145231.229664293@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie [ Upstream commit aa6dcd5c8dd9ba1d7d0f60093bcda41c0d6d438d ] lbtf_free_adapter() calls timer_delete(&priv->command_timer), which does not wait for a running command_timer_fn() callback. lbtf_free_adapter() runs on the teardown path right before ieee80211_free_hw() frees priv, both in lbtf_remove_card() and in the probe error path. command_timer is armed by mod_timer() in lbtf_cmd() whenever a firmware command is sent. command_timer_fn() dereferences priv. If a command times out as the device is removed, command_timer_fn() runs concurrently with teardown and dereferences priv after it has been freed. This is the same use-after-free that commit 03cc8f90d053 ("wifi: libertas: fix use-after-free in lbs_free_adapter()") fixed in the sibling libertas driver. The libertas_tf variant has the identical pattern and was left unchanged. Use timer_delete_sync() so any in-flight callback completes before priv is freed. Fixes: 06b16ae53192 ("libertas_tf: main.c, data paths and mac80211 handlers") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Link: https://patch.msgid.link/178211481807.2212567.8773346114561900100@maoyixie.com Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/marvell/libertas_tf/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/marvell/libertas_tf/main.c +++ b/drivers/net/wireless/marvell/libertas_tf/main.c @@ -174,7 +174,7 @@ static void lbtf_free_adapter(struct lbt { lbtf_deb_enter(LBTF_DEB_MAIN); lbtf_free_cmd_buffer(priv); - del_timer(&priv->command_timer); + timer_delete_sync(&priv->command_timer); lbtf_deb_leave(LBTF_DEB_MAIN); }