Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10AB347B403; Thu, 20 Aug 2026 16:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243819; cv=none; b=pVfBVB/0yui4GBeZnHuzB6WDJSMgxvAkDy1G8Zuy7mj16S+5hcK5Ua3BS0Gf9pf5iuvhg1gW0X5fniO+nvkUjHTa2mwERxfKUCUn4qvS2b3vFDnbzxTu/gfkrh0F6aLPA4FkRDFmENoQX0HaR9vQLQ126/9QVynqszj91Pb8R3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243819; c=relaxed/simple; bh=DHYbqNpx78jArNls8BNLwoX53LQE8tT0E6sKx/lfBeI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ElrhdJtJOmZgA2HvKEW2TTKIPUp/zrV/gEbg4/tG8SsAIpAu1DaF/PYz7wuVUc4vFpk3b0LXgkYHCAUw+LJtqTQZS3KKKZAWZeMT3CUmA3/SbR8GFomi0mY0D+u2/myJJbvdieIXoekx0po3o/ZU3nwuXOPY/icBxRrHuU61wbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0yb9xIdN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0yb9xIdN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BA801F000E9; Thu, 20 Aug 2026 16:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787243817; bh=3Zz/b3zOBqLIk1Y287IS6ID79fFEmHJyCeDjZEAM6Uc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0yb9xIdNolWd/0gZutRUpQXFwUm31BTqzQK2wDJvGB+T0B3k669JwSuz/3CvBH7FF BwUiKClhcenW0cxGnZWb1BeIYnvE284MJGFG1sxqAlPuT5wJ+FWjlf3RG8ise6ZuNB mYm2NkFj+85m8vO3L9yOJRimBf3i16xnCcH7oATI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maciej Fijalkowski , David Carlier , Dima Ruinskiy , Moriya Kadosh , Tony Nguyen , Sasha Levin Subject: [PATCH 5.15 226/272] igc: remove napi_synchronize() in igc_down() Date: Thu, 20 Aug 2026 16:56:50 +0200 Message-ID: <20260820145238.378915004@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145231.229664293@linuxfoundation.org> References: <20260820145231.229664293@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Carlier [ Upstream commit 5ffab5b9589c50e4cfc0cf36ffd76c89422d4019 ] When an AF_XDP zero-copy application is killed abruptly, the XSK pool is torn down but NAPI keeps polling. igc_clean_rx_irq_zc() then returns the full budget on every poll, so napi_complete_done() never clears NAPI_STATE_SCHED. igc_down() calls napi_synchronize() before napi_disable(), so it spins forever waiting for that bit and the interface never goes down. Drop the napi_synchronize() and let napi_disable() do the job -- it sets NAPI_STATE_DISABLE, which forces the stuck poll to complete. Reorder it ahead of igc_set_queue_napi() so the NAPI mapping is cleared only after polling has stopped, matching the recent igb fix b1e067240379. Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy") Suggested-by: Maciej Fijalkowski Cc: stable@vger.kernel.org Signed-off-by: David Carlier Reviewed-by: Maciej Fijalkowski Reviewed-by: Dima Ruinskiy Tested-by: Moriya Kadosh Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/igc/igc_main.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -4980,7 +4980,6 @@ void igc_down(struct igc_adapter *adapte for (i = 0; i < adapter->num_q_vectors; i++) { if (adapter->q_vector[i]) { - napi_synchronize(&adapter->q_vector[i]->napi); napi_disable(&adapter->q_vector[i]->napi); } }