Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78EE6381AEC; Thu, 20 Aug 2026 17:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787247824; cv=none; b=lzlyZytglLQMl939hcqIYMfNAx1j3NAkydbkoKiH1Pz3661LaIY3cImNMtNJsMIY6n0c2TJQjItVECR1xy4b+g78oR+7rh/Lf9kuwPPAbdf7CiG6/53RyVJj5TjgiJdVBPNmas4tQVxtOV7BPnFiooCSIWZKuvjMUmYTSKPbhhQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787247824; c=relaxed/simple; bh=t0dNMvL74tKb/5gOXRAX8rI6S/2NiJ+3aUS6eYDNlNg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tg5ktBrblCqWwSPI0fbzBJ2iatBgmFnKOt2kbvnbsXKdh7eobKnqkO1O8nYeuj1mDzshfwzjgaheJiys1k+Vqhr27zr4myntI1llFX4JEm2pGx+PBaj30a4K78dRli5z99R3kuVBFYQhc74eI/zLA9wAJcfBWH01Zfy4nhmK6t0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TjYEXsm6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TjYEXsm6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D64781F000E9; Thu, 20 Aug 2026 17:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787247823; bh=rHzvZ0o8ewvy3TOwyr1VWcehhegdq2tdBrmcUQoOKDw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TjYEXsm6ifUny1tMHAmNyIYweiBGyq73aubu3y0WxKzDPmStKBxmEEakkE1vRcUBq 70rrK8UgoRfX6djdQu5IrFqHZ5eYTUpaQlbZS5MApDNWYWHuvcnXxMUe8ZuTSLeQaV +bvrBO21esePEcI/qef+ODclmV8rzEsuSWP7uwDo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alexandra Winter , Hidayath Khan , Joe Damato , Jakub Kicinski Subject: [PATCH 6.1 015/303] s390/qeth: validate user buffer length in SNMP and ARP query ioctls Date: Thu, 20 Aug 2026 16:52:31 +0200 Message-ID: <20260820145253.646175958@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145253.200766705@linuxfoundation.org> References: <20260820145253.200766705@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hidayath Khan commit d141f087b1af656f055d7c5793a3e87817ba0bbe upstream. qeth_snmp_command() and qeth_l3_arp_query() allocate a buffer sized by a user-supplied length (udata_len) without checking a lower bound, then set udata_offset to a fixed non-zero value and pass both to a reply callback. The callback bounds-checks the copy with if ((udata_len - udata_offset) < len) Both fields are u32, so a udata_len smaller than udata_offset makes the subtraction wrap and the check pass, and the following memcpy() writes past the allocation. A udata_len of 0 also yields ZERO_SIZE_PTR from kzalloc(), which the existing NULL check does not catch. Reject buffers smaller than udata_offset before allocating, so the callback subtraction can no longer underflow. Fixes: 4a71df50047f ("qeth: new qeth device driver") Cc: stable@vger.kernel.org Reviewed-by: Alexandra Winter Signed-off-by: Hidayath Khan Reviewed-by: Joe Damato Link: https://patch.msgid.link/20260730142216.218309-1-hidayath@linux.ibm.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/s390/net/qeth_core_main.c | 3 +++ drivers/s390/net/qeth_l3_main.c | 5 +++++ 2 files changed, 8 insertions(+) --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -4708,6 +4708,9 @@ static int qeth_snmp_command(struct qeth if (req_len > QETH_BUFSIZE) return -EINVAL; + if (qinfo.udata_len < sizeof(struct qeth_snmp_ureq_hdr)) + return -EINVAL; + iob = qeth_get_adapter_cmd(card, IPA_SETADP_SET_SNMP_CONTROL, req_len); if (!iob) return -ENOMEM; --- a/drivers/s390/net/qeth_l3_main.c +++ b/drivers/s390/net/qeth_l3_main.c @@ -1414,6 +1414,11 @@ static int qeth_l3_arp_query(struct qeth rc = -EFAULT; goto out; } + + if (qinfo.udata_len < QETH_QARP_ENTRIES_OFFSET) { + rc = -EINVAL; + goto out; + } qinfo.udata = kzalloc(qinfo.udata_len, GFP_KERNEL); if (!qinfo.udata) { rc = -ENOMEM;