Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3117F485CC2; Thu, 20 Aug 2026 17:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248340; cv=none; b=a7HW6oRG2RmTOsS/Ihd3flCwprrJAXn2LpAmzQTcvJoRSeE8ZKXCgG6541Rf9VcwOFu5Q4X/DtesRPxpiUM+PEnqbQxVYxAoOAj/fhxG2GuF52jIPHYpFywHzBmmsA2oewND8JdVUJURGABy6fh/jz7+83oTgWJWZfR4YadVf40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248340; c=relaxed/simple; bh=s6iucNOH/t3OU30Etm3hqs887Yqgt5u05d1i7bk+YSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y+kOuTeZ+WRksELEF8dkEkEAY0D3SNvQLE+Xzko9BPYXyRQB6R7eewyvurfr9lpmkTFWIPIc/h+E5H/CZDFcHjcOic0qJSQDHueZgv9w3HaHqNFsJIvmQrLvDhlAdT2Udv588gO9dFPMNf6lFZopXWPwt/9T8i23fznw/NOQtDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XzNvxX/N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XzNvxX/N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6639A1F000E9; Thu, 20 Aug 2026 17:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787248337; bh=G8fz0LuWTZ1zQn6096OQK6UPHgfQxjIS5YYx3BvXews=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XzNvxX/NAZ+97Q5GA1++89RIttZH8GmW82ODIlsDuj9o/x8Ws3Ku3xfWdv0BavRXF 7DshtKdojjcR6zfu0yWeIOHvjm69GRZPsl36NdDPwduEvXC4axLFzINrANmBe9jOS9 vQ2T4DJ4AFmxta7LVC+TrDVx80rXWBp+MKzhAqbQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maoyi Xie , Johannes Berg , Sasha Levin Subject: [PATCH 6.1 144/303] wifi: libertas_tf: fix use-after-free in lbtf_free_adapter() Date: Thu, 20 Aug 2026 16:54:40 +0200 Message-ID: <20260820145257.611724440@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145253.200766705@linuxfoundation.org> References: <20260820145253.200766705@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie [ Upstream commit aa6dcd5c8dd9ba1d7d0f60093bcda41c0d6d438d ] lbtf_free_adapter() calls timer_delete(&priv->command_timer), which does not wait for a running command_timer_fn() callback. lbtf_free_adapter() runs on the teardown path right before ieee80211_free_hw() frees priv, both in lbtf_remove_card() and in the probe error path. command_timer is armed by mod_timer() in lbtf_cmd() whenever a firmware command is sent. command_timer_fn() dereferences priv. If a command times out as the device is removed, command_timer_fn() runs concurrently with teardown and dereferences priv after it has been freed. This is the same use-after-free that commit 03cc8f90d053 ("wifi: libertas: fix use-after-free in lbs_free_adapter()") fixed in the sibling libertas driver. The libertas_tf variant has the identical pattern and was left unchanged. Use timer_delete_sync() so any in-flight callback completes before priv is freed. Fixes: 06b16ae53192 ("libertas_tf: main.c, data paths and mac80211 handlers") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Link: https://patch.msgid.link/178211481807.2212567.8773346114561900100@maoyixie.com Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/marvell/libertas_tf/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/marvell/libertas_tf/main.c +++ b/drivers/net/wireless/marvell/libertas_tf/main.c @@ -174,7 +174,7 @@ static void lbtf_free_adapter(struct lbt { lbtf_deb_enter(LBTF_DEB_MAIN); lbtf_free_cmd_buffer(priv); - del_timer(&priv->command_timer); + timer_delete_sync(&priv->command_timer); lbtf_deb_leave(LBTF_DEB_MAIN); }