Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED1E513D53C for ; Wed, 9 Sep 2026 01:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788918928; cv=none; b=nUyV6Sh/56ZyirY2q5ke1ErCVknwTFSOg3qbEUriLIhlj+3TlKeq5ET10n8HE2lIDnCOGEVUdg9pFUFCzNEXHLbHM+xgq4g15PlVFkPMixlrslxrxYNPU9nWkeneP1bPckoxcB8hJw701D6qFo3KzdgbxsudLRpPFOTREp1CI6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788918928; c=relaxed/simple; bh=wL5NY2y2hL3tB8BwilkAbibR2NaRGBUS3TU8csISBNo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nMDfFpwj3G6gnR9H5HhMhgS5hc4NCTBRpnVonDcA7PyMNUIoVlEAN3WunQyTYHokgGrfbZSCg4zPwPOf4GGwAFwdsk1PgvxRXfhX9yzyL0wc9IUpsYTjl/YgQeuoZQHUTqaNXzJlfsksyQ+MC4++uhKirg5SzPf1RbhuWl8UONk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YjK4VkrV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YjK4VkrV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2091F1F00AC4; Wed, 9 Sep 2026 01:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788918926; bh=72hdon0SSOTPxg4Z4qFlEkStheSkLYFhP/vCzrRz8qI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YjK4VkrVLRWiCh8g7qoOPyqMmkxA9vb1XlxttzFA843Yn/JQRQVShQbVpPYZV4fkf 57QVXrLpRGQR+bgO3p+WEQ548ot9b/l4AfT5fAwc3SL6xxf4bGXJEHV2P9hTw1Uc7A V5V92WTlGR07ZlG6JX4fI6CCoyORteZVFPPcqBgjDYLLzXlFZO/GzZMIgyZRsDV9Zi omFjQAO5IoqEicoCcPPU7m06WtMlPNHOA3aW4NTGMIiZ0YFZdvIxn0jWkukPCuuFol 75pwQFSsXL/TdS1mNGVDvip1QIY+KQXDPJOsJnEwkmI66z9fMTLFMEmMdc76oUDOPy UsPX7mVXG8e5Q== From: Sasha Levin To: stable@vger.kernel.org Cc: Chuck Lever , Jeff Layton , Sasha Levin Subject: [PATCH 5.10.y 4/4] svcrdma: Use svc_xprt_put to free listener on create failure Date: Tue, 8 Sep 2026 21:55:22 -0400 Message-ID: <20260909015522.954712-4-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260909015522.954712-1-sashal@kernel.org> References: <2026090356-dehydrate-probe-c315@gregkh> <20260909015522.954712-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever [ Upstream commit e346ef7bcb137f50c49f969330ab7dcf64ea1654 ] svc_rdma_create() calls kfree(cma_xprt) when svc_rdma_create_listen_id() fails. svc_xprt_init() has already acquired a net namespace reference via get_net_track(); kfree bypasses svc_xprt_free() which releases it. Replace the kfree() with svc_xprt_put() so the kref_init birth reference drops to zero and svc_xprt_free() dispatches svc_rdma_free() to clean up properly. sc_cm_id is still NULL at that point; the preceding patch added the necessary NULL guard in svc_rdma_free(). svc_xprt_free() also drops the module reference via module_put(), but the caller _svc_xprt_create() does the same on xpo_create failure, double-putting the single try_module_get() it acquired. Take a compensating __module_get() before the svc_xprt_put() to keep the count balanced, matching the convention in svc_rdma_accept()'s error path. Fixes: 4fb8518bdac8 ("sunrpc: Tag svc_xprt with net") Cc: stable@vger.kernel.org Acked-by: Jeff Layton Link: https://patch.msgid.link/20260527-rdma-follow-on-v1-3-1b09bd87b6cd@oracle.com Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index f7f764508a2ea..ea2c008eb67fe 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -350,7 +350,13 @@ static struct svc_xprt *svc_rdma_create(struct svc_serv *serv, listen_id = svc_rdma_create_listen_id(net, sa, cma_xprt); if (IS_ERR(listen_id)) { - kfree(cma_xprt); + /* _svc_xprt_create() acquired one module reference and + * puts it on xpo_create failure. svc_xprt_free() puts + * a second one when the kref drops to zero. Take a + * compensating reference so both puts are balanced. + */ + __module_get(cma_xprt->sc_xprt.xpt_class->xcl_owner); + svc_xprt_put(&cma_xprt->sc_xprt); return ERR_CAST(listen_id); } cma_xprt->sc_cm_id = listen_id; -- 2.53.0