Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FBE05475F; Sat, 12 Sep 2026 15:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789225347; cv=none; b=tlUK2LF1IwlUaxOzi84UzSr94tVD40x/AewitR5FzeiNGerBN5Mq6guOWXuqWj6IMAAbPcbwd+T4gw1wjI2jPUVRP19I/BIk/c9hV3dgyq/vgVMKpqY36JBUBzTvC8MvFPxw/G+xrfdU07WEJ02XiXh0rZtaIwqreCf69M7H974= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789225347; c=relaxed/simple; bh=UQ+/ESVQ5lz9qfoEIUjugOArKpM5cQG8Ar1VwI4un1Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tBWYoh69F/chOvPgVH8RDBNuhD+TXx2M+LZGOVAcE9yTLFBTX0cgB4cC8X84C2dxPN0j1+121IZcIArowGqHFpCYxUfH6UfzEsMZR4qH2EtLmNITAGS0Er6xDNcqWcDCgQ6JVm8YyhsCL8Ip0YlTbA9DrVUvbDhQ108D+v0IrkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1WJB3kS7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1WJB3kS7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E83F61F000FF; Sat, 12 Sep 2026 15:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789225346; bh=TAlPAgluwbDDs/ey0VN5c0yVwpmj9Dyd0r/geOjPJfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1WJB3kS7dFyShKEnP5nAmsfl/ZL/q6wTN3nwt13vvv7q8V0gDVvLN/tp8LR41VMFv NYFhbGt+8fpLbsYoGnhnhAVAKj2gy1ECkrxbJhmhaHnDA0+peZXNrCuCK03mqj+ayb d/MfH7SMWOo7MmVoCrK8YkDsUteJU+t5a1VfHgVo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, bui duc phuc , Mark Brown , Sasha Levin Subject: [PATCH 6.6 1177/1424] ASoC: pxa: Use devm_clk_get_optional() for extclk clock Date: Sat, 12 Sep 2026 09:00:09 +0200 Message-ID: <20260912065633.650577973@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: bui duc phuc [ Upstream commit 6ec64d757af9b75a3c64f9f7dad76bdc1efc06ca ] The Device Tree binding defines the extclk clock as an optional property, but the driver currently uses devm_clk_get() and manually handles the absence of the clock. Use devm_clk_get_optional() to match the binding and simplify the optional clock handling. This also propagates errors other than the absence of the optional clock, including -EPROBE_DEFER. This changes the existing behavior for errors other than -EPROBE_DEFER. RFC to discuss whether these errors should cause probe to fail rather than being treated as an unavailable optional clock. Fixes: 90eb6b59d311 ("ASoC: pxa-ssp: add support for an external clock in devicetree") Signed-off-by: bui duc phuc Link: https://patch.msgid.link/20260811100949.61142-1-phucduc.bui@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/pxa/pxa-ssp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c index b8a3cb8b75978..ba8cae8e85ef5 100644 --- a/sound/soc/pxa/pxa-ssp.c +++ b/sound/soc/pxa/pxa-ssp.c @@ -769,13 +769,10 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai) goto err_priv; } - priv->extclk = devm_clk_get(dev, "extclk"); + priv->extclk = devm_clk_get_optional(dev, "extclk"); if (IS_ERR(priv->extclk)) { ret = PTR_ERR(priv->extclk); - if (ret == -EPROBE_DEFER) - goto err_priv; - - priv->extclk = NULL; + goto err_priv; } } else { priv->ssp = pxa_ssp_request(dai->id + 1, "SoC audio"); -- 2.53.0