Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6888423A72; Sat, 12 Sep 2026 13:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789218724; cv=none; b=naqZDqFZ2wRT0GFpD8JE9UigWvJd5BQEyiGg6B5Cvgd2M2INk3rEDVI6uM00/H3OYXFI6PaRA0kaKevpvhjD3h68dfF9GpjdxALC/kadgjqTQ4ID0JUjDLfGscdz4I2PCS2zCcZT7v+ZXTPo45CN5M0YI0B9X/A7LG/jwFAmdUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789218724; c=relaxed/simple; bh=YKUKWHx0aTOwj+nG1Fn0GOKiXt6/jNGb1/dntBsTgEU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YLzjOaisurvjkY7RG8LWjwoGCVYtbmjmNix7mnHKljQSOGz5BisvDPJlL8Hulmq69iIoLbZcFnewYBDHSlIKPKr47AHQYo0xIhF2P2nnRFbkdH4odU44ljILtRvCUbXwNWHCEmZdfRInB7coY1icrE+k5K6x3R+I9uEWO00jEUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sSQmsKcc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sSQmsKcc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3AAD1F000FF; Sat, 12 Sep 2026 13:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789218718; bh=urt+Oz+mcGiChGSUbla8tEj2+OGjvI4emGf35Ndn+bs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=sSQmsKcccxxNvoXFSbI7ijrIqbbRLHT4mJEbEE5bTfiESEImdFtc0GfW5Ez6xsVJK onahAOqhLEGEXi6xwsb7QLAA3dKq82LEEq76dff+3FWK+wcdkE4D1unLKOyrqQUE0+ HVfI4zzub6MDlLERSVyR6eXKPPEz11q+759sp9S8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joas Antonio dos Santos , Julian Anastasov , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 6.12 1200/1376] ipvs: fix integer overflow in ftp helper port/address parsing Date: Sat, 12 Sep 2026 09:00:26 +0200 Message-ID: <20260912065634.293044032@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.535295758@linuxfoundation.org> References: <20260912065607.535295758@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joas Antonio dos Santos [ Upstream commit e625a9477d12baaff4025c5f9989184a907ea8fc ] ip_vs_ftp_get_addrport() accumulates decimal digits into a __u16 (hport) and into unsigned char (p[]) without checking for overflow. A crafted FTP PASV/EPSV response with an over-long port or address octet wraps the value, so the helper configures the data connection with a truncated port/address. The netfilter conntrack FTP helper had the same defect, fixed in commit 2b413fc689ba ("netfilter: nf_conntrack_ftp: avoid u16 overflows"). Apply the equivalent fix here: widen the port accumulator to u32 and reject values above 65535, and reject address octets above 255. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Joas Antonio dos Santos Acked-by: Julian Anastasov Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/ipvs/ip_vs_ftp.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c index 206c6700e2006..d3be352a5ea8c 100644 --- a/net/netfilter/ipvs/ip_vs_ftp.c +++ b/net/netfilter/ipvs/ip_vs_ftp.c @@ -103,7 +103,7 @@ static int ip_vs_ftp_get_addrport(char *data, char *data_limit, char *s, c; unsigned char p[6]; char edelim; - __u16 hport; + __u32 hport; int i = 0; if (data_limit - data < plen) { @@ -145,7 +145,11 @@ static int ip_vs_ftp_get_addrport(char *data, char *data_limit, return -1; c = *data; if (isdigit(c)) { - p[i] = p[i]*10 + c - '0'; + unsigned int val = p[i] * 10 + c - '0'; + + if (val > 255) + return -1; + p[i] = val; } else if (c == ',' && i < 5) { i++; p[i] = 0; @@ -223,6 +227,8 @@ static int ip_vs_ftp_get_addrport(char *data, char *data_limit, if (!isdigit(*s)) break; hport = hport * 10 + *s - '0'; + if (hport > 65535) + return -1; } if (s == data_limit || !hport || *s != edelim) return -1; -- 2.53.0