Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 079BF34252D; Sat, 12 Sep 2026 13:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789218770; cv=none; b=OGdfs0BkrTVYyequS+fAMjozjOHTggiODgwyBJaAnCVFWlsmdP9tOfPo69MFjSXWwVch/eJjzRJK2pfNNCCVXuQ7wk4sKoB40bhX8R2hX4NW3na92O+IEvGVh/eu3hdn1assJRpNOnn9uwEtL0xzvJWeWC8j32JtAnGWXlSVUEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789218770; c=relaxed/simple; bh=iofa0yLgwtvu8DMrkzlWTnuFdpnpWt0Bhr+uP7jwsOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r/ssdSOBpkKRMYplU0ynM2oNA48vTtbdkyD27vZHXVvNo7b0boFvCdXX4cxv4sktuku4+A0wwX5t7xcgDCNFy00/SlkQefq7pik3UbcrzbMNAp4DPy9UiHmsX6gDLEjGXPl5uu0wqMDH3m6bqux4UXYerFUNciCzSvVOm2rf9qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HKvCDw7Q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HKvCDw7Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB7801F000FF; Sat, 12 Sep 2026 13:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789218768; bh=fEpmgeJVENF+ngHsS+pmCJz43sRUPj5AvD1kl/gg0d8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HKvCDw7Qd4OWrryBxt4U3Ta/xb9N8e4WdGkyeqcBOQiGxdkeG7Sh97+IKia7gCkwC 9NYvvxs6Gad3fsc0pu7FhA/9yOECjmqGKhZJLO85d9H6CuuOBnesQprAa3RcB0oYgc a9iDYBxcN3ABM0C6tI9EOQK713IG1yJ5e5JwVVLo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Karl Mehltretter , Andrew Lunn , Paolo Abeni , Sasha Levin Subject: [PATCH 6.12 1214/1376] 8139cp: fix Rx and Tx not being disabled in cp_suspend Date: Sat, 12 Sep 2026 09:00:40 +0200 Message-ID: <20260912065634.606334849@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.535295758@linuxfoundation.org> References: <20260912065607.535295758@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Karl Mehltretter [ Upstream commit cb7643b78d35392f0f434774d78b4c77b80f677f ] On QEMU rtl8139 model, frames that arrive while the interface is suspended still end up in the stack after resume. With pm_test=devices, which keeps devices suspended for 5s, 200 frames sent to interface during that time and 50 frames after resume, eth0 reports 113 received frames. cp_suspend() is supposed to stop receiver and the transmitter, but the mask is wrong: (~RxOn | ~TxOn) is ~0, nothing is cleared and Cmd still reads 0x0d when cp_suspend() returns. Use ~(RxOn | TxOn) so both bits are actually cleared. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Karl Mehltretter Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20260817043057.20099-1-kmehltretter@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/realtek/8139cp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c index 5652da8a178c0..9016527e229ac 100644 --- a/drivers/net/ethernet/realtek/8139cp.c +++ b/drivers/net/ethernet/realtek/8139cp.c @@ -2066,7 +2066,7 @@ static int __maybe_unused cp_suspend(struct device *device) /* Disable Rx and Tx */ cpw16 (IntrMask, 0); - cpw8 (Cmd, cpr8 (Cmd) & (~RxOn | ~TxOn)); + cpw8 (Cmd, cpr8 (Cmd) & ~(RxOn | TxOn)); spin_unlock_irqrestore (&cp->lock, flags); -- 2.53.0