Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B68B24CEEA; Sat, 12 Sep 2026 10:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789210488; cv=none; b=F2JOJNHOx4SEHdzA0uYWlV61yxGVoV1IsslI5trbCLByremtXKQufc6/nTBMS0CLjaPNPei1dIOIpSyqZIiwE5F//dX+Hoc935dpCpE7cpGqm55qjCqqpUdXeTMkz/kVhJZXo4OR+OZAfXXNAA9gthrKV0TmRxqB7/nyR4XgVTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789210488; c=relaxed/simple; bh=OXgbqyrmbtiOqQ4aKsD0MMDomHX/lUWVA33pEIAyaN4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Awsl5+RexfMhoD7jDjpAzRYs6Qj3ASpX2CXA/OCESdMGj+w2Uhw60b9hQ6myULstj+rIh4TIAWjNmCDfxJrhCeaSIQr/jqmsDQEtheSWwF6AJ5uKB+PbEPlZw2DyfkqKRbMztJnUKm0kJ3GKYCKVXoniWyFlUyLClN4XOkZyFxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GZvBYg0l; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GZvBYg0l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3412B1F000FF; Sat, 12 Sep 2026 10:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789210487; bh=BCanFYuWQNNr7VXZwOy5JH9WQbqZLFPFT6QhRvPBI5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GZvBYg0l0nnvS0X9QUDoovaMQzQvllGLtoCg6zdgpqmygqC/+QeE/UN2S8LhN97YF r6grdevSSVTYE/e1tG4Q7/UBU9CIK7ihaYZzeBqeZNRjhyNjNeJPYY6GKR5gFqPgJ/ 6xFHfJCXPaFGvtxqec0fSaVD9PHv301+Vccs5bMQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nikhil Gautam , Jonathan Cameron , Sasha Levin Subject: [PATCH 6.18 1036/1518] iio: light: gp2ap002: Fix unbalanced runtime PM on repeated event writes Date: Sat, 12 Sep 2026 08:53:25 +0200 Message-ID: <20260912065646.887104717@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065623.398859879@linuxfoundation.org> References: <20260912065623.398859879@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nikhil Gautam [ Upstream commit 579c049b4cb6fc72ce2c505fc5334540be0efcd3 ] The IIO core does not filter duplicate writes to the event enable attribute, so writing the same value twice invokes write_event_config() twice. Enabling twice leaks a runtime PM reference, preventing the device from ever suspending again; disabling twice underflows the usage count and triggers a "Runtime PM usage count underflow" warning. Bail out early when the requested state matches the current state. While at it, switch to pm_runtime_resume_and_get() so a failed resume is propagated to userspace instead of silently marking the event enabled. Fixes: 97d642e23037c ("iio: light: Add a driver for Sharp GP2AP002x00F") Signed-off-by: Nikhil Gautam Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/light/gp2ap002.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index b62611099037e..3abe02942d127 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio/light/gp2ap002.c @@ -342,6 +342,10 @@ static int gp2ap002_write_event_config(struct iio_dev *indio_dev, bool state) { struct gp2ap002 *gp2ap002 = iio_priv(indio_dev); + int ret; + + if (state == gp2ap002->enabled) + return 0; if (state) { /* @@ -349,13 +353,16 @@ static int gp2ap002_write_event_config(struct iio_dev *indio_dev, * already) and reintialize the sensor by using runtime_pm * callbacks. */ - pm_runtime_get_sync(gp2ap002->dev); - gp2ap002->enabled = true; + ret = pm_runtime_resume_and_get(gp2ap002->dev); + if (ret) + return ret; + } else { pm_runtime_put_autosuspend(gp2ap002->dev); - gp2ap002->enabled = false; } + gp2ap002->enabled = state; + return 0; } -- 2.53.0