Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 902294ED1AE; Thu, 17 Sep 2026 18:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789668448; cv=none; b=JWjntJOz+MdFm0IWHXSs6mIQslgaUWWCHvb6uRLDtpkR1N/gMDfVUNCMBxXdUN7YzFvDRxe+NoLUVIo/JAZXzXDhr1cuU9EkBga+rAgL7O7XTPi6kRIVxiv/bA6XG0ebhFOXX+h5WlbmyMdG7ngaAsNLZkV7HSb/gD/WN2s42gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789668448; c=relaxed/simple; bh=gvr/oPLZw4evsoIWv5v7DIWAoHoaA/P3ndi0QN1veTk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gxjHVbPYvGDZtha/SxhetB2159q19Mfdt4YnmImdPrdPDsqrnL6+OQqCxw3BK9g3fsxqjxn/EVvqWy56n9MG++uICb3AlCL5xJK60Qp1cH60LC9pRWak2WP7IiPGWu7Iq7XPDVZdSh341MkENC5Y1cZerz+gsnAyzODGRUjFcas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ak7LtQhS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ak7LtQhS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5F631F000FF; Thu, 17 Sep 2026 18:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789668446; bh=RKpgGaOKwb77ynLMgp8ZPTLNBMLGcPDQ5QFgJC8+dkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ak7LtQhSbfasPHxOZahAgW3IdS8UrqQ3GvDff6V1kqvhwg1AdLWiIiUGxwDPI02Uf Q6TSwOh1p+ExTBUzZbiI4uHq44ZImVwMQxvDZmzaJU9tmy2gOBy9EQiy9Q2cSGGEG7 9sVvOEPPMKNAU0BOTbgDd13XpHNpc7uladzWmB78= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Emmanuel Grumbach , Miri Korenblit , Sasha Levin Subject: [PATCH 6.12 0428/1102] wifi: iwlwifi: mvm: fix out-of-bounds tid_data access in BA notif Date: Thu, 17 Sep 2026 16:06:11 +0100 Message-ID: <20260917151550.416879880@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151539.408551884@linuxfoundation.org> References: <20260917151539.408551884@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Emmanuel Grumbach [ Upstream commit 94d3982806c7f194b23484befde12934dda23064 ] mvmsta->tid_data was indexed by the TFD loop counter 'i' instead of the actual TID value 'tid'. This writes lq_color into a random tid_data slot unrelated to the BA entry. Since multi-TID blockack is not really in use, 'i' was always 0 and no harm was done. Add a out-of-bound check before accessing the array. Assisted-by: GitHubCopilot:gpt-5.3-codex Signed-off-by: Emmanuel Grumbach Signed-off-by: Miri Korenblit Link: https://patch.msgid.link/20260715215523.919edee567eb.Ie85c350e3afe2b39709d0039072740d86660f8ae@changeid Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c index e70c26deb8b8f..359cd091b7382 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c @@ -2284,8 +2284,14 @@ void iwl_mvm_rx_ba_notif(struct iwl_mvm *mvm, struct iwl_rx_cmd_buffer *rxb) if (tid == IWL_MGMT_TID) tid = IWL_MAX_TID_COUNT; + if (IWL_FW_CHECK(mvm, tid >= + ARRAY_SIZE(mvmsta->tid_data), + "invalid TID %d in compressed BA\n", + tid)) + continue; + if (mvmsta) - mvmsta->tid_data[i].lq_color = lq_color; + mvmsta->tid_data[tid].lq_color = lq_color; iwl_mvm_tx_reclaim(mvm, sta_id, tid, (int)(le16_to_cpu(ba_tfd->q_num)), -- 2.53.0