Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 529E154705D; Thu, 17 Sep 2026 18:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789668727; cv=none; b=RmgzadwkRo/RDRbPnTCrELp0YU7RxOOZ4AU05z9w1Ho7ryHQgxIdg/XlfgcwbD31jBC4EPlvLeeSSUyR5QxONhobp01nErXt2K4WtsvNbsIiKX3eyyz7Ha7cC+0FyapzZ8vZktXbN3cie3YS3YCq32r5wX9z1lQlD1D+LW4a6TA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789668727; c=relaxed/simple; bh=rNeP6iind0f3eUY7q1KLxY/H9mhaLNQnJTAEqS+Fd9U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GtQXrJItccHNwWwtUzFMOyaJzDpU5Yd0YgBwgbj0jYaGOPdakuxMcL+a0geJHVO/nBJGOHRrJ3lyH3QZQkLlMTM42xpKwYbDDxlJ2YXrdH17eLOeLUpRI/prs0iNTgaVmjaqSOwfk6vxQvLuMc2p+SjKzmO4jVH9pVLcnl1KsG0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EXdfH9m9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EXdfH9m9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB3F61F000FF; Thu, 17 Sep 2026 18:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789668726; bh=tKQW0/Yb8jj0gOdUknkrsCWCB3HrYljpGX5HYBChoW4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EXdfH9m9iWppfvwSD48/ZFRvXASRgK8vwiJKYjrBb3u7M2wopR1WoCuSQ4/hB0EHj qXMbnyPlF1Igl/+rfGc499gz+/Lqgla9V8OPPEWKQj4R4OdJYr4wIdE+w0bf1Axh64 YVPylf60IoRYHwBrL2F05nzVsjEwgXLCZZeEKZ/c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Milan P. Gandhi" , Laurence Oberman , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 6.12 0522/1102] scsi: mpi3mr: Fix NULL pointer dereference in mpi3mr_sas_port_add() Date: Thu, 17 Sep 2026 16:07:45 +0100 Message-ID: <20260917151552.886016567@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151539.408551884@linuxfoundation.org> References: <20260917151539.408551884@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Milan P. Gandhi [ Upstream commit dba9e2181ca5e875f98b8b9b4535cdaab87dcb0d ] sas_port_alloc_num() can return NULL on memory allocation failure. The return value is passed directly to sas_port_add() without a NULL check, which causes a NULL pointer dereference. Additionally, if sas_port_add() fails, the allocated port is not freed before jumping to out_fail, leaking the sas_port structure. Call sas_port_free() to properly release it. Fixes: e22bae30667a ("scsi: mpi3mr: Add expander devices to STL") Signed-off-by: Milan P. Gandhi Reviewed-by: Laurence Oberman Link: https://patch.msgid.link/20260812103344.174247-2-mgandhi@redhat.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Sasha Levin --- drivers/scsi/mpi3mr/mpi3mr_transport.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c index 0ba9e6a6a13c6..7331237f7506c 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_transport.c +++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c @@ -1428,9 +1428,15 @@ static struct mpi3mr_sas_port *mpi3mr_sas_port_add(struct mpi3mr_ioc *mrioc, } port = sas_port_alloc_num(mr_sas_node->parent_dev); + if (!port) { + ioc_err(mrioc, "failure at %s:%d/%s()!\n", + __FILE__, __LINE__, __func__); + goto out_fail; + } if ((sas_port_add(port))) { ioc_err(mrioc, "failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); + sas_port_free(port); goto out_fail; } -- 2.53.0