Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95973B1ED7; Thu, 17 Sep 2026 17:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789665364; cv=none; b=qbXnHVG4Ow0lI2goqhFAJQGRVXn/NLrIv7UQYcR+l1H6ly5/ZP5d73bQ952EvXFQFUiBz/WL7Z7EfZ0irNVVd2JnZZLCqidK4Q7arkXPqKbMMp3e/cZ9bV8/1ooamBd1L1EWtwuz/kJE6Pjx1wHx0/DXsAgn85Og3qDyY1pnofs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789665364; c=relaxed/simple; bh=gW2dDINiZPPXTBu3vUBFT4DS3Y/zVH1qz3nQI7DvMUM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MH28yOGNPe/qePYxxJpZiqxFFkG0CkdsbMgmrF+m4H+Kbakpy8TMYbHOzPlyJDqzvsZLprYBhMoGFnXkOodzjxW/TPJzOhs9T6/Z4NFjqfjG73IYL9tIRjMPm7JnmJDgCXFp7UW6haO1E3GsBrDykYuLouqeltodC1OGq81Fbdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yoaQlmtV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yoaQlmtV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E32B1F00898; Thu, 17 Sep 2026 17:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789665362; bh=n6zmxgWIVmzyYayi7XK5mcxHl8Iwj/kE3mYN8EgHwQM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yoaQlmtVlM0OOguvvp4BCHtdvGBH8cewk4nGJboGikziUOMGl/e6xIbWFK6RHasyH ReiNVkMfdPrnGKpp+uI3am5eFtKuGVO1zsYLAU4AXZrNgX105quNnz/EhASJDaUiU2 QsOd7QK7pElZUGRG6xuTytsAXFTNAe6uxjnYcKXo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Selvamani Rajagopal , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 0679/1250] net: ethernet: oa_tc6: Fix for the wrong data type Date: Thu, 17 Sep 2026 16:07:54 +0100 Message-ID: <20260917151610.288583645@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151551.901433442@linuxfoundation.org> References: <20260917151551.901433442@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Selvamani Rajagopal [ Upstream commit 3cc2aa96b97184abd6fc106aac626ddf14389813 ] Inadvertently bool data type is used where int is supposed to be used. This might turn a negative error code into true or false and sign of the return code would be lost. Fixes: 8f9bf857e43b ("net: ethernet: oa_tc6: implement internal PHY initialization") Signed-off-by: Selvamani Rajagopal Link: https://patch.msgid.link/20260824-fix-race-condition-and-crash-v7-4-4323279b18f2@onsemi.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/oa_tc6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/oa_tc6.c b/drivers/net/ethernet/oa_tc6.c index e4949a310af2f..b6743710608fe 100644 --- a/drivers/net/ethernet/oa_tc6.c +++ b/drivers/net/ethernet/oa_tc6.c @@ -411,7 +411,7 @@ static int oa_tc6_mdiobus_read(struct mii_bus *bus, int addr, int regnum) { struct oa_tc6 *tc6 = bus->priv; u32 regval; - bool ret; + int ret; ret = oa_tc6_read_register(tc6, OA_TC6_PHY_STD_REG_ADDR_BASE | (regnum & OA_TC6_PHY_STD_REG_ADDR_MASK), -- 2.53.0