Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11484547046; Thu, 17 Sep 2026 17:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789666424; cv=none; b=aMq27UJmywkLXRoYURTwH4guiCMQeAKyou2rPy48Xpjcxz5wumM7i4i0J5MwB6SzJuLSjyYgVdTSjw7NSMD/+nLAWjWz8TPxbmb2sXvA0P7sNLFr4A9XU6CnWN+R6k81mrG6gPNzP2BzCtP3txnvFywwrYpSh4gXIBwNoSoGGmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789666424; c=relaxed/simple; bh=KqTDAceQi36cKIVRicqF3LDUAttxd+i9HXqjmPoWc/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E7HlWI1/Wicm4uMpMrAmP+WZz5LQNSV8WqILvp7jQmllyoyr3jpEe5zf1GDba8C0fm1uilB0QFUYQauwWjnrzWYmJi8ceXClHXGOenKglvPccCQtaN87fh/QELRcauw9RJ9Wh5IYe1uTAM+ixIkZokgUnfsFpvfqvRcz9TpciLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ucKvB7cm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ucKvB7cm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69DF41F000FF; Thu, 17 Sep 2026 17:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789666423; bh=7YYySxfSjmmS7tbvTgghIefkiVbq/GBjiEjb4NAAHsM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ucKvB7cm/1PrEErm1vW1tf5dxQCJkoH7Gi66reVLxF1udLZ2IyslG4n+4lYG2Foxi +slWNSWJY4XOYCDlMNwV6cUWR7N8fQr6KJg+ioNq+t6dmK6Etsj8EvM/URwP8bfIPe Ou2OY7z8X1zYe4bNiCoHeks4me7dE8KtUN1BfnUI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Miquel Raynal , Fan Wu , Stefan Schmidt Subject: [PATCH 6.18 1033/1250] ieee802154: cc2520: fix FIFOP work use-after-free Date: Thu, 17 Sep 2026 16:13:48 +0100 Message-ID: <20260917151620.076272723@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151551.901433442@linuxfoundation.org> References: <20260917151551.901433442@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu commit ff5891b266a7fc6a062710836be84f1cc19338b5 upstream. The FIFOP interrupt handler queues cc2520_fifop_irqwork. On removal, cc2520_remove() only flushes the work. The devm-managed FIFOP IRQ remains active until after ->remove() returns and can queue the work again after that flush, allowing it to run after the private data is released. Disable the work with disable_work_sync() instead of flushing it, so the handler can no longer queue it once removal begins. Destroy the buffer mutex last, since the worker and the stop callback invoked through ieee802154_unregister_hw() both take it. Found by an in-house static analysis tool. Fixes: 0da6bc8cc341 ("ieee802154: cc2520: adds driver for TI CC2520 radio") Cc: stable@vger.kernel.org # v6.10+ Suggested-by: Miquel Raynal Reviewed-by: Miquel Raynal Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Link: https://lore.kernel.org/20260812061714.175966-1-fanwu01@zju.edu.cn Signed-off-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/cc2520.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/drivers/net/ieee802154/cc2520.c +++ b/drivers/net/ieee802154/cc2520.c @@ -1156,11 +1156,10 @@ static void cc2520_remove(struct spi_dev { struct cc2520_private *priv = spi_get_drvdata(spi); - mutex_destroy(&priv->buffer_mutex); - flush_work(&priv->fifop_irqwork); - + disable_work_sync(&priv->fifop_irqwork); ieee802154_unregister_hw(priv->hw); ieee802154_free_hw(priv->hw); + mutex_destroy(&priv->buffer_mutex); } static const struct spi_device_id cc2520_ids[] = {